[PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

[PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

[Joseph Hemann]

gcc_version returned by compiler is a string, and needs to be converted
to a integer before testing

Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Cc: Irene Park <ipark@nvidia.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Signed-off-by: Joseph Hemann <joseph.hemann@arm.com>
Change-Id: I24f3f52c12660928b58e6f836fdef86890688d26
---
 uefi-sct/SctPkg/build.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
index d0c7f16e172c..cad17ccdedc7 100755
--- a/uefi-sct/SctPkg/build.sh
+++ b/uefi-sct/SctPkg/build.sh
@@ -56,8 +56,8 @@ function get_gcc_version
 {
 	gcc_version=$($1 -dumpversion)
 
-    if [ "$gcc_version" -gt "5" ]; then
-        gcc_version="5"
+    if [ ${gcc_version%%.*} -gt 5 ]; then
+        gcc_version=5
     fi
 
 	case $gcc_version in
-- 
2.17.1

Re: [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

[Samer El-Haj-Mahmoud]

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>


> -----Original Message-----
> From: Joseph Hemann <joseph.hemann@arm.com>
> Sent: Wednesday, August 26, 2020 5:46 PM
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Eric Jin
> <eric.jin@intel.com>; Irene Park <ipark@nvidia.com>; Heinrich Schuchardt
> <xypron.glpk@gmx.de>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
> Subject: [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer
>
> gcc_version returned by compiler is a string, and needs to be converted to a
> integer before testing
>
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
> Cc: Irene Park <ipark@nvidia.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Signed-off-by: Joseph Hemann <joseph.hemann@arm.com>
> Change-Id: I24f3f52c12660928b58e6f836fdef86890688d26
> ---
>  uefi-sct/SctPkg/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> d0c7f16e172c..cad17ccdedc7 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,8 +56,8 @@ function get_gcc_version  {
>  gcc_version=$($1 -dumpversion)
>
> -    if [ "$gcc_version" -gt "5" ]; then
> -        gcc_version="5"
> +    if [ ${gcc_version%%.*} -gt 5 ]; then
> +        gcc_version=5
>      fi
>
>  case $gcc_version in
> --
> 2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 58 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>

[-- Attachment #2: Type: text/html, Size: 474 bytes --]

Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Upstreamed by Commit-ID:
https://github.com/tianocore/edk2-test/commit/323883de08ec30072c683d7e0602158e6e3e66fe

On Mon, Sep 14, 2020 at 02:53 PM, G Edhaya Chandran wrote:

> 
> Reviewed-by: G Edhaya Chandran <edhaya.chandran@...>

[-- Attachment #2: Type: text/html, Size: 417 bytes --]