public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused
Date: Tue, 25 Sep 2018 11:15:28 +0100	[thread overview]
Message-ID: <3570196b-4027-284a-e332-3121621bdc7e@solarflare.com> (raw)

This fixes unused const variable gcc 7.3 compilation error. Array is not
simply removed as the list of invalid characters might be salient
in future and for easy documentation.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
---
 ShellPkg/Application/Shell/Shell.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 397cfd1994..38b002a144 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -2751,7 +2751,7 @@ RunCommand(
 }
 
 
-STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
+STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
 
 /**
   Function to process a NSH script file via SHELL_FILE_HANDLE.
-- 
2.17.1



             reply	other threads:[~2018-09-25 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 10:15 Tomas Pilar (tpilar) [this message]
2018-09-25 14:50 ` [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused Carsey, Jaben
2018-09-26  1:54   ` Ni, Ruiyu
2018-09-26  4:54   ` Ni, Ruiyu
2018-09-26 10:10     ` Tomas Pilar (tpilar)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3570196b-4027-284a-e332-3121621bdc7e@solarflare.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox