From: "Pete Batard" <pete@akeo.ie>
To: Andrei Warkentin <andrey.warkentin@gmail.com>, devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, philmd@redhat.com
Subject: Re: [edk2-platforms][PATCH 2/2] RPi: remove any mention of an "internal DTB"
Date: Fri, 1 May 2020 11:47:13 +0100 [thread overview]
Message-ID: <3586219c-cba4-6983-e8d6-9e23fe3663c1@akeo.ie> (raw)
In-Reply-To: <20200430211617.120926-3-andrey.warkentin@gmail.com>
On 2020.04.30 22:16, Andrei Warkentin wrote:
> For Pi 3 and Pi 4, since the relevant functionality is gone from FdtDxe.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
> ---
> Platform/RaspberryPi/RPi3/Readme.md | 3 +--
> Platform/RaspberryPi/RPi4/Readme.md | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi3/Readme.md b/Platform/RaspberryPi/RPi3/Readme.md
> index f19d59d8..66f52bee 100644
> --- a/Platform/RaspberryPi/RPi3/Readme.md
> +++ b/Platform/RaspberryPi/RPi3/Readme.md
> @@ -125,8 +125,7 @@ Note: the address range **must** be `[0x1f0000:0x200000]`. `dtoverlay` and `dtpa
> This firmware will honor the command line passed by the GPU via `cmdline.txt`.
>
> Note, that the ultimate contents of `/chosen/bootargs` are a combination of several pieces:
> -- Original `/chosen/bootargs` if using the internal DTB. Seems to be completely discarded by GPU when booting with a custom device tree.
> -- GPU-passed hardware configuration. This one is always present.
> +- GPU-passed hardware configuration.
> - Additional boot options passed via `cmdline.txt`.
>
> # Limitations
> diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi4/Readme.md
> index 62a63c4c..03eb6c39 100644
> --- a/Platform/RaspberryPi/RPi4/Readme.md
> +++ b/Platform/RaspberryPi/RPi4/Readme.md
> @@ -103,8 +103,7 @@ Note: the address range **must** be `[0x1f0000:0x200000]`. `dtoverlay` and `dtpa
> This firmware will honor the command line passed by the GPU via `cmdline.txt`.
>
> Note, that the ultimate contents of `/chosen/bootargs` are a combination of several pieces:
> -- Original `/chosen/bootargs` if using the internal DTB. Seems to be completely discarded by GPU when booting with a custom device tree.
> -- GPU-passed hardware configuration. This one is always present.
> +- GPU-passed hardware configuration.
> - Additional boot options passed via `cmdline.txt`.
>
> # Limitations
>
Reviewed-by: Pete Batard <pete@akeo.ie>
next prev parent reply other threads:[~2020-05-01 10:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 21:16 [edk2-platforms][PATCH 0/2] Rip out "internal DTB" support in FdtDxe Andrei Warkentin
2020-04-30 21:16 ` [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB Andrei Warkentin
2020-05-01 10:45 ` Pete Batard
2020-05-01 13:19 ` Ard Biesheuvel
2020-05-01 15:11 ` Pete Batard
2020-05-01 15:13 ` Ard Biesheuvel
2020-05-01 15:16 ` Pete Batard
2020-05-01 16:56 ` [edk2-devel] " Andrei Warkentin
2020-05-01 17:04 ` Ard Biesheuvel
2020-04-30 21:16 ` [edk2-platforms][PATCH 2/2] RPi: remove any mention of an "internal DTB" Andrei Warkentin
2020-05-01 10:47 ` Pete Batard [this message]
2020-05-01 17:08 ` [edk2-platforms][PATCH 0/2] Rip out "internal DTB" support in FdtDxe Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3586219c-cba4-6983-e8d6-9e23fe3663c1@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox