From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.7414.1588330036788162095 for ; Fri, 01 May 2020 03:47:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=faKpjJtZ; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id o27so5769926wra.12 for ; Fri, 01 May 2020 03:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EjT9HFiYyfcLFP61On2oy+gP1s1OJp0QJqjoeBV6Z1I=; b=faKpjJtZumDBOoiuFbL99zOWIftynnB3HLcw3fHvONha+tEAlo8ETKiUxFipN1YcVS RTj5/5JCSFobG233He6Hr6dQ2ie8qrVsbHOLCx6zeGvkziRL1mdMTe0jyDXfgUsyQns3 vGlm+n4AD0DaX3pBSWRS7RV6ybUJ37HLDFXkEOt800KDTdGNLRjIOE0gOwB47CnI3ikk BgTZZ9fAfKfmN4OhTwEhAAEYXp1LxrD7q31AGw5B20Sf0BaSotv+zmrAwA2s/K4WhdL3 es46De0yBVbdlq0N51qabV6Nyvswtc2kXoNeIGvtMJR6BUTqUN4bfcwLh543MMcqRr3c KX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EjT9HFiYyfcLFP61On2oy+gP1s1OJp0QJqjoeBV6Z1I=; b=lc7EcnxHvQLrQkwNQg0JRWxa/5ODAzn8orfn9qLM84zyWqqGfcJrJ/IUpnXQ5mA6WP LnQKCmZ1+IDw99II7J1BNdPSnjBPzwyFVIq7cYpuAQCQsQeNuXaUpCWnNnKm5b1moDh1 JZ5IL4e1iULnHxGl7mlYX+cK+8yxdlHOEe5rpkUSZQzJS2ccfU+fpE85MwlS4ldFKASv q78KsLcAQf66V74kGV4eyhk/hW7+9hsh86juzq4UPAtvH1fW0yd9Abm1yeL62Szyhi3d gAq9exgyEh/UW9Duwzu5WiMwfVQdmbc0phpsYAx/pKKBJ0juKjLg0N4MkjmZidpGIE+z 1ICg== X-Gm-Message-State: AGi0PuZ3qwrqNxqFjyh2YO0WI/H7RGLWnCzmyANHDkarX6t+LMZzmdur XeGHGoRfDliTmkNus3ceU6c2qg== X-Google-Smtp-Source: APiQypJv/T8t53t/eX2e0JBaO8WRwSIRVUfDvu5JUne4NgGoXDMAMdrk7aFgnYdvePtcuuUCmVbIyg== X-Received: by 2002:a5d:4203:: with SMTP id n3mr3782611wrq.255.1588330035359; Fri, 01 May 2020 03:47:15 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.75.87]) by smtp.googlemail.com with ESMTPSA id h5sm3948166wrp.97.2020.05.01.03.47.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2020 03:47:14 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 2/2] RPi: remove any mention of an "internal DTB" To: Andrei Warkentin , devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, philmd@redhat.com References: <20200430211617.120926-1-andrey.warkentin@gmail.com> <20200430211617.120926-3-andrey.warkentin@gmail.com> From: "Pete Batard" Message-ID: <3586219c-cba4-6983-e8d6-9e23fe3663c1@akeo.ie> Date: Fri, 1 May 2020 11:47:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200430211617.120926-3-andrey.warkentin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.04.30 22:16, Andrei Warkentin wrote: > For Pi 3 and Pi 4, since the relevant functionality is gone from FdtDxe. > > Signed-off-by: Andrei Warkentin > --- > Platform/RaspberryPi/RPi3/Readme.md | 3 +-- > Platform/RaspberryPi/RPi4/Readme.md | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi3/Readme.md b/Platform/RaspberryPi/RPi3/Readme.md > index f19d59d8..66f52bee 100644 > --- a/Platform/RaspberryPi/RPi3/Readme.md > +++ b/Platform/RaspberryPi/RPi3/Readme.md > @@ -125,8 +125,7 @@ Note: the address range **must** be `[0x1f0000:0x200000]`. `dtoverlay` and `dtpa > This firmware will honor the command line passed by the GPU via `cmdline.txt`. > > Note, that the ultimate contents of `/chosen/bootargs` are a combination of several pieces: > -- Original `/chosen/bootargs` if using the internal DTB. Seems to be completely discarded by GPU when booting with a custom device tree. > -- GPU-passed hardware configuration. This one is always present. > +- GPU-passed hardware configuration. > - Additional boot options passed via `cmdline.txt`. > > # Limitations > diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi4/Readme.md > index 62a63c4c..03eb6c39 100644 > --- a/Platform/RaspberryPi/RPi4/Readme.md > +++ b/Platform/RaspberryPi/RPi4/Readme.md > @@ -103,8 +103,7 @@ Note: the address range **must** be `[0x1f0000:0x200000]`. `dtoverlay` and `dtpa > This firmware will honor the command line passed by the GPU via `cmdline.txt`. > > Note, that the ultimate contents of `/chosen/bootargs` are a combination of several pieces: > -- Original `/chosen/bootargs` if using the internal DTB. Seems to be completely discarded by GPU when booting with a custom device tree. > -- GPU-passed hardware configuration. This one is always present. > +- GPU-passed hardware configuration. > - Additional boot options passed via `cmdline.txt`. > > # Limitations > Reviewed-by: Pete Batard