From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io,
Alexei.Fedorov@arm.com, nd <nd@arm.com>
Subject: Re: [PATCH v3 00/21] Create a SSDT CPU topology generator
Date: Fri, 8 Oct 2021 17:05:24 +0100 [thread overview]
Message-ID: <359d9a1c-a793-2d0c-1ff8-fe65c06e54fd@arm.com> (raw)
In-Reply-To: <20211008144632.31894-1-Pierre.Gondois@arm.com>
Merged as 30400318a278..769e63999ff5
Thanks.
Regards,
Sami Mujawar
On 08/10/2021 03:46 PM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> v2:
> - Update or error handling. [Sami/Pierre]
> - Various comments. [Sami]
> and
> New patches:
> DynamicTablesPkg: Remove unnecessary includes
> DynamicTablesPkg: Add missing parameter check
> DynamicTablesPkg: Add AddSsdtAcpiHeader()
> DynamicTablesPkg: Add AmlRdSetEndTagChecksum()
> DynamicTablesPkg: Add AmlSetRdListCheckSum()
> DynamicTablesPkg: Set EndTag's Checksum if RdList is modified
> DynamicTablesPkg: Clear pointer in node creation fcts
> DynamicTablesPkg: Update error handling for node creation
>
> v3:
> -Fix typo and error handling. [Sami]
>
> As part of the DynamicTablesPkg, add a generator creating a
> SSDT table representing a CPU topology. Low Power Idle (LPI)
> states can also be generated along the CPUs.
> This patch-set also adds new functions to generate AML bytecode.
>
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1449_Create_ssdt_cpu_topology_generator_v3
>
> Pierre Gondois (21):
> DynamicTablesPkg: Remove unnecessary includes
> DynamicTablesPkg: Add missing parameter check
> DynamicTablesPkg: Add AddSsdtAcpiHeader()
> DynamicTablesPkg: Add AmlRdSetEndTagChecksum()
> DynamicTablesPkg: Add AmlSetRdListCheckSum()
> DynamicTablesPkg: Set EndTag's Checksum if RdList is modified
> DynamicTablesPkg: Clear pointer in node creation fcts
> DynamicTablesPkg: Update error handling for node creation
> DynamicTablesPkg: Make AmlNodeGetIntegerValue public
> DynamicTablesPkg: AML Code generation for Register()
> DynamicTablesPkg: AML Code generation for Resource data EndTag
> DynamicTablesPkg: AML code generation for a Package
> DynamicTablesPkg: Helper function to compute package length
> DynamicTablesPkg: AML code generation for a ResourceTemplate
> DynamicTablesPkg: AML code generation for a Method
> DynamicTablesPkg: AML code generation to Return a NameString
> DynamicTablesPkg: AML code generation for a Method returning a NS
> DynamicTablesPkg: AML code generation for a _LPI object
> DynamicTablesPkg: AML code generation to add an _LPI state
> DynamicTablesPkg: Add CM_ARM_LPI_INFO object
> DynamicTablesPkg: SSDT CPU topology and LPI state generator
>
> DynamicTablesPkg/DynamicTables.dsc.inc | 6 +
> DynamicTablesPkg/Include/AcpiTableGenerator.h | 7 +-
> .../Include/ArmNameSpaceObjects.h | 68 +
> .../Include/Library/AmlLib/AmlLib.h | 168 ++
> .../Include/Library/TableHelperLib.h | 35 +
> .../SsdtCmn600Generator.c | 2 -
> .../SsdtCpuTopologyGenerator.c | 1228 +++++++++++++++
> .../SsdtCpuTopologyGenerator.h | 134 ++
> .../SsdtCpuTopologyLibArm.inf | 33 +
> .../SsdtSerialPortGenerator.c | 3 -
> .../Library/Common/AmlLib/AmlEncoding/Aml.c | 87 +-
> .../Library/Common/AmlLib/AmlEncoding/Aml.h | 47 +-
> .../Common/AmlLib/CodeGen/AmlCodeGen.c | 1350 ++++++++++++++++-
> .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 210 ++-
> .../AmlLib/CodeGen/AmlResourceDataCodeGen.h | 92 ++
> .../AmlLib/ResourceData/AmlResourceData.c | 33 +
> .../AmlLib/ResourceData/AmlResourceData.h | 21 +
> .../Library/Common/AmlLib/Tree/AmlClone.c | 2 -
> .../Library/Common/AmlLib/Tree/AmlNode.c | 18 +-
> .../Library/Common/AmlLib/Tree/AmlNode.h | 12 +-
> .../Common/AmlLib/Tree/AmlNodeInterface.c | 7 +
> .../Library/Common/AmlLib/Tree/AmlTree.c | 72 +-
> .../Library/Common/AmlLib/Utils/AmlUtility.c | 79 +-
> .../Library/Common/AmlLib/Utils/AmlUtility.h | 50 +-
> .../SsdtSerialPortFixupLib.c | 1 -
> .../ConfigurationManagerObjectParser.c | 35 +
> .../Common/TableHelperLib/TableHelper.c | 89 ++
> 27 files changed, 3814 insertions(+), 75 deletions(-)
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyLibArm.inf
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2021-10-08 16:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 14:46 [PATCH v3 00/21] Create a SSDT CPU topology generator PierreGondois
2021-10-08 14:46 ` [PATCH v3 01/21] DynamicTablesPkg: Remove unnecessary includes PierreGondois
2021-10-08 14:46 ` [PATCH v3 02/21] DynamicTablesPkg: Add missing parameter check PierreGondois
2021-10-08 14:46 ` [PATCH v3 03/21] DynamicTablesPkg: Add AddSsdtAcpiHeader() PierreGondois
2021-10-08 14:46 ` [PATCH v3 04/21] DynamicTablesPkg: Add AmlRdSetEndTagChecksum() PierreGondois
2021-10-08 14:46 ` [PATCH v3 05/21] DynamicTablesPkg: Add AmlSetRdListCheckSum() PierreGondois
2021-10-08 14:46 ` [PATCH v3 06/21] DynamicTablesPkg: Set EndTag's Checksum if RdList is modified PierreGondois
2021-10-08 14:46 ` [PATCH v3 07/21] DynamicTablesPkg: Clear pointer in node creation fcts PierreGondois
2021-10-08 14:46 ` [PATCH v3 08/21] DynamicTablesPkg: Update error handling for node creation PierreGondois
2021-10-08 14:46 ` [PATCH v3 09/21] DynamicTablesPkg: Make AmlNodeGetIntegerValue public PierreGondois
2021-10-08 14:46 ` [PATCH v3 10/21] DynamicTablesPkg: AML Code generation for Register() PierreGondois
2021-10-08 14:46 ` [PATCH v3 11/21] DynamicTablesPkg: AML Code generation for Resource data EndTag PierreGondois
2021-10-08 14:46 ` [PATCH v3 12/21] DynamicTablesPkg: AML code generation for a Package PierreGondois
2021-10-08 14:46 ` [PATCH v3 13/21] DynamicTablesPkg: Helper function to compute package length PierreGondois
2021-10-08 14:46 ` [PATCH v3 14/21] DynamicTablesPkg: AML code generation for a ResourceTemplate PierreGondois
2021-10-08 14:46 ` [PATCH v3 15/21] DynamicTablesPkg: AML code generation for a Method PierreGondois
2021-10-08 14:46 ` [PATCH v3 16/21] DynamicTablesPkg: AML code generation to Return a NameString PierreGondois
2021-10-08 14:46 ` [PATCH v3 17/21] DynamicTablesPkg: AML code generation for a Method returning a NS PierreGondois
2021-10-08 14:46 ` [PATCH v3 18/21] DynamicTablesPkg: AML code generation for a _LPI object PierreGondois
2021-10-08 14:46 ` [PATCH v3 19/21] DynamicTablesPkg: AML code generation to add an _LPI state PierreGondois
2021-10-08 14:46 ` [PATCH v3 20/21] DynamicTablesPkg: Add CM_ARM_LPI_INFO object PierreGondois
2021-10-08 14:46 ` [PATCH v3 21/21] DynamicTablesPkg: SSDT CPU topology and LPI state generator PierreGondois
2021-10-08 16:05 ` Sami Mujawar [this message]
2021-10-11 1:16 ` 回复: [edk2-devel] [PATCH v3 00/21] Create a SSDT CPU topology generator gaoliming
2021-10-11 7:40 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=359d9a1c-a793-2d0c-1ff8-fe65c06e54fd@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox