From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in2.apple.com (mail-out2.apple.com [17.151.62.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A7ED1A1E56 for ; Wed, 19 Oct 2016 16:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1476920381; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HNpmfJnMJNZRQrWCfcx1HrdA1NQqKwzVL3wPKVByUM8=; b=kQa54o4mNE97zvZ2dEMP2aYe+xMWym3WwMRSuqeph5oNJ773rXmGyRgxe+SMKXa0 odo4wZRny5XbSFZ4GIWWHy3fsYZ47dkNVAV7LAAC/JG0t4iCWFOiP4I0rl1OugOM znbFaBugYyIpS7QbgorhkypLWE/U5YZa1a02BIWnIQyB6bEkZbG5EwICaT+x1d0w 2PS2uEdcbXPPQNAXjHwHzZNl3b8uVsqZutfHMl94V5pv8RB73IXer2oLu+oso/Ne N7UnrzmIfpOitPjPZ0XRWkR+/HmTPHzE/Fy+AcWfw3OXpxqzD0gDWXXRU3hRnB4r +vHuoreqDNp+g5c5N/AsZg==; Received: from relay3.apple.com (relay3.apple.com [17.128.113.83]) by mail-in2.apple.com (Apple Secure Mail Relay) with SMTP id 7D.C3.06856.C3408085; Wed, 19 Oct 2016 16:39:41 -0700 (PDT) X-AuditID: 11973e11-8d1ff70000001ac8-5a-5808043c5eff Received: from nwk-mmpp-sz08.apple.com (nwk-mmpp-sz08.apple.com [17.128.115.25]) by relay3.apple.com (Apple SCV relay) with SMTP id E7.CA.13773.C3408085; Wed, 19 Oct 2016 16:39:40 -0700 (PDT) MIME-version: 1.0 Received: from [17.114.152.106] by nwk-mmpp-sz08.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OFB00DYTJ24XH00@nwk-mmpp-sz08.apple.com>; Wed, 19 Oct 2016 16:39:40 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: Date: Wed, 19 Oct 2016 16:39:40 -0700 Cc: "edk2-devel@lists.01.org" Message-id: <35C6824F-AF9E-45D2-B380-17E9547411F1@apple.com> References: To: Sean Brogan X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJLMWRmVeSWpSXmKPExsUi2FAYrGvLwhFhcK9d0WLPoaPMFgsfbWZ2 YPLonv2PxaN1x1/2AKYoLpuU1JzMstQifbsErowN3/+yFUxXrDjwai9rA+NfyS5GTg4JAROJ FdMnsHcxcnEICexllHh09QQTTKLr9CEWiMRBRonPU7pYQBK8AoISPybfA7I5OJgF5CUOnpcF CTMLaEl8f9QKViIk8J5R4vpbdRBbWEBc4t2ZTcwQdoDE1Web2EFsNgFliRXzP4DZnALxEg++ n2MDsVkEVCXaf59hgphpLjHjwhcmiLU2El///GGFmB8ncXVmD9hMEQFticufVzOBnCMhICsx +5cXyMkSAhvYJNqmrGWfwCg8C8nVsxCunoXk6gWMzKsYhXITM3N0M/OM9BILCnJS9ZLzczcx gsJ6up3gDsbjq6wOMQpwMCrx8B64wB4hxJpYVlyZe4hRmoNFSZy3dgNbhJBAemJJanZqakFq UXxRaU5q8SFGJg5OqQbGJtOLDN32pyrUo5a7vKpKZbJIj52pcbV81tJCBmOT5yeZPj+d9avT 5vekOUmzfmzjZBe62GEo/cl1hueVrMojOWmKR/QZ9BV0DDnfzVni8UShWnfX89z/ZXVrfX5Y Slbrp++b6PVU0n75svWZPUx1FrfXXgoL3HjrWVRI+Yp9P1iDf9fPjtBRYinOSDTUYi4qTgQA fGT54UwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42IRbCiW1LVh4YgwOHRK32LPoaPMFgsfbWZ2 YPLonv2PxaN1x1/2AKYoLpuU1JzMstQifbsErowN3/+yFUxXrDjwai9rA+NfyS5GTg4JAROJ rtOHWCBsMYkL99azdTFycQgJHGSU+DylCyzBKyAo8WPyPSCbg4NZQF7i4HlZkDCzgJbE90et YCVCAu8ZJa6/VQexhQXEJd6d2cQMYQdIXH22iR3EZhNQllgx/wOYzSkQL/Hg+zk2EJtFQFWi /fcZJoiZ5hIzLnxhglhrI/H1zx9WiPlxEldn9oDNFBHQlrj8eTUTyDkSArISs395TWAUnIXk 0FkIh85CcugCRuZVjAJFqTmJlcZ6iQUFOal6yfm5mxjB4VkYvIPxzzKrQ4wCHIxKPLwZ59gj hFgTy4orcw8xSnAwK4nwTtkAFOJNSaysSi3Kjy8qzUktPsSYDHT+RGYp0eR8YOzklcQbmpgY mBgbmxkbm5uYkyasJM7L/wxohUB6YklqdmpqQWoRzBYmDk6pBsYcvaWbDu08YL/I6bH/yb+c hlc69/b9bGH/6H2qLrqHO/rWQ43vbz7fE/gpuunam+WnPqVON/2/R9JJQ/q5W6F3lmz00qtl 6/cu/VZU1Bf+7sq3vYvT+8O9N7hMemvyr+DHJyMPNX29nad58/e/7WZX6Ds2tXj7i4kKwVMb /P2cv235YBB++buSEktxRqKhFnNRcSIAjroISJMCAAA= Subject: Re: question about a compressed Ffs3 file inside FFS2 filesystem X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 23:39:42 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Oct 19, 2016, at 4:09 PM, Sean Brogan wrote: > > We have a condition that occurs when we boot where we see the following message and our boot fails because of it. > DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted section in a non-FFS3 formatted FV.\n")); > > Which is on line 773 of FwVol.c ( https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Pei/FwVol/FwVol.c ) > > The condition is caused by a large firmware volume (greater than 16mb) that is compressed and put into a smaller FV (less than 16mb). My question is why isn't this allowed (seems like a valid scenario). Volinfo supports this and decodes binary fine. The PI Vol 3 spec has a section 3.2.2 EFI_FIRMWARE_FILE_SYSTEM3_GUID which says FileSystem2 doesn't support large files but it seems that the code is not taking into account that the section is compressed and therefore you can have a large file inside a compressed section inside a FV with File System2. > > Feedback/thoughts/comments/Bug? > Sean, If I understand correctly you are stating that the contents of an Encapsulation section should not have any restrictions on content type. The only error checking should be that the raw encapsulation section data needs to fit into the file type. That seems reasonable to me? I'm not sure if the PI spec makes some statement that the code is enforcing, or I guess the PI spec could be vague and people are interpreting it differently. Thanks, Andrew Fish > Here are some details of my scenario. > Compressed FV has filesystem == 8c8ce578-8a3d-4f1c-9935-896185c32dd3 (ffs3) > Non compressed FV has filesystem == 5473c07a-3dcb-4dca-bd6f-1e9689e7349a (ffs2) > > VolInfo dump of the Non Compressed FV showing the nested/compressed FV inside. > > Decoding > VolInfo Version 1.0 Build Build 20909 > Signature: _FVH (4856465F) > Attributes: 4FEFF > EFI_FVB2_READ_DISABLED_CAP > EFI_FVB2_READ_ENABLED_CAP > EFI_FVB2_READ_STATUS > EFI_FVB2_WRITE_DISABLED_CAP > EFI_FVB2_WRITE_ENABLED_CAP > EFI_FVB2_WRITE_STATUS > EFI_FVB2_LOCK_CAP > EFI_FVB2_LOCK_STATUS > EFI_FVB2_STICKY_WRITE > EFI_FVB2_MEMORY_MAPPED > EFI_FVB2_ERASE_POLARITY > EFI_FVB2_READ_LOCK_CAP > EFI_FVB2_READ_LOCK_STATUS > EFI_FVB2_WRITE_LOCK_CAP > EFI_FVB2_WRITE_LOCK_STATUS > EFI_FVB2_ALIGNMENT_16 > EFI_FVB2_ALIGNMENT_32 > EFI_FVB2_ALIGNMENT_64 > EFI_FVB2_ALIGNMENT_128 > EFI_FVB2_ALIGNMENT_4K > EFI_FVB2_ALIGNMENT_8K > EFI_FVB2_ALIGNMENT_16K > EFI_FVB2_ALIGNMENT_32K > EFI_FVB2_ALIGNMENT_1M > EFI_FVB2_ALIGNMENT_2M > EFI_FVB2_ALIGNMENT_4M > EFI_FVB2_ALIGNMENT_8M > EFI_FVB2_ALIGNMENT_256M > EFI_FVB2_ALIGNMENT_512M > EFI_FVB2_ALIGNMENT_1G > EFI_FVB2_ALIGNMENT_2G > Header Length: 0x00000048 > File System ID: 5473c07a-3dcb-4dca-bd6f-1e9689e7349a > Revision: 0x0002 > Number of Blocks: 0x00000028 > Block Length: 0x00010000 > Total Volume Size: 0x00280000 > ============================================================ > File Name: 9E21FD93-9C72-4C15-8C4B-E77F1DB2D792 > File Offset: 0x00000048 > File Length: 0x001F3FFD > File Attributes: 0x00 > File State: 0xF8 > EFI_FILE_DATA_VALID > File Type: 0x0B EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE > ------------------------------------------------------------ > Type: EFI_SECTION_GUID_DEFINED > Size: 0x001F3FE5 > SectionDefinitionGuid: ee4e5898-3914-4259-9d6e-dc7bd79403cf > > DataOffset: 0x0018 > Attributes: 0x0001 > ------------------------------------------------------------ > Type: EFI_SECTION_RAW > Size: 0x00000FF8 > ------------------------------------------------------------ > Type: EFI_SECTION_FIRMWARE_VOLUME_IMAGE > Size: 0x01010008 > ============================================================ > > Thanks > Sean > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel