From: "Corvin Köhne" <corvink@FreeBSD.org>
To: devel@edk2.groups.io, mikuback@linux.microsoft.com,
ardb@kernel.org, Rebecca Cran <rebecca@bsdio.com>,
Michael Kinney <michael.d.kinney@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Peter Grehan <grehan@freebsd.org>
Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB
Date: Mon, 14 Aug 2023 10:15:42 +0200 [thread overview]
Message-ID: <35b68f61774b96e6b68e72c6ca056a10d2601087.camel@FreeBSD.org> (raw)
In-Reply-To: <47a7e3eb-2049-bbc3-3e74-0c115f00702e@linux.microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> I'm not sure why test results are not being reported that may be a
> larger issue.
>
> I pulled the branch locally, run uncrustify, and it automatically
> fixed
> the code to pass.
>
> The issue is the following function call:
>
> BuildPlatformInfoHob();
>
> Should be:
>
> BuildPlatformInfoHob ();
>
I already run uncrustify locally but it doesn't complain about it.
Thank you!
Should I resend an updated patch?
Can this change make it into edk-stable202308? Otherwise, fwcfg won't
be usable by bhyve in this version.
--
Kind regards,
Corvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107728): https://edk2.groups.io/g/devel/message/107728
Mute This Topic: https://groups.io/mt/100327419/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-14 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 12:59 [edk2-devel] [PATCH v1 0/1] OvmfPkg/Bhyve: build PlatformInfoHob Corvin Köhne
2023-07-24 12:59 ` [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB Corvin Köhne
2023-08-08 13:32 ` Rebecca Cran
2023-08-08 16:25 ` Ard Biesheuvel
2023-08-10 12:53 ` Corvin Köhne
2023-08-10 12:55 ` Ard Biesheuvel
2023-08-10 13:33 ` Corvin Köhne
2023-08-10 15:46 ` Ard Biesheuvel
2023-08-10 19:54 ` Michael Kubacki
2023-08-14 8:15 ` Corvin Köhne [this message]
2023-08-15 8:10 ` Ard Biesheuvel
2023-08-18 12:32 ` Ard Biesheuvel
[not found] ` <1774CF3EF23450CD.25264@groups.io>
2023-08-07 11:31 ` Corvin Köhne
2023-08-07 16:52 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b68f61774b96e6b68e72c6ca056a10d2601087.camel@FreeBSD.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox