From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B387A7803DB for ; Mon, 14 Aug 2023 08:15:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w0HclUEjLiE/ZJkyJQzeQsnOBc5aswoVO1KcsPMjwFA=; c=relaxed/simple; d=groups.io; h=ARC-Message-Signature:ARC-Seal:ARC-Authentication-Results:Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692000948; v=1; b=wYkeGHwH5b1BaHr6HrvzJntptDXCFhUhpTAX4UdFlBIi0VW7dQBMfDBnKYZVgOB+2aMaQ/V6 wKMrR2LIGDgM10kysHLP8ZySHPupCa/NVehMSzjzm71d/YK+LDOK86/+T/8IGwCp3NJXbDQsqeA j/+UVdaOKqthvT5ocyg2C8rg= X-Received: by 127.0.0.2 with SMTP id zRFcYY7687511xSzDDLzP3qo; Mon, 14 Aug 2023 01:15:48 -0700 X-Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web10.103226.1692000947225513081 for ; Mon, 14 Aug 2023 01:15:47 -0700 X-Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RPRzk0NYhz4XbZ; Mon, 14 Aug 2023 08:15:46 +0000 (UTC) (envelope-from corvink@FreeBSD.org) X-Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RPRzj6nq1z4FHY; Mon, 14 Aug 2023 08:15:45 +0000 (UTC) (envelope-from corvink@FreeBSD.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692000946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZxkJEWQCEhUSlXT0oip8+hESS68MYW5IPC83ODT8WVo=; b=mpB2ZHp08g91KDebzDL5reknVwgnqiRS5jrVswIeHfJALymSKDcBxZ+YGJtmo7d/ehm8d2 mIfnIou9rGQIS04xjDdBhlPs4o2ADNtRVmEkJtOI7Eda20ya9BunvvMubds8MwFS0ljFqq KlVdag3ZwLN/A+8QcLUs5vfyBWpsXOkUGAdZ2l+AQdD41rStaRHkMbMi6WFkf7+iYz7+YQ d3PUDqiKoaJspkwd1A44aWHsCtVUTdj0Bnp4mFODwK1hDD4PUEc+JMNp4asPdk6JbFwBcP p9revcprOXXECVrsdH8wUSQ720QhTJOTNUfCdfb3BaQMWOCnsEE565UnmbndOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692000946; a=rsa-sha256; cv=none; b=GYwrgePYzDrDuWczs1m4uf7MjIIO3GvkiB34EotEQBxL5lE7miMRMtNT+yxqWUOnqoZMYk Rg60zjetz8lTwQhSC4ajafnkeiLszAQH0G1NB9E8YQdw8NPLxSOjowc3e2zjHlNqMNtJvi NBZChnqK0VlzqJxL0sbS4Jsy0awu3T1OPUpmL/dLy8TT6uOVEroXqDN3znESkKt1GH28aV T8sCChOsh5E7vR8HLaIitbqq3s6Eyn4aD2Mlo+Zspv6FLVKGVKTJodCtllIvZasH/9AP7u tn0HbH1/fnr39Gu9XkY6XZZsiOm/K08H1zNXP+th9mqeVoEzKTDln7fLPPMH1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Received: from [172.21.179.63] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RPRzh577Mz1HF0; Mon, 14 Aug 2023 08:15:44 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: <35b68f61774b96e6b68e72c6ca056a10d2601087.camel@FreeBSD.org> Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: devel@edk2.groups.io, mikuback@linux.microsoft.com, ardb@kernel.org, Rebecca Cran , Michael Kinney Cc: Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan Date: Mon, 14 Aug 2023 10:15:42 +0200 In-Reply-To: <47a7e3eb-2049-bbc3-3e74-0c115f00702e@linux.microsoft.com> References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> <47a7e3eb-2049-bbc3-3e74-0c115f00702e@linux.microsoft.com> User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,corvink@FreeBSD.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: K1UKgGGUnaVnKjAUPNJjjssyx7686176AA= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-wTp6/yI05mwM1+EUqCea" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wYkeGHwH; arc=reject ("signature check failed: fail, {[1] = sig:freebsd.org:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --=-wTp6/yI05mwM1+EUqCea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote: > I'm not sure why test results are not being reported that may be a=20 > larger issue. >=20 > I pulled the branch locally, run uncrustify, and it automatically > fixed=20 > the code to pass. >=20 > The issue is the following function call: >=20 > =C2=A0=C2=A0 BuildPlatformInfoHob(); >=20 > Should be: >=20 > =C2=A0=C2=A0 BuildPlatformInfoHob (); >=20 I already run uncrustify locally but it doesn't complain about it. Thank you! Should I resend an updated patch? Can this change make it into edk-stable202308? Otherwise, fwcfg won't be usable by bhyve in this version. --=20 Kind regards, Corvin -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107728): https://edk2.groups.io/g/devel/message/107728 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --=-wTp6/yI05mwM1+EUqCea Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmTZ4q4ACgkQ2FTaVjFe Amoblg//YQ3Lf1MHwQCNYFVQAdlgY89PXEW1K+Xe46eEB/fYGGNSL8KnihCFEljk Ft4gNT7HUIhkQt6rY/gyPYG767QP0j3q+D65iARGMUE9tsJEGiKBWl/PXscOai+C wbbxurT+0RRX1JL1rCNjFgYFmrMC9yuu+zo+g7g/ijDZDoxLfV2WfHyF9SVqpxdd tKJgeb/LMDh7b94z2S1fpM6NVmV1vI1kRMoj851z+0TBjK7PWYvy224Zz0IgZNWL gHcrhVsYXI6/E9i+5eiEr7y13vGTFrH9RwgNAq+Tw0yoJ3xtRNNVXv9u5kcM184N 7ghhg++E1VnJ8Kgw+mc7pQ2OsOHDzzrqeuPsColA6wqrUAOnDPEGsI5C0k9v7E53 ZzfRAk0jLyNj4LAVKKyHqoEHlHqB1yQwWVyaI7zRi70zSnFZiQnpiBmpL8EaeBat Ktq5+ruCEHfcsgqr16EWfIx4rSwFN55qbeRupM+h0UgdGYy3qHMvA+JkYaRQVo6X epEm+m6EoTHcXdO97Csftaa8nf4j78Z0WNJncV+lgYrSs8so5KXXgjzn6RF1pEGG ns3DefB3TQMZIFY2pd5HA1oJ5YrcCvG7/DPQll/aDKKXZ1DN4R9+SHe199gh1F8j Wu+XvqARgsZmh/pzc9C9UGnblQdPFt/f7T6Wlqz0vg76Dc2MZ9k= =689J -----END PGP SIGNATURE----- --=-wTp6/yI05mwM1+EUqCea--