From: "Rebecca Cran" <rebecca@bsdio.com>
To: Sami Mujawar <sami.mujawar@arm.com>,
devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Thomas Abraham <thomas.abraham@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM addr
Date: Sat, 19 Mar 2022 13:56:04 -0600 [thread overview]
Message-ID: <35babcfe-4b20-a23d-9187-244761562343@bsdio.com> (raw)
In-Reply-To: <27a3e61f-c708-5710-f4d7-7475d73b0e20@arm.com>
On 3/17/22 03:54, Sami Mujawar wrote:
>> // The physical base address for the PCI segment
>> - FixedPcdGet64 (PcdPciConfigurationSpaceBaseAddress),
>> + FixedPcdGet64 (gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress),
> [SAMI] I think this should just be FixedPcdGet64
> (PcdPciExpressBaseAddress).
Oops, yes. I've fixed it in v2.
--
Rebecca Cran
next prev parent reply other threads:[~2022-03-19 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 4:19 [PATCH edk2-platforms 0/3] JunoPkg: Fix AcpiSsdtRootPci.asl to use spaces and reserve ECAM area Rebecca Cran
2022-03-05 4:19 ` [PATCH edk2-platforms 1/3] Platform/ARM/JunoPkg: Convert AcpiSsdtRootPci.asl from tabs to spaces Rebecca Cran
2022-03-16 15:40 ` Sami Mujawar
2022-03-05 4:19 ` [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM addr Rebecca Cran
2022-03-17 9:54 ` Sami Mujawar
2022-03-19 19:56 ` Rebecca Cran [this message]
2022-03-05 4:19 ` [PATCH edk2-platforms 3/3] Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device Rebecca Cran
2022-03-17 9:55 ` Sami Mujawar
2022-03-19 19:56 ` Rebecca Cran
2022-03-15 2:44 ` [PATCH edk2-platforms 0/3] JunoPkg: Fix AcpiSsdtRootPci.asl to use spaces and reserve ECAM area Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35babcfe-4b20-a23d-9187-244761562343@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox