From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web09.11172.1647719767348055199 for ; Sat, 19 Mar 2022 12:56:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=fm2 header.b=cktMGjzl; spf=pass (domain: bsdio.com, ip: 66.111.4.25, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9D33B5C015C; Sat, 19 Mar 2022 15:56:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 19 Mar 2022 15:56:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=ne95fzLbGda5lZ gPy9iOqXO435A+9H2GVD0ahNl8PZ0=; b=cktMGjzlBt/JlnTM5XGl8PFikEeWW1 AbF59HLuYRfP4WLJEWxFVi22VfDOrQONZiUdAF+kh3qa1K2VMYIsHeZbbhtzhrzj VuYS0gvijfR+uRlnNlpAHMJiUXUj9Fjc31uyKGEJyvk0a1/P2eANXgZStfqEl09Y Yciua+I8gO0bXcs8Ru67VKW8kIUiDXhQgdQ5wvG6+HzifPjfJ1pgGRPuJfZ/0H44 xSHwOO3R9tT2UxIsDDdsoxAZ299I3Pc7/NS1tl8nNP2KQu6YTWboq7uvQ5i18yx5 M6VTeCHqfNYcnghy34Q4ZERA0FCiGgsuoP8IAUindAQheWkTG+JPL3NQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=ne95fzLbGda5lZgPy9iOqXO435A+9H2GVD0ahNl8PZ0=; b=aXmcaZYl pDFdZCbpP8j619UIy8O4Y8h89hzOHlt0qGMFr4lPYjoE4MdPfkvmjwj1apnSW64D hSLTnmosE28Ot/+tTglyOrm5j7093SVMuX3yRp6fVw1GRA/OSX9RBO7uI1VIb40R xV3U0lQhS7T4W9AZhbaSdeJ3wO1Z4wV50x1ZwYzbThdvZYk45a88BEwQJgEjcyhN Db94r9Z0IywNQZ/S8qTFRmPrKrh47ZHbeZ0r07Ho15jal0yemnehvWznUxxxcoU+ A6Y1B78EnE+sn8uhgIUXZbaySsis9X/FGjFTl3N38Lk1kYclxGV0U2vl31T9h/OW zLr3Joc5cDev8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefkedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeuheffgeefleeuudefffefjeeiueeggedvfefghfeuteehueehgeeifedt udefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Mar 2022 15:56:05 -0400 (EDT) Message-ID: <35babcfe-4b20-a23d-9187-244761562343@bsdio.com> Date: Sat, 19 Mar 2022 13:56:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM addr To: Sami Mujawar , devel@edk2.groups.io, Ard Biesheuvel , Thomas Abraham , nd References: <20220305041955.20918-1-rebecca@bsdio.com> <20220305041955.20918-3-rebecca@bsdio.com> <27a3e61f-c708-5710-f4d7-7475d73b0e20@arm.com> From: "Rebecca Cran" In-Reply-To: <27a3e61f-c708-5710-f4d7-7475d73b0e20@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/17/22 03:54, Sami Mujawar wrote: >>       // The physical base address for the PCI segment >> -    FixedPcdGet64 (PcdPciConfigurationSpaceBaseAddress), >> +    FixedPcdGet64 (gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress), > [SAMI] I think this should just be FixedPcdGet64 > (PcdPciExpressBaseAddress). Oops, yes. I've fixed it in v2. -- Rebecca Cran