From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.88]) by mx.groups.io with SMTP id smtpd.web08.13329.1633369677480622122 for ; Mon, 04 Oct 2021 10:47:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=cUZ28u0N; spf=pass (domain: arm.com, ip: 40.107.8.88, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=foCthLvSy8qjCkLfMeWG054xu/ICWuHCdBgNaSf7hZE=; b=cUZ28u0NtE1A9OBOIh/yd/a1019SVl8lOB9l+tXgeBTOSV/WgeIiw6eeGlKCGE0qCBl+uejO3l1pbEVVcdaIPn/PfI2Q8jGLYJ3AySSP8TJi4//BjG/LuvzgpfL0ZCuttgxQVCmQfkXOFpzfV3tDL1ZRR1/OBS0mIgY8kr7b9ss= Received: from AM6P191CA0103.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::44) by AM4PR0802MB2178.eurprd08.prod.outlook.com (2603:10a6:200:5a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Mon, 4 Oct 2021 17:47:53 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::5c) by AM6P191CA0103.outlook.office365.com (2603:10a6:209:8a::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Mon, 4 Oct 2021 17:47:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 17:47:53 +0000 Received: ("Tessian outbound 45760a30af4a:v103"); Mon, 04 Oct 2021 17:47:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 07dd7e1162c45301 X-CR-MTA-TID: 64aa7808 Received: from d830fd11f7bf.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 685D7D16-CF8C-48C7-8345-668F2BCD51FE.1; Mon, 04 Oct 2021 17:47:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d830fd11f7bf.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Oct 2021 17:47:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k2gtHrlFveRjxQIpUfyaJ5QYHqVq4UGaNuJGRpPdszUTBVOZJJe4sVQaS1/O4F4BfBVToqYKQktmsKDwoAGFB4KyWrgXRx8soABWl1vFXuoi4UygC6DcPUdaZQn3Qy0lrYdu7QcdjpLO4Zk1pJupWUlzk0+gx5/fPPsF4HDJlONW3fKQo2izqyiaw1EWUP8DCCnNhgXgIILAPTgFzqBIpf4ZxDfFagAea4v9z/gn8Rgvn/YsFhWNa1QQY5diK8I5QlKiy4LdI+/+afrX9h7jZGvh3ONS3sCMWnf5IUjvFp2cerxdzHlodcF5XKFJHPqKAYy7pL5sGhLTTCMxp6KgQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=foCthLvSy8qjCkLfMeWG054xu/ICWuHCdBgNaSf7hZE=; b=AU7VGMkDUXhmttcm1zLI6GfTC/6CAxrF+bMEWeEJx0iB3HHeBUjcED11wOGRyYuUKBBZ1gGqseeNkPre1J9Ju4F4f0/FXdgmUJgM/r4ZXYgHJo8L/NtiiOh4x3aDUjzAs6epUU0FUc/8n3IN/p3jWCB8hAA4oKEkVebJ883eEieQGk9PgwYRGLvJrJZKYF393SmSqldfwTMW5YtnsgfzO4UmuoCfMKdyfI1SS/0pOlIJiAhqhaegs/Cd5bYJIqKqhoASyNMQnN+0U03yOCsd617Vqw5FsZNQ1N8gI3AibT+FCLx+KVUuiNZbGOVCPuowt9BIDdWnB1BhVSrOb9/JZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=foCthLvSy8qjCkLfMeWG054xu/ICWuHCdBgNaSf7hZE=; b=cUZ28u0NtE1A9OBOIh/yd/a1019SVl8lOB9l+tXgeBTOSV/WgeIiw6eeGlKCGE0qCBl+uejO3l1pbEVVcdaIPn/PfI2Q8jGLYJ3AySSP8TJi4//BjG/LuvzgpfL0ZCuttgxQVCmQfkXOFpzfV3tDL1ZRR1/OBS0mIgY8kr7b9ss= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1715.eurprd08.prod.outlook.com (2603:10a6:203:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 4 Oct 2021 17:47:40 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 17:47:39 +0000 Subject: Re: [edk2-platforms][PATCH v3 5/5] ArmPlatformPkg: Add Readme file To: Omkar Anand Kulkarni , devel@edk2.groups.io Cc: Ard Biesheuvel , nd References: <20210824053403.24103-1-omkar.kulkarni@arm.com> <20210824053403.24103-6-omkar.kulkarni@arm.com> From: "Sami Mujawar" Message-ID: <3608158a-b2ad-28c4-5401-57b3012fbe91@arm.com> Date: Mon, 4 Oct 2021 18:47:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210824053403.24103-6-omkar.kulkarni@arm.com> X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 17:47:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 648628e3-0f67-4f88-36f2-08d9875f1738 X-MS-TrafficTypeDiagnostic: AM5PR0801MB1715:|AM4PR0802MB2178: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jSrxcNVZY5uoeD5ImcpSXjBXay3GHpXAMaCkQlUJ6r5PZ+GUnC1yvvBNF/43307Wpwg5z9taskDWTk7uyFNbH49FQa6D/Wy1RdUd3oI/8ND9okA0u4ribEZ3Ig4Cafmv5a4IcBkcVYxrRD40ylsU998BipSfvSK9ZrFT+y5pAuOhs2UKCqklrr3m6UNY4sxd9YzPFHgpdTT/dp9rl/ZSuiu1qiGk21OXiHwXRHgzDMDaw1l7alZHbqwnLjiuUjvAcfgLY4cQIF3A/n/k6LwYOH48eXhOmEuhywX0OOpvo+ShCxNGFIkXm0qyAgTrEZA9/MaN1EVhS5oPZHat4aZVPzIBlUQ1nOSE9MAp1yta4FC+i8QVvwZB13m5I0Pm5L916fVFwoLYvf1ZmDEq5Iccd2sKUW2pJmDiwCvrKZJXs9j4/lwTrkgQu+bDM/k8xwarYVYXYCNZuQrHwjb3I4tPs5MfjHJe643MhzV8P6hro0lV9Ud/dBHhMODSBy3PnyfV3eT+ySlJlQyzu6Wb3d/tRT6ax00nJTUtCZHM82M+5BB0FbmkxxtGfH/MTl4Z8+eU1vzl7GgwxjUTrZX40ApFHkjhl4ymdOJmSa/VswDuMf7DaPev9iaso6fElZ61fI66n4mqovIEyP+YUIK2KGzJ4oYZReRITCoGPatwDzDqiuhSuacjZRgZHylKHiCD+OH6aDGyBkam7an6OxJxz7CzOxdIuFjBquHcdhm2UOkCdKbiusBrJTNjTg7NEas8s6pLfPft4nW/MvcNFmZl0YURrrFgbdIVmEQRHI6daKaFoDtTteApnLR3xVEjvlctFhx1HJXIUxS700q0BgWvIGx84EC8yrhwN6YN82+GFWqUYGo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(86362001)(508600001)(316002)(31696002)(54906003)(66556008)(66476007)(38350700002)(38100700002)(16576012)(2616005)(31686004)(956004)(5660300002)(8936002)(8676002)(4326008)(6666004)(53546011)(66946007)(52116002)(186003)(26005)(2906002)(44832011)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1715 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a8a7bd50-921e-46e5-e90c-08d9875f0f4c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sS2wA0XrZG8u5OYem96lDMwRa28gwtB9BLHoDbPQwIUGeQHN6GvjkIhwbTR1+DfbmJDpN0byTKiGD8GyYzg8bLjWWdaaRDcHh6B0MSiporRbYRz84Q0RcDbWKDLzRVJ3CcC9pUxXgeEEo8T5RMUiUuAwHIPH74O9aSAbBUku1GjWKbkWasm4i276F+2iFoctywac745orUoRgPALhIfrtGReu+Vycp9WEM+IxVjntGvijUBE7n0pipBl7mc1EY9+olC8Xkij5eYpOyyopmOggZETSK0hsC764kMgIvBU/c5ZT08s9ML7Dy6NMk1UGKeiKE5GcwPOGXXayEnEAznZ03xbJ1pUgzSWCS9zQ4WHEyUWQH3dQ7nYVlI83YNYPj9qK655F7a6U0HDboGT1fEmWaSYdP903U6Clz1Z+mtbLH8fGl3D8zYfRpapNNiOkzc0YTaEGnw/GbE7C0FRs0fKM70mmONTO1WApffDR11y19ecB1zzrrreQcjxlq36qLRkFkXmTYPzKJ15sXLdYnUnZAEs6woKVRRnzLXvTPdCiCewHmVCyLD7uJMIgypp4KZy305YIHDdQksTDraREcCvRLLvt6H9tEd2hV4UXP11vcDKgR4d1WtdarmYDdCCcG5nI2pquOcjn41lGlebdqPOce6ZIOn+SuFCYT17QgDkg5Vool09kkzG787bjsxpfeP5/jpA4LajQ/euyEWiRWIT46Gj88PXD05C4K5hNbEU5Pgl84eWS4U2tDQfn2fB5gwQPkXhHumbNseNtEC/UE+C92/1+OWQfqTf8/xLfBShXmnWi7m0wkR/DeCIimQuoFgm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(47076005)(4326008)(6486002)(356005)(5660300002)(336012)(36860700001)(8936002)(956004)(2616005)(2906002)(31686004)(86362001)(54906003)(70206006)(26005)(53546011)(36756003)(44832011)(82310400003)(16576012)(316002)(6666004)(31696002)(508600001)(8676002)(186003)(81166007)(70586007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 17:47:53.0120 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 648628e3-0f67-4f88-36f2-08d9875f1738 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2178 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Omkar, Thank you for adding this description. This is really helpful to understand the framework. I have a few minor suggestions marked inline as [SAMI]. With those changed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote: > Added a readme file that explains the software framework for dynamic > generation of HEST table. > > Signed-off-by: Omkar Anand Kulkarni > --- > ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md | 66 ++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md b/ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md > new file mode 100644 > index 000000000000..1b6f0713cb9a > --- /dev/null > +++ b/ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md > @@ -0,0 +1,66 @@ > +Hardware Error Source Table (HEST)[1] and Software Delegated Exception Interface > +(SDEI)[2] ACPI tables are used to acomplish firmware first error handling.This > +patch series introduces a framework to build and install the HEST ACPI table > +dynamically. [SAMI] I think the reference to the patch series can be dropped. > + > +The following figure illustrates the possible usage of the dyanamic > +generation of HEST ACPI table. > + > + NS | S > ++--------------------------------------+--------------------------------------+ > +| | | > +|+-------------------------------------+---------------------+ | > +|| +---------------------+--------------------+| | > +|| | | || | > +|| +-----------+ |+------------------+ | +-----------------+|| +-------------+| > +|| |HestTable | || HestErrorSource | | | HestErrorSource ||| | DMC-620 || > +|| | DXE | || DXE | | | StandaloneMM ||| |Standalone MM|| > +|| +-----------+ |+------------------+ | +-----------------+|| +-------------+| > +|| |GHESv2 | || | > +|| +---------------------+--------------------+| | > +|| +--------------------+ | | | > +|| |PlatformErrorHandler| | | | > +|| | DXE | | | | > +|| +--------------------+ | | | > +||FF FWK | | | > +|+-------------------------------------+---------------------+ | > +| | | > ++--------------------------------------+--------------------------------------+ > + | > + Figure: Dynamic Hest Table Generation. > + > +All the hardware error sources are added to HEST table as GHESv2[3] error source > +descriptors. The framework comprises of following DXE and MM drivers: > + > +- HestTableDxe: > + Builds HEST table header and allows appending error source descriptors to the > + HEST table. Also provides protocol interface to install the built HEST table. > + > +- HestErrorSourceDxe & HestErrorSourceStandaloneMM: > + These two drivers together retrieve all possible error source descriptors of > + type GHESv2 from the MM drivers implementing HEST Error Source Descriptor > + protocol. Once all the descriptors are collected HestErrorSourceDxe appends > + it to HEST table using HestTableDxe driver. > + > +- PlatformErrorHandlerDxe: > + Builds and installs SDEI ACPI table. This driver does not initialize(load) > + until HestErrorSourceDxe driver has finished appending all possible GHESv2 > + error source descriptors to the HEST table. Once that is complete using the > + HestTableDxe driver it installs the HEST table. > + > +This patch series provides reference implementation for DMC-620 Dynamic Memory > +Controller[4] that has RAS feature enabled. This is platform code > +implemented as Standalone MM driver in edk2-platforms. [SAMI] You may want to consider rewording this paragraph. > + > +References: > +[1] : ACPI 6.3, Table 18-382, Hardware Error Source Table > +[2] : SDEI Platform Design Document, revision b, 10 Appendix C, ACPI table > + definitions for SDEI > +[3] : ACPI Reference Specification 6.3, Table 18-393 GHESv2 Structure > +[4] : DMC620 Dynamic Memory Controller, revision r1p0 > +[5] : UEFI Reference Specification 2.8, Appendix N - Common Platform Error > + Record > +[6] : UEFI Reference Specification 2.8, Section N.2.5 Memory Error Section > + > +Link to github branch with the patches in this series - > +https://github.com/omkkul01/edk2/tree/ras_firmware_first_edk2 [SAMI] The link to the github branch can be dropped.