From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E59449415D2 for ; Mon, 13 Nov 2023 10:37:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WdfrxPerdR0mlXPQeiRucYTsPZX5KED9Yhx+SXpAfIw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699871877; v=1; b=q4ZNWfU38dgyCXEpExcB+wgV+z2rsC/DJK99dtyM9eY1UGmyDSAy1JfnHIdwXnmf+Ubgo/zK bHjCwBIJYUu8hxumTOuzaKr69fuMR+Z5Pr8uERBeUuWCxDSj4+JkIN+YtwigpYqboY0c5YPdk1S cR4ST9yOXdnOjEdibWjo2Wx0= X-Received: by 127.0.0.2 with SMTP id cDXzYY7687511xCViGdpe1j7; Mon, 13 Nov 2023 02:37:57 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.34145.1699871876823901731 for ; Mon, 13 Nov 2023 02:37:56 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-8N3cPmJnPy-g4fdaaqhQmQ-1; Mon, 13 Nov 2023 05:37:53 -0500 X-MC-Unique: 8N3cPmJnPy-g4fdaaqhQmQ-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F566811E88; Mon, 13 Nov 2023 10:37:53 +0000 (UTC) X-Received: from [10.39.192.220] (unknown [10.39.192.220]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FBC625C0; Mon, 13 Nov 2023 10:37:52 +0000 (UTC) Message-ID: <36161668-0db0-c746-14e4-3220e379d9ad@redhat.com> Date: Mon, 13 Nov 2023 11:37:51 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" References: <6f4604d0-c12e-f818-2de1-44e9b1f4dbc7@redhat.com> <20231109120610.55894-1-lersek@redhat.com> <20231109120610.55894-2-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xLoQPIsklOKAOWdzZTkU9kEwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=q4ZNWfU3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Chasel, On 11/10/23 02:13, Chiu, Chasel wrote: >=20 > Hi Laszlo, >=20 > I verified and encountered build failure as some files still consuming de= finitions from LegacyBiosMpTable.h, for example: > https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad= 01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/= SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22 >=20 > Any suggestion that we can reduce impact to existing platforms? thanks for testing the build! Here's my problem: this information seems to be exposed firmware-globally, ultimately. We have a UbaConfigProtocol->AddData() call, which exposes SystemBoardInfoData. SystemBoardInfoData exposes SystemBoardInfoCallback(). That one in turn exposes SystemBoardInfoTable (of type DXE_SYSTEM_BOARD_INFO). And so on and so on, and ultimately we publicly expose DEVICE_DATA_HW_LOCAL_INT. That structure type is defined in "Platform/Intel/WhitleyOpenBoardPkg/Include/PlatDevData.h", and it only has the following comment: "Platform hardwired data describing connection of interrupt sources to local APICs" So I can't tell if this structure type officially and explicitly defers to the MP Table specification, or just ad-hoc reuses the same values. In the former case, we cannot remove LegacyBiosMpTable.h from edk2 (or perhaps we need to move it over to edk2-platforms). In the latter case, we should just replace the enum constants with their integer values (or perhaps replace them with some different macros, like ACPI spec macros or similar), and then we can delete LegacyBiosMpTable.h. That is, we need to figure out where the DEVICE_DATA_HW_LOCAL_INT type definition originates from. The particular "DeviceDataHwLocalInt1" array comes from edk2-platforms commit 3584efd25110 ("WhitleyOpenBoardPkg: Add UBA Modules", 2021-07-14). The commit message is empty -- so it's a dead-end. The type definition comes from edk2-platforms commit 41bfa85f527a ("WhitleyOpenBoardPkg: Add Includes and Libraries", 2021-07-14). The commit message is similarly empty. Laszlo >=20 > Thanks, > Chasel >=20 >=20 >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Laszlo Er= sek >> Sent: Thursday, November 9, 2023 4:06 AM >> To: devel@edk2.groups.io >> Cc: Chaganty, Rangasai V ; Desimone, Nath= aniel >> L ; Chiu, Chasel >> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: >> remove references >> >> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from >> edk2, first remove the edk2-platforms references to that header file. >> >> I can't build-test this change. As far as I can tell, building the Coope= rCityRvp and >> WilsonCityRvp platforms with "build_bios.py" should build these changes; >> however, both platforms fail to build without FSP blobs. >> >> I think there's a fair chance that this patch should work nonetheless; >> introduces names prefixed with >> EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (T= he >> one exception is FEATUREBYTE2_5, which is also absent from edk2-platform= s.) >> >> Cc: Sai Chaganty >> Cc: Nate DeSimone >> Cc: Chasel Chiu >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1754 >> Signed-off-by: Laszlo Ersek >> --- >> >> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar >> dInfoDxe/SystemBoardInfoDxe.h | 1 - >> >> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform >> DeviceDataSRP10nm.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git >> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo >> ardInfoDxe/SystemBoardInfoDxe.h >> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo >> ardInfoDxe/SystemBoardInfoDxe.h >> index 32c16ff9110a..d8c209a57f75 100644 >> --- >> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo >> ardInfoDxe/SystemBoardInfoDxe.h >> +++ >> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo >> +++ ardInfoDxe/SystemBoardInfoDxe.h >> @@ -27,7 +27,6 @@ >> #include >> #include >> >> -#include >> #include >> >> #endif //_SYSTEM_BOARD_INFO_DXE_H_ >> diff --git >> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfo= r >> mDeviceDataSRP10nm.c >> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfo= r >> mDeviceDataSRP10nm.c >> index ed9f80734cd7..b69ae1736bb8 100644 >> --- >> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfo= r >> mDeviceDataSRP10nm.c >> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl >> +++ atformDeviceDataSRP10nm.c >> @@ -8,7 +8,6 @@ >> >> #include >> #include >> -#include >> >> #ifndef V_INTEL_VID >> #define V_INTEL_VID 0x8086 >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111132): https://edk2.groups.io/g/devel/message/111132 Mute This Topic: https://groups.io/mt/102483850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-