From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 421497803DB for ; Tue, 5 Dec 2023 11:49:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GQAX62K/ABFYHQGqSOHz54vSSQ6NsWSuAr/f5C0h928=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:From:Subject:To:Cc:References:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1701776968; v=1; b=m05dhzmDgmsjLqM13f3TRv0eWOiouXSA6r7UooqHWyziQO1IKGv7sT1Cu37V/PFH8/1OjwX1 cTl2PsmAef5Mza9MuGf7VpF8+SDeoGzXXwruTEbX82+Y4tJryojpEN1YPdNvpZAm/5sNs8mEe2N ZvYpql/OzWZKIDzBEJlPhHEE= X-Received: by 127.0.0.2 with SMTP id CEC2YY7687511xp81py2y8pA; Tue, 05 Dec 2023 03:49:28 -0800 X-Received: from EUR02-VI1-obe.outbound.protection.outlook.com (EUR02-VI1-obe.outbound.protection.outlook.com [40.107.241.73]) by mx.groups.io with SMTP id smtpd.web11.97505.1701776967512424427 for ; Tue, 05 Dec 2023 03:49:28 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Aqudwx18GLSVX8t0oVifZu5ytArj+f45o1k18b62MCqhwUQMSXKOVNby4/B45nGHgvjkhw18HPuhHeoT81oCwoj8kN0D5CdkAR7TSLDbbIMc6TGZWZDrlEpayqft9imJFp6UUIl9228YW9nmccMGOizB7kyQNtvaTmGlGWmZkuKsbTU2CTVQyQU5/Z2Kmv5gJIHPcuhmN16b4LGD1//IdbaVc06AefKVlD4hQmaEBLFGm7lVOU6lISVoRzVn0LOgg2w6nwfSHEqwjFV8aOR6fiw5BYG0B9SZwjwcpWa8FToQ4tcyipML8l1PzMkmTaDd2uJK56/fdHoItU4eyp7Onw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fpg3DTP2gU/PNYnCCTxLSN+mn6y6aV0lfXBTZS1vWlc=; b=kCqf7QpZcgWvDfx0TfCWTmzuFVGk2z0QytDfX38PJtS1/7JuuVx9PpqNWX5b5FHNodwBiJjuYr3M/69XMSm+gPvGbFLm6OB7jZldRoKH2T7wkboeXc93ifeBwh//2JirLnowQZMxo6jI2q76gwBnuZGlMGOJNGzAfOQ61a/JuCF2TJIezDFJjXmmRqqQPFqsYVw+VyITaUifWgJ5qFNay7MWKhRD5f7kDgvBrs3ahZpPs7aKeWOlAmKaMb4QLPOwE2aW6SIisY/Pqp5YPMMh6PxoHeSCEl/Q/5O47eM+M036CCecMFoTQAbUv3E+F1OeA8wFX9yfXhOZ72EDJ/Wc3Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AS9PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:20b:489::32) by GV1PR08MB10719.eurprd08.prod.outlook.com (2603:10a6:150:16f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32; Tue, 5 Dec 2023 11:49:20 +0000 X-Received: from AMS0EPF00000198.eurprd05.prod.outlook.com (2603:10a6:20b:489:cafe::a8) by AS9PR05CA0058.outlook.office365.com (2603:10a6:20b:489::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34 via Frontend Transport; Tue, 5 Dec 2023 11:49:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000198.mail.protection.outlook.com (10.167.16.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.20 via Frontend Transport; Tue, 5 Dec 2023 11:49:19 +0000 X-Received: ("Tessian outbound 20615a7e7970:v228"); Tue, 05 Dec 2023 11:49:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 01dcbc05422b4de0 X-CR-MTA-TID: 64aa7808 X-Received: from 97683323680c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8C6457B3-0A85-4328-84CF-DD311FBEB274.1; Tue, 05 Dec 2023 11:49:10 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 97683323680c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Dec 2023 11:49:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GeefMG2jKhprgRD3eI2WzG5VA8Jm1SdDUnSUxx/f7T70w+yRWcyPyT3Tl7fPOuqizO8f6/HPa/ay8zQdHkCif12LtD20z4eGxWXISW5OIemOwX0ChM6zwbDM4UXui8Ih2j4p1SxmY2gZgad35t81ZHt8c5am9eFKJFxHHuQQnaSuEcib5AyhM5+EqDFrCFw3LgAtFrXxJnmvEm+yLgNrrCOlOaWVwqn0onbsuk2kiWEvSAI6O7aB2AJkcveizpgzuStlzPQ7FaCDQ9tU1SFEgYHEkci4cmoMTzvh+jEQvVql+ckrwEeTfAPvKiEgPYSgYMu/EmLLnUpp0nqaLXD9ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fpg3DTP2gU/PNYnCCTxLSN+mn6y6aV0lfXBTZS1vWlc=; b=JYRh2qkIT17iZ6q5mCst7qX2kSVExnhavpJTUeLrO88hkzdAsy9FRXjhHBwbhFcvlQOoMqmE5fJ7oEIFQsN4QxKBSGHP5gVxUUZBKp2uhnBLDq8YXT2cnQMdm7xA4RXMeUaiIqWCGJKdaf9R3kXUbs4aw8R9EJ98zZRQSspeh9eN2NfS0BLzoAm+bh7vQ5BoY677u9q5FpRaGV/J9/cqdCJ62Sswo40XWKgTjivR8p/y0yL4Jwc3wwrNEzSQpfbKeVS3KIAdZ/cwsveXgLYGe98+H+2j7T7htaef+o8hdUsg0mlltQIDWuB8It8BuYqa0S2gjg2REAecVwztENNDNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAVPR08MB9795.eurprd08.prod.outlook.com (2603:10a6:102:31f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 11:49:06 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 11:49:06 +0000 Message-ID: <361a216e-5a87-4262-a40f-e8d3d462312a@arm.com> Date: Tue, 5 Dec 2023 11:49:05 +0000 User-Agent: Mozilla Thunderbird From: "Sami Mujawar" Subject: Re: [edk2-devel] [PATCH v5 6/6] ShellPkg/AcpiView: Add MPAM Parser To: Rohit Mathew , devel@edk2.groups.io Cc: James Morse , Thomas Abraham , Yeo Reum Yun , Zhichao Gao , "nd@arm.com" References: <20231002171734.901621-1-Rohit.Mathew@arm.com> In-Reply-To: <20231002171734.901621-1-Rohit.Mathew@arm.com> X-ClientProxiedBy: LO2P123CA0030.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAVPR08MB9795:EE_|AMS0EPF00000198:EE_|GV1PR08MB10719:EE_ X-MS-Office365-Filtering-Correlation-Id: dab26f37-056c-4d9b-ac0a-08dbf588379e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6Qt98LKhBIelZNyarhHX2/zCkTBb/d3CBo94Ys4BBF3XSnuWiN4Qo5xBAv9Z5q4V/uC8KgqtcQRYXAsOr466bWznGwhTO5UeV72tX+4no+6QlPi61H9bLmTqZIzFoFf9nqNTxJIeMSfXoTB95gtS2GoXJAv9NRv/h+tGzYOnldI6n9Eakkl7f9GkvagjAqxFDGdU1ALGvQK5+0LHF7PrbDg1VeSB94XX5y0PxowG7lSFY+ePl5mnPCRs1DxxDTtnNN5CFjbp3C0AZoFAO8nPtqi9DVcRpRBYM05kkHluyBqcLzNqPEnype4vALRYZE3YuzB6HCQeUEANj5nLePc2IpBiK9Nu3EQ6Zlz/7t7c7qIu+NPlFO1gV1K97Y+/IWdu9SrbvNNm8JE0c4mpyre6p/fzFEnKik3G+vJOK59LgebugYQ5eUd0M1Lw2cPZro64NKB/h7ebadE78l3Ar04hWLNlN+IKEKz17JCK/SGPf/jT/FRO6ujQ1cLAgenqLC/bCzm8V/cXZ9zP2kdCNLfd9XgQFDPEg8+cwaO7NSjc4acnNzVbeY2tM0MZMTWndNEd+ouxWxiQNObaiHPAmpF0g/4rSGesVqBEvAsfMK44vPJsfN4LcGazpsp7jubEldH8RQLhb60ot3MbgrpqCBVlNpSt8VhcCzNIH87JkkAXs1s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(396003)(136003)(366004)(39860400002)(230173577357003)(230922051799003)(230273577357003)(451199024)(64100799003)(1800799012)(186009)(6512007)(26005)(45954011)(38100700002)(83380400001)(31686004)(6506007)(33964004)(2616005)(166002)(53546011)(6486002)(478600001)(66946007)(66556008)(66476007)(54906003)(316002)(8676002)(8936002)(4326008)(2906002)(41300700001)(36756003)(44832011)(86362001)(31696002)(30864003)(5660300002)(45980500001)(43740500002)(559001)(579004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9795 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000198.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a4a3eb83-b0ac-462b-05fa-08dbf5882f4a X-Microsoft-Antispam-Message-Info: LHgT3rq02VzRFdnJ/PF6bbdIe0+f5bkjqrh7uC3X98eKns72pLT7nsmeINMaN3+MZXaB2LjLjgitjdNn0XYGI03pr5vfHIjYA1bktQ/TdEM4nqwsPHLNFOPpegxnBig15lGA2hOH0bD8+dZbwZHKkQ1WPemG5jJgkH/aV8e+sVQWYVKnQEDqM15giXUPYcXdpHFmiuUTRjEmALeC5TJbOFAlN6Z24DGci5CnL86G/ryl3B5R6Xn9mqi7TTMbfHDiJIOABNR49MzrRJTVRZFoERBmMT62pjzKSQ9fXZncUp0xCuIAqY6HLqTCSe0rwWJvsjogmfLCV8bLwdaveZ/R/cGtjN0eUJghGS3XXPa+DvwzQSWT8ufOo9GF9E8LpT+HkmfOV0Yj/owXu/TSSjXvCt4CsU3l4rOi4nLTQxVE3VgSk9c2x++U4SHld8gGfV+sg6OzBxMOYsij26UnZUsfB+2c2C82NslgfeY2MTZCktV+T5DuJhy+m+q96aDTqggeYcjVSxXYTIWj/rzAGHVE9lR8F+A+Q5MMlazL409kH4zLDGlVOFKmFdCsTlmUrzqfLKs1QZ90oGv/vfAN/dvfdxHE64pxWjcls3ovSaDLyE+cRQ9dA+fR6kj8ubWdF3NbQzUkIYckE/kEeX8PD2JvYpPYjAjvp4yNk4+EwFuDW5m4pKvgv4c0uIVulvtxubY6XpBGz5FzgIVc6V0FhPQ950nohcAjZ3EeU7x0apVDxM8RVIL1GcDgTY/nH6Du6J024blaSavailFSEOcx6ykWchuvYLoCIgAHeuqYtZdrnH0= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 11:49:19.9935 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dab26f37-056c-4d9b-ac0a-08dbf588379e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000198.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10719 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eYMqalf0mkgXSLVyE3FrMIZyx7686176AA= Content-Type: multipart/alternative; boundary="------------myVYqqhtcDcDG8NZmn9gVqfP" Content-Language: en-GB X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=m05dhzmD; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------myVYqqhtcDcDG8NZmn9gVqfP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Rohit, Thank you for this patch. Please see my feedback inline marked [SAMI]. Regards, Sami Mujawar On 02/10/2023 06:17 pm, Rohit Mathew wrote: > Add a parser for the MPAM (Memory system resource partitioning and > monitoring) ACPI table. This parser would parse all MPAM related > structures embedded as part of the ACPI table. Necessary validations are > also performed where and when required. > > Signed-off-by: Rohit Mathew > Cc: James Morse > Cc: Sami Mujawar > Cc: Thomas Abraham > Cc: Yeo Reum Yun > Cc: Zhichao Gao > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 21 + > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c | 1276 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 3 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 3 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 3 +- > 5 files changed, 1303 insertions(+), 3 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > index 89930fdc6d..4d2764065d 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > @@ -879,6 +879,27 @@ ParseAcpiMcfg ( > IN UINT8 AcpiTableRevision > ); > > +/** > + This function parses the ACPI MPAM table. > + When trace is enabled this function parses the MPAM table and > + traces the ACPI table fields. > + > + This function also performs validation of the ACPI table fields. > + > + @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in] AcpiTableRevision Revision of the ACPI table. > +**/ > +VOID > +EFIAPI > +ParseAcpiMpam ( > + IN BOOLEAN Trace, > + IN UINT8 *Ptr, > + IN UINT32 AcpiTableLength, > + IN UINT8 AcpiTableRevision > + ); > + > /** > This function parses the ACPI PCCT table including its sub-structures > of type 0 through 4. > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c > new file mode 100644 > index 0000000000..2d94f9e5eb > --- /dev/null > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c > @@ -0,0 +1,1276 @@ > +/** @file > + MPAM table parser > + > + Copyright (c) 2023, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Specification Reference: > + - [1] ACPI for Memory System Resource Partitioning and Monitoring 2.0 > + (https://developer.arm.com/documentation/den0065/latest) > + > + @par Glossary: > + - MPAM - Memory System Resource Partitioning And Monitoring > + - MSC - Memory System Component > + - PCC - Platform Communication Channel > + - RIS - Resource Instance Selection > + - SMMU - Arm System Memory Management Unit > + **/ > + > +#include > +#include > +#include > +#include "AcpiParser.h" > +#include "AcpiView.h" > +#include "AcpiViewConfig.h" > + > +// Local variables > +STATIC CONST UINT8 *ResourceLocatorType; > +STATIC UINT32 MpamMscNodeLengthCumulative; > +STATIC UINT32 MpamMscNodeStart; > +STATIC UINT32 ResourceDataSize; [SAMI] I would prefer to remove ResourceDataSiz, see my suggestions further in the code. > +STATIC UINT32 HeaderSize; [SAMI] HeaderSize is only used in ParseAcpiMpam(). Can this be defined as a local variable, please? > +STATIC CONST UINT16 *MpamMscNodeLength; > +STATIC CONST UINT32 *MscInterfaceType; > +STATIC CONST UINT32 *NumberOfMscResources; > +STATIC CONST UINT32 *NumberOfFunctionalDependencies; > +STATIC CONST UINT32 *NumberOfInterconnectDescriptors; > +STATIC CONST UINT64 *InterconnectTableOffset; > +STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; > + > +// Array of locator type names. New types should be added keeping the order > +// preserved as locator type is used to index into the array while parsing. > +STATIC CONST CHAR16 *MpamMscLocatorTitles[] = { > + L"Processor cache", > + L"Memory", > + L"SMMU", > + L"Memory cache", > + L"ACPI device", > + L"Interconnect" > +}; > + > +/** > + When the length of the table is insufficient to be parsed, this function could > + be used to display an appropriate error message. > + > + @param [in] ErrorMsg Error message string that has to be appended to the > + main error log. This string could explain the reason > + why a insufficient length error was encountered in > + the first place. > +**/ > +STATIC > +VOID > +EFIAPI > +MpamLengthError ( > + IN CONST CHAR16 *ErrorMsg > + ) > +{ > + IncrementErrorCount (); > + Print (L"\nERROR : "); > + Print (ErrorMsg); > + Print ( > + L"\nError : Insufficient MPAM MSC Node length. Table length : %u.\n", > + *(AcpiHdrInfo.Length) > + ); [SAMI] The above statement would be printed every time this function is called. Is this correct/expected? e.g. in ValidateMmioSize() this function is called to print an error message "Interface type not set!" and it would still print the above message. I think this function name should be changed to MpamError(), and the above snippet can be removed. By the time you reach these validation the table length would already be printed. So there is not much value in printing it again. [/SAMI] > +} > + > +/** > + This function validates reserved fields. Any reserved field within the MPAM > + specification must be 0. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + particular function, context holds the size of the > + reserved field that needs to be validated. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +ValidateReserved ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length [SAMI] Based on my feedback for patch 2/6, you would need to reorder the Length parameter. > + ) > +{ > + UINT64 Reserved; > + > + Reserved = 0; > + > + // Only those cases which are handled currently have been implemented. > + switch (Length) { > + case 8: > + Reserved = (((UINT64)*(Ptr + 7)) << 56); > + // fall through > + case 7: > + Reserved |= (((UINT64)*(Ptr + 6)) << 48); > + // fall through > + case 6: > + Reserved |= (((UINT64)*(Ptr + 5)) << 40); > + // fall through > + case 5: > + Reserved |= (((UINT64)*(Ptr + 4)) << 32); > + // fall through > + case 4: > + Reserved |= (*(Ptr + 3) << 24); > + // fall through > + case 3: > + Reserved |= (*(Ptr + 2) << 16); > + // fall through > + case 2: > + Reserved |= (*(Ptr + 1) << 8); > + // fall through > + case 1: > + Reserved |= (*Ptr); > + break; > + default: > + return; > + } [SAMI] Do we need the switch case? Can we not do a something like: while (Length > 0) { if (Ptr[Length-1] != 0) { IncrementErrorCount (); Print (L"\nERROR : Reserved field must be 0\n");     break; } Length--; } > + > + if (Reserved != 0) { > + IncrementErrorCount (); > + Print (L"\nERROR : Reserved field should be 0\n"); [SAMI] I think 'should' be replaced with 'must' in the above print output, right? > + } > +} > + > +/** > + This function validates bit-length reserved fields. Any reserved field within > + the MPAM specification must be 0. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + particular function, context holds the size of the > + reserved field that needs to be validated. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +ValidateReservedBits ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT32 ByteLength; > + > + ByteLength = (Length + 7) >> 3; > + ValidateReserved (Ptr, Context, ByteLength); > +} > + > +/** > + This function validates the MMIO size within the MSC node body for MPAM ACPI > + table. MPAM ACPI specification states that the MMIO size for an MSC having PCC > + type interface should be zero. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context holds the parent/double pointer to a > + variable holding the interface type. Make sure to call > + the function accordingly. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +ValidateMmioSize ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 InterfaceType; > + UINT8 **InterfaceTypeParentPtr; > + UINT32 MmioSize; > + > + InterfaceTypeParentPtr = (UINT8 **)Context; [SAMI] I think you do not need to use Context here. Based on how the parser works, it would have already parsed the"Interface type"field of the MSC node by the time you reach here, and therefore the value would be already stored in MscInterfaceType. This means you can use MscInterfaceType directly in this function. [/SAMI] > + > + if (*InterfaceTypeParentPtr == NULL) { > + MpamLengthError (L"Interface type not set!"); [SAMI] I think if you use MscInterfaceType directly you will never have this condition. > + return; > + } > + > + InterfaceType = **InterfaceTypeParentPtr; > + > + if (InterfaceType == EFI_ACPI_MPAM_INTERFACE_PCC) { > + MmioSize = *((UINT32 *)Ptr); > + > + if (MmioSize != 0) { > + IncrementErrorCount (); > + Print ( > + L"\nERROR: MMIO size should be 0 for PCC interface type. Size - %u\n", > + MmioSize > + ); > + } > + } > +} > + > +/** > + This function decodes and validates the link type for MPAM's interconnect > + descriptor. Valid links are of NUMA and PROC type. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context is ignored. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeLinkType ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 LinkType; > + > + LinkType = *Ptr; > + > + if (LinkType == EFI_ACPI_MPAM_LINK_TYPE_NUMA) { > + Print ( > + L" (NUMA)" > + ); > + } else if (LinkType == EFI_ACPI_MPAM_LINK_TYPE_PROC) { > + Print ( > + L" (PROC)" > + ); > + } else { > + IncrementErrorCount (); > + Print ( > + L"\nERROR: Invalid link type - %u\n", > + (UINT32)LinkType > + ); > + } > +} > + > +/** > + This function decodes the hardware ID field present within MPAM ACPI table. > + The specification states that the hardware ID has to be set to zero if not > + being used. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context is ignored. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeHardwareId ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT64 HardwareId; > + > + HardwareId = *((UINT64 *)Ptr); > + > + if (HardwareId != 0) { > + Print (L" ("); > + Dump8Chars (NULL, Ptr, Length); > + Print (L")"); > + } > +} > + > +/** > + This function decodes and validates the interface type for MPAM. Valid > + interfaces are of MMIO and PCC type. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context is ignored. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeInterfaceType ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 InterfaceType; > + > + InterfaceType = *Ptr; > + > + if (InterfaceType == EFI_ACPI_MPAM_INTERFACE_MMIO) { > + Print (L" (MMIO)"); > + } else if (InterfaceType == EFI_ACPI_MPAM_INTERFACE_PCC) { > + Print (L" (PCC)"); > + } else { > + IncrementErrorCount (); > + Print ( > + L"\nERROR: Invalid interface type - %u\n", > + (UINT32)InterfaceType > + ); > + } > +} > + > +/** > + This function decodes the interrupt mode flag for MPAM. Interrupt mode could > + either be "edge triggered" or "level triggered". > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context holds the parent/double pointer to a > + variable holding the interrupt gsiv. Make sure to call > + the function accordingly. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeInterruptMode ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 InterruptMode; > + > + InterruptMode = *Ptr; > + > + if (InterruptMode == EFI_ACPI_MPAM_INTERRUPT_LEVEL_TRIGGERED) { > + Print (L" (Level triggered)"); > + } else { > + Print (L" (Edge triggered)"); > + } > +} > + > +/** > + This function decodes the interrupt type flag for MPAM. Interrupt type could > + be "wired interrupt". Other values are reserved at this point. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context holds the parent/double pointer to a > + variable holding the interrupt gsiv. Make sure to call > + the function accordingly. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeInterruptType ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 InterruptType; > + > + InterruptType = *Ptr; > + > + if (InterruptType == EFI_ACPI_MPAM_INTERRUPT_WIRED) { > + Print (L" (Wired interrupt)"); > + } else { > + IncrementWarningCount (); > + Print (L" (Reserved value!)"); > + } > +} > + > +/** > + This function decodes the interrupt affinity valid flag for MPAM. Interrupt > + affinity could be either be valid or not. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context holds the parent/double pointer to a > + variable holding the interrupt gsiv. Make sure to call > + the function accordingly. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeInterruptAffinityValid ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 InterruptAffinityValid; > + > + InterruptAffinityValid = *Ptr; > + > + if (InterruptAffinityValid != EFI_ACPI_MPAM_INTERRUPT_AFFINITY_VALID) { > + Print (L" (Affinity not valid)"); > + } else { > + Print (L" (Affinity valid)"); > + } > +} > + > +/** > + This function decodes the interrupt affinity type flag for MPAM. Interrupt > + affinity type could either be "Processor affinity" or "Processor container > + affinity" > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context holds the parent/double pointer to a > + variable holding the interrupt gsiv. Make sure to call > + the function accordingly. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeInterruptAffinityType ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 InterruptAffinityType; > + > + InterruptAffinityType = *Ptr; > + > + if (InterruptAffinityType == EFI_ACPI_MPAM_INTERRUPT_PROCESSOR_AFFINITY) { > + Print (L" (Processor affinity)"); > + } else { > + Print (L" (Processor container affinity)"); > + } > +} > + > +/** > + This function decodes the locator type for a particular MPAM MSC resource. > + > + @param [in] Ptr Pointer to the start of the field data. > + @param [in] Context Pointer to context specific information. For this > + function, context holds the parent/double pointer to a > + variable holding the interrupt gsiv. Make sure to call > + the function accordingly. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DecodeLocatorType ( > + IN UINT8 *Ptr, > + IN VOID *Context, > + IN UINT32 Length > + ) > +{ > + UINT8 LocatorType; > + > + LocatorType = *Ptr; > + > + if (LocatorType <= EFI_ACPI_MPAM_LOCATION_INTERCONNECT) { > + Print (L" (%s)", MpamMscLocatorTitles[LocatorType]); > + } else if (LocatorType == EFI_ACPI_MPAM_LOCATION_UNKNOWN) { > + Print (L" (Unknown)"); > + } else { > + Print (L" (Reserved)"); > + } > +} > + > +/** > + ACPI_PARSER array describing MPAM MSC interrupt flags. > +**/ > +STATIC CONST ACPI_PARSER MpamMscInterruptFlagParser[] = { > + { L"Interrupt Mode", 1, 0, L"%u", NULL, NULL, > + DecodeInterruptMode, NULL }, > + { L"Interrupt Type", 2, 1, L"%u", NULL, NULL, > + DecodeInterruptType, NULL }, > + { L"Affinity Type", 1, 3, L"%u", NULL, NULL, > + DecodeInterruptAffinityType, NULL }, > + { L"Affinity Valid", 1, 4, L"%u", NULL, NULL, > + DecodeInterruptAffinityValid, NULL }, > + { L"Reserved", 27, 5, NULL, DumpReservedBits, NULL, > + ValidateReservedBits, NULL } > +}; > + > +/** > + This function traces MPAM MSC Interrupt Flags. > + If no format string is specified the Format must be NULL. > + > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +DumpMpamMscInterruptFlags ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr, > + IN UINT32 Length > + ) > +{ > + Print (L"%u\n", *(UINT32 *)Ptr); > + > + ParseAcpiBitFields ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 4, > + PARSER_PARAMS (MpamMscInterruptFlagParser) > + ); > +} > + > +/** > + ACPI_PARSER array describing the MPAM MSC processor cache locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscProcessorCacheLocatorParser[] = { > + { L"Cache reference", 8, 0, L"%lu", NULL, NULL, NULL, NULL }, > + { L"Reserved", 4, 8, NULL, DumpReserved, NULL, > + ValidateReserved, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC memory locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscMemoryLocatorParser[] = { > + { L"Proximity domain", 8, 0, L"%lu", NULL, NULL, NULL, NULL }, > + { L"Reserved", 4, 8, NULL, DumpReserved, NULL, > + ValidateReserved, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC SMMU locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscSMMULocatorParser[] = { > + { L"SMMU interface", 8, 0, L"%lu", NULL, NULL, NULL, NULL }, > + { L"Reserved", 4, 8, NULL, DumpReserved, NULL, > + ValidateReserved, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC memory cache locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscMemoryCacheLocatorParser[] = { > + { L"Reserved", 7, 0, NULL, DumpReserved, NULL, > + ValidateReserved, NULL }, > + { L"Level", 1, 7, L"%u", NULL, NULL,NULL, NULL }, > + { L"Reference", 4, 8, L"%u", NULL, NULL,NULL, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC ACPI device locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscAcpiDeviceLocatorParser[] = { > + { L"ACPI hardware ID", 8, 0, L"0x%lx", NULL, NULL, > + DecodeHardwareId, NULL }, > + { L"ACPI unique ID", 4, 8, L"%u", NULL, NULL,NULL,NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC interconnect locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscInterconnectLocatorParser[] = { > + { L"Interconnect desc tbl offset", 8, 0, L"%lu", NULL, > + (VOID **)&InterconnectTableOffset, NULL, NULL }, > + { L"Reserved", 4, 8, NULL, DumpReserved, > + NULL, ValidateReserved, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC generic resource locator field. > +**/ > +STATIC CONST ACPI_PARSER MpamMscGenericLocatorParser[] = { > + { L"Descriptor1", 8, 0, L"%lu", NULL, NULL, NULL, NULL }, > + { L"Descriptor2", 4, 8, L"%u", NULL, NULL, NULL, NULL } > +}; > + > +/** > + This function parses the locator field within the resource node for ACPI MPAM > + table. The parsing is based on the locator type field. > + > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] Length Length of the field. > +**/ > +STATIC > +VOID > +EFIAPI > +ParseLocator ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr, > + IN UINT32 Length > + ) > +{ > + Print (L"\n"); > + switch (*ResourceLocatorType) { > + case EFI_ACPI_MPAM_LOCATION_PROCESSOR_CACHE: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscProcessorCacheLocatorParser) > + ); > + break; > + case EFI_ACPI_MPAM_LOCATION_MEMORY: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscMemoryLocatorParser) > + ); > + break; > + case EFI_ACPI_MPAM_LOCATION_SMMU: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscSMMULocatorParser) > + ); > + break; > + case EFI_ACPI_MPAM_LOCATION_MEMORY_CACHE: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscMemoryCacheLocatorParser) > + ); > + break; > + case EFI_ACPI_MPAM_LOCATION_ACPI_DEVICE: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscAcpiDeviceLocatorParser) > + ); > + break; > + case EFI_ACPI_MPAM_LOCATION_INTERCONNECT: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscInterconnectLocatorParser) > + ); > + break; > + // For both UNKNOWN and RESERVED locator types, the locator is parsed using > + // the generic locator parser as the spec does not define any format. > + case EFI_ACPI_MPAM_LOCATION_UNKNOWN: > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscGenericLocatorParser) > + ); > + break; > + default: > + Print (L"\nWARNING : Reserved locator type\n"); > + ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr, > + 12, > + PARSER_PARAMS (MpamMscGenericLocatorParser) > + ); > + IncrementWarningCount (); > + break; > + } // switch > +} > + > +/** > + ACPI_PARSER array describing the Generic ACPI MPAM table header. > +**/ > +STATIC CONST ACPI_PARSER MpamParser[] = { > + PARSE_ACPI_HEADER (&AcpiHdrInfo) > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC node object. > +**/ > +STATIC CONST ACPI_PARSER MpamMscNodeParser[] = { > + { L"Length", 2, 0, L"%u", NULL, > + (VOID **)&MpamMscNodeLength, NULL, NULL }, > + // Once Interface type is decoded, the address of interface type field is > + // captured into InterfaceType pointer so that it could be used to check if > + // MMIO Size field is set as per the specification. > + { L"Interface type", 1, 2, L"0x%x", NULL, > + (VOID **)&MscInterfaceType, DecodeInterfaceType, NULL }, > + { L"Reserved", 1, 3, NULL, DumpReserved, > + NULL, ValidateReserved, NULL }, > + { L"Identifier", 4, 4, L"%u", NULL, > + NULL, NULL, NULL }, > + { L"Base address", 8, 8, L"0x%lx", NULL, > + NULL, NULL, NULL }, > + { L"MMIO Size", 4, 16, L"0x%x", NULL, > + NULL, ValidateMmioSize, (VOID **)&MscInterfaceType }, > + { L"Overflow interrupt", 4, 20, L"%u", NULL, > + NULL, NULL, NULL }, > + { L"Overflow interrupt flags", 4, 24, NULL, DumpMpamMscInterruptFlags, > + NULL, NULL, NULL }, > + { L"Reserved1", 4, 28, NULL, DumpReserved, > + NULL, ValidateReserved, NULL }, > + { L"Overflow interrupt affinity", 4, 32, L"0x%x", NULL, > + NULL, NULL, NULL }, > + { L"Error interrupt", 4, 36, L"%u", NULL, > + NULL, NULL, NULL }, > + { L"Error interrupt flags", 4, 40, NULL, DumpMpamMscInterruptFlags, > + NULL, NULL, NULL }, > + { L"Reserved2", 4, 44, NULL, DumpReserved, > + NULL, ValidateReserved, NULL }, > + { L"Error interrupt affinity", 4, 48, L"0x%x", NULL, > + NULL, NULL, NULL }, > + { L"MAX_NRDY_USEC", 4, 52, L"0x%x", NULL, > + NULL, NULL, NULL }, > + { L"Hardware ID of linked device", 8, 56, L"0x%lx", NULL, > + NULL, DecodeHardwareId, NULL }, > + { L"Instance ID of linked device", 4, 64, L"0x%x", NULL, > + NULL, NULL, NULL }, > + { L"Number of resource nodes", 4, 68, L"%u", NULL, > + (VOID **)&NumberOfMscResources, NULL, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC resource. > +**/ > +STATIC CONST ACPI_PARSER MpamMscResourceParser[] = { > + { L"Identifier", 4, 0, L"%u", NULL, > + NULL, NULL, NULL }, > + { L"RIS index", 1, 4, L"%u", NULL, > + NULL, NULL, NULL }, > + { L"Reserved1", 2, 5, NULL, DumpReserved, > + NULL, ValidateReserved, NULL }, > + { L"Locator type", 1, 7, L"0x%x", NULL, > + (VOID **)&ResourceLocatorType, > + DecodeLocatorType, NULL }, > + { L"Locator", 12, 8, NULL, ParseLocator, > + NULL, NULL, NULL }, > + { L"Number of func dependencies", 4, 20, L"%u", NULL, > + (VOID **)&NumberOfFunctionalDependencies, NULL, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the MPAM MSC resource's functional dependencies. > +**/ > +STATIC CONST ACPI_PARSER MpamMscFunctionalDependencyParser[] = { > + { L"Producer", 4, 0, L"0x%x", NULL, NULL, NULL, NULL }, > + { L"Reserved", 4, 4, NULL, DumpReserved, > + NULL, ValidateReserved, NULL }, > +}; > + > +/** > + ACPI_PARSER array describing the interconnect descriptor table associated with > + the interconnect locator type. > +**/ > +STATIC CONST ACPI_PARSER MpamInterconnectDescriptorTableParser[] = { > + { L"Signature", 16, 0, > + L"%x%x%x%x-%x%x-%x%x-%x%x-%x%x%x%x%x%x", Dump16Chars, NULL, NULL, NULL }, > + { L"Number of Interconnect desc", 4, 16,L"0x%x", NULL, > + (VOID **)&NumberOfInterconnectDescriptors, NULL, NULL } > +}; > + > +/** > + ACPI_PARSER array describing the interconnect descriptor associated with the > + interconnect locator type. > +**/ > +STATIC CONST ACPI_PARSER MpamInterconnectDescriptorParser[] = { > + { L"Source ID", 4, 0, L"%u", NULL, NULL, NULL, NULL }, > + { L"Destination ID", 4, 4, L"%u", NULL, NULL, NULL, NULL }, > + { L"Link type", 1, 8, L"0x%x", NULL, > + NULL, DecodeLinkType, NULL }, > + { L"Reserved", 3, 9, NULL, DumpReserved, NULL, > + ValidateReserved, NULL } > +}; > + > +/** > + PrintBlockTitle could be used to print the title of blocks that > + appear more than once in the MPAM ACPI table. > + > + @param [in] Indent Number of spaces to add to the global table > + indent. The global table indent is 0 by > + default; however this value is updated on > + entry to the ParseAcpi() by adding the indent > + value provided to ParseAcpi() and restored > + back on exit. Therefore the total indent in > + the output is dependent on from where this > + function is called. > + @param [in] Title Title string to be used for the block. > + @param [in] Index Index of the block. > +**/ > +STATIC > +VOID > +EFIAPI > +PrintBlockTitle ( > + IN UINT32 Indent, > + IN CONST CHAR16 *Title, > + IN CONST UINT32 Index > + ) > +{ > + Print (L"\n"); > + PrintFieldName (Indent, Title); > + Print (L"%u\n\n", Index); > +} > + > +/** > + This function parses the interconnect descriptor(s) associated with > + an interconnect type locator object. > + > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in, out] Offset Pointer to current offset within Ptr. > + > +Returns: > + > + Status > + > + EFI_SUCCESS MPAM MSC nodes were parsed properly. > + EFI_BAD_BUFFER_SIZE The buffer pointer provided as input is not > + long enough to be parsed correctly. > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +ParseInterconnectDescriptors ( > + IN UINT8 *CONST Ptr, > + IN CONST UINT32 AcpiTableLength, > + IN OUT UINT32 *CONST Offset > + ) > +{ > + UINT32 InterconnectDescriptorIndex; > + > + InterconnectDescriptorIndex = 0; > + > + if (NumberOfInterconnectDescriptors == NULL) { > + MpamLengthError (L"Number of interconnect descriptors not set!"); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + while (InterconnectDescriptorIndex < *NumberOfInterconnectDescriptors) { > + PrintBlockTitle ( > + 6, > + L"* Interconnect descriptor *", > + InterconnectDescriptorIndex > + ); > + > + // Parse interconnect descriptor > + *Offset += ParseAcpi ( > + TRUE, > + 4, > + NULL, > + Ptr + *Offset, > + AcpiTableLength - *Offset, > + PARSER_PARAMS (MpamInterconnectDescriptorParser) > + ); > + > + InterconnectDescriptorIndex++; > + } > + > + return EFI_SUCCESS; > +} > + > +/** > + This function parses the interconnect descriptor table associated with an > + interconnect type locator object. It also performs necessary validation to > + make sure the interconnect descriptor is at a valid location. > + > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in] Offset Pointer to current offset within Ptr. > + @param [in] InterconnectOffset Offset to the interconnect descriptor table. > + > +Returns: > + > + Status > + > + EFI_SUCCESS MPAM MSC nodes were parsed properly. > + EFI_BAD_BUFFER_SIZE The buffer pointer provided as input is not > + long enough to be parsed correctly. > + EFI_INVALID_PARAMETER The Offset parameter encoded within the Ptr > + buffer is not valid. > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +ParseInterconnectDescriptorTable ( > + IN UINT8 *CONST Ptr, > + IN CONST UINT32 AcpiTableLength, > + IN UINT32 Offset, > + IN CONST UINT64 InterconnectOffset > + ) > +{ > + EFI_STATUS Status; > + > + if (Offset > (MpamMscNodeStart + InterconnectOffset)) { > + IncrementErrorCount (); > + Print (L"\nERROR : Parsing Interconnect descriptor table failed!\n"); > + Print ( > + L"ERROR : Offset overlaps with other objects within the MSC. Offset %u.\n", > + InterconnectOffset > + ); > + > + return EFI_INVALID_PARAMETER; > + } > + > + if (InterconnectOffset > (*MpamMscNodeLength)) { > + IncrementErrorCount (); > + Print (L"\nERROR : Parsing Interconnect descriptor table failed!\n"); > + Print ( > + L"ERROR : Offset falls outside MSC's space. Offset %u.\n", > + InterconnectOffset > + ); > + > + return EFI_INVALID_PARAMETER; > + } > + > + // It is safe to cast InterconnectOffset to UINT32 as IntercconnectOffset can > + // never exceed the MPAM table length which is at max 2 bytes. > + Offset = MpamMscNodeStart + (UINT32)InterconnectOffset; > + > + Print (L"\n"); > + PrintFieldName (6, L"* Interconnect desc table *"); > + Print (L"\n\n"); > + > + // Parse interconnect descriptor table > + Offset += ParseAcpi ( > + TRUE, > + 4, > + NULL, > + Ptr + Offset, > + AcpiTableLength - Offset, > + PARSER_PARAMS (MpamInterconnectDescriptorTableParser) > + ); > + > + Status = ParseInterconnectDescriptors ( > + Ptr, > + AcpiTableLength, > + &Offset > + ); > + > + ResourceDataSize += Offset - (MpamMscNodeStart + (UINT32)InterconnectOffset); > + return Status; > +} > + > +/** > + This function parses all the MPAM functional dependency nodes within a > + single resource node. > + > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in, out] Offset Pointer to current offset within Ptr. > + > +Returns: > + > + Status > + > + EFI_SUCCESS MPAM MSC nodes were parsed properly. > + EFI_BAD_BUFFER_SIZE The buffer pointer provided as input is not > + long enough to be parsed correctly. > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +ParseMpamMscFunctionalDependencies ( > + IN UINT8 *CONST Ptr, > + IN CONST UINT32 AcpiTableLength, > + IN OUT UINT32 *CONST Offset > + ) > +{ > + UINT32 FunctionalDependencyIndex; > + > + FunctionalDependencyIndex = 0; > + > + if (NumberOfFunctionalDependencies == NULL) { > + MpamLengthError (L"Number of functional dependencies not set!"); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + while (FunctionalDependencyIndex < *NumberOfFunctionalDependencies) { > + PrintBlockTitle ( > + 6, > + L"* Functional dependency *", > + FunctionalDependencyIndex > + ); > + > + // Parse functional dependency > + *Offset += ParseAcpi ( > + TRUE, > + 4, > + NULL, > + Ptr + *Offset, > + AcpiTableLength - *Offset, > + PARSER_PARAMS (MpamMscFunctionalDependencyParser) > + ); > + > + FunctionalDependencyIndex++; > + } > + > + return EFI_SUCCESS; > +} > + > +/** > + This function parses all the MPAM resource nodes within a single MSC > + node within the MPAM ACPI table. It also invokes helper functions to > + validate and parse locators and functional dependency descriptors. > + > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in, out] Offset Pointer to current offset within Ptr. > + > +Returns: > + > + Status > + > + EFI_SUCCESS MPAM MSC nodes were parsed properly. > + EFI_BAD_BUFFER_SIZE The buffer pointer provided as input is not > + long enough to be parsed correctly. > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +ParseMpamMscResources ( > + IN UINT8 *CONST Ptr, > + IN CONST UINT32 AcpiTableLength, > + IN OUT UINT32 *CONST Offset > + ) > +{ > + EFI_STATUS Status; > + UINT32 ResourceIndex; > + > + ResourceIndex = 0; [SAMI] I think ResourceDataSize should be a local variable in this function and initialised to zero here. > + > + if (NumberOfMscResources == NULL) { > + MpamLengthError (L"Number of MSC resource not set!"); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + while (ResourceIndex < *NumberOfMscResources) { > + PrintBlockTitle ( > + 4, > + L"* Resource *", > + ResourceIndex > + ); > + > + // Parse MPAM MSC resources within the MSC body. > + *Offset += ParseAcpi ( > + TRUE, > + 2, > + NULL, > + Ptr + *Offset, > + AcpiTableLength - *Offset, > + PARSER_PARAMS (MpamMscResourceParser) > + ); > + > + Status = ParseMpamMscFunctionalDependencies (Ptr, AcpiTableLength, Offset); > + if (Status != EFI_SUCCESS) { > + return Status; > + } > + > + // If the InterconnectTableOffset field has been set, proceed to parse the > + // interconnect descriptor table. Please note that the interconnect > + // descriptors are placed within the MSC node body in the resource specific > + // region. However since its easier to map an interconnect descriptor to > + // its corresponding resource, proceed to parse it along with its parent > + // resource. This design choice is made to keep the trace view as intuitive > + // as possible. > + // > + // +---------------------+ > + // | MPAM ACPI Header | > + // +---------------------+------- > + // | MSC Node 0 Hdr | ^ > + // | +-----------------+ | | > + // | | Res Node 0 | | | > + // | | +-------------+ | | | > + // | | | Res Node Hdr| | | | > + // | | +-------------+ | | | > + // | | | Res Data | | | | > + // | | | | | | | > + // | | | +---------+ | | | | +---------------------------+ > + // | | | | Locator | | | | ..|...| Interconnect locator desc | [SAMI] Minor. Is it possible to delete 1 dot of the 3 above so that the 'Interconnect locator desc' block can be shifted left by 1 character. That would make the entire ascii diagram fit within 80 characters width. [/SAMI] > + // | | | | | | | | | | Descriptor Table Offset |--points-to->+ > + // | | | | | | | | | | Reserved [4] | | > + // | | | +---------+ | | | | +---------------------------+ | > + // | | | |FnDep Cnt| | | | | | > + // | | | +---------+ | | | | | > + // | | | |FnDep 1 | | | | | | > + // | | | +---------+ | | | Interconnect | > + // | | | |FnDep 2 | | | | descriptor | > + // | | | +---------+ | | | table | > + // | | | |FnDep n | | | | offset | > + // | | | +---------+ | | | value | > + // | | +-------------+ | | | | > + // | +-----------------+ | | | > + // | ... | | | > + // | +-----------------+ | | | > + // | | Res Node N | | | | > + // | | +-------------+ | | | | > + // | | | Res Node Hdr| | | | | > + // | | +-------------+ | | | | > + // | | | Res Data | | | | | > + // | | | | | | | | > + // | | | +---------+ | | | | | > + // | | | | Locator | | | | | | > + // | | | | | | | | | | > + // | | | | | | | | | | > + // | | | +---------+ | | | | | > + // | | | |FnDep Cnt| | | | | | > + // | | | +---------+ | | | | | > + // | | | |FnDep 1 | | | | | | > + // | | | +---------+ | | | | | > + // | | | |FnDep 2 | | | | | | > + // | | | +---------+ | | | | | > + // | | | |FnDep n | | | | | | > + // | | | +---------+ | | | | | > + // | | +-------------+ | | | | > + // | +-----------------+ | | | > + // \ Resource-specific / v | > + // / data region. \<------------------------------------------------+ > + // \ / > + // +---------------------+ > + // | MSC Node 1 Hdr | > + // | ... | > + // +---------------------+ > + if ( (*ResourceLocatorType == EFI_ACPI_MPAM_LOCATION_INTERCONNECT) > + && (InterconnectTableOffset != NULL)) > + { > + Status = ParseInterconnectDescriptorTable ( > + Ptr, > + AcpiTableLength, > + *Offset, > + *InterconnectTableOffset [SAMI] ParseInterconnectDescriptorTable() should return the sizeof the interconnect descriptor it has parsed, which should be used to update ResourceDataSize. > + ); > + if (Status != EFI_SUCCESS) { > + return Status; > + } > + } > + > + ResourceIndex++; > + } [SAMI] At the end of this function we would have parsed all the Resource Nodes, including the Resource specific data region. Therefore, the Offset should be updated to reflect the data parsed, i.e. Offser += ResourceDataSize can be done here. [/SAMI] > + > + return EFI_SUCCESS; > +} > + > +/** > + This function parses all the MPAM MSC nodes within the MPAM ACPI table. It > + also invokes a helper function to detect and parse resource nodes that maybe > + present. > + > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in] Offset Current offset within Ptr. > + > +Returns: > + > + Status > + > + EFI_SUCCESS MPAM MSC nodes were parsed properly. > + EFI_BAD_BUFFER_SIZE The buffer pointer provided as input is not > + long enough to be parsed correctly. > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +ParseMpamMscNodes ( > + IN UINT8 *CONST Ptr, > + IN CONST UINT32 AcpiTableLength, > + IN UINT32 Offset > + ) > +{ > + EFI_STATUS Status; > + UINT32 MscIndex; > + > + MscIndex = 0; > + > + while (Offset < AcpiTableLength) { > + MpamMscNodeStart = Offset; > + ResourceDataSize = 0; > + > + PrintBlockTitle (2, L"* MSC *", MscIndex); > + // Parse MPAM MSC node > + Offset += ParseAcpi ( > + TRUE, > + 0, > + NULL, > + Ptr + Offset, > + AcpiTableLength - Offset, > + PARSER_PARAMS (MpamMscNodeParser) > + ); > + > + if (MpamMscNodeLength == NULL) { > + MpamLengthError (L"MPAM MSC node length not set!"); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + if (*MpamMscNodeLength < sizeof (EFI_ACPI_MPAM_MSC_NODE)) { > + IncrementErrorCount (); > + Print (L"\nERROR: MSC length should be at least the size of node body! "); > + Print (L"MSC Length %u\n", *MpamMscNodeLength); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + // Parse MPAM MSC resources within the MSC body > + Status = ParseMpamMscResources (Ptr, AcpiTableLength, &Offset); > + if (Status != EFI_SUCCESS) { > + return Status; > + } > + > + Offset += ResourceDataSize; [SAMI] The out parameter Offset in ParseMpamMscResources() reflects number of bytes it has parsed/processed. Therefore, ResourceDataSize should be added in ParseMpamMscResources() and the updated offset should be returned. Also, have you considered the case where ResourceData has padding? Would it be better to use ResourceDataSize only for checking the bounds and instead use the MSC Node length to move the offset forward? [/SAMI] > + MpamMscNodeLengthCumulative += (*MpamMscNodeLength); > + MscIndex++; > + } > + > + return EFI_SUCCESS; > +} > + > +/** > + This function parses the MPAM ACPI table's generic header. It also invokes a > + sub routine that would help with parsing rest of the table. > + > + @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] AcpiTableLength Length of the ACPI table. > + @param [in] AcpiTableRevision Revision of the ACPI table. > +**/ > +VOID > +EFIAPI > +ParseAcpiMpam ( > + IN BOOLEAN Trace, > + IN UINT8 *Ptr, > + IN UINT32 AcpiTableLength, > + IN UINT8 AcpiTableRevision > + ) > +{ > + EFI_STATUS Status; > + > + if (!Trace) { > + return; > + } > + > + // Parse generic table header > + HeaderSize = ParseAcpi ( > + TRUE, > + 0, > + "MPAM", > + Ptr, > + AcpiTableLength, > + PARSER_PARAMS (MpamParser) > + ); > + > + Status = ParseMpamMscNodes (Ptr, AcpiTableLength, HeaderSize); [SAMI] Would it be possible to pass MpamMscNodeLengthCumulative as an out parameter to ParseMpamMscNodes()? That way it could be made a local variable. > + if (Status == EFI_SUCCESS) { > + // Check if the length of all MPAM MSCs with the header, matches with the > + // ACPI table's length field. > + if (*(AcpiHdrInfo.Length) != (MpamMscNodeLengthCumulative + HeaderSize)) { > + IncrementErrorCount (); > + Print (L"\nERROR: Length mismatch! : "); > + Print (L"MSC Length total != MPAM table length."); > + Print ( > + L"Table length : %u MSC total : %u\n", > + *(AcpiHdrInfo.Length), > + MpamMscNodeLengthCumulative > + ); > + } > + } > +} > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c > index bbac125bb9..3887174361 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c > @@ -2,7 +2,7 @@ > Main file for 'acpiview' Shell command function. > > Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved. > - Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
> + Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > > @@ -63,6 +63,7 @@ ACPI_TABLE_PARSER ParserList[] = { > { EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiMadt }, > { EFI_ACPI_6_2_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE, > ParseAcpiMcfg }, > + { EFI_ACPI_MEMORY_SYSTEM_RESOURCE_PARTITIONING_AND_MONITORING_TABLE_SIGNATURE, ParseAcpiMpam }, > { EFI_ACPI_6_4_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE, > ParseAcpiPcct }, > { EFI_ACPI_6_4_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE, > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf > index a38965a4bf..56b30552bf 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf > @@ -2,7 +2,7 @@ > # Provides Shell 'acpiview' command functions > # > # Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved. > -# Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
> +# Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -42,6 +42,7 @@ > Parsers/Madt/MadtParser.c > Parsers/Madt/MadtParser.h > Parsers/Mcfg/McfgParser.c > + Parsers/Mpam/MpamParser.c > Parsers/Pcct/PcctParser.c > Parsers/Pcct/PcctParser.h > Parsers/Pptt/PpttParser.c > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni > index e4a9dd5b40..4079a8e51e 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni > @@ -1,6 +1,6 @@ > // /** > // > -// Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
> +// Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.
> // SPDX-License-Identifier: BSD-2-Clause-Patent > // > // Module Name: > @@ -89,6 +89,7 @@ > " HMAT - Heterogeneous Memory Attributes Table\r\n" > " IORT - IO Remapping Table\r\n" > " MCFG - Memory Mapped Config Space Base Address Description Table\r\n" > +" MPAM - Memory System Resource Partitioning and Monitoring Table\r\n" > " PPTT - Processor Properties Topology Table\r\n" > " RSDP - Root System Description Pointer\r\n" > " SLIT - System Locality Information Table\r\n" -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112078): https://edk2.groups.io/g/devel/message/112078 Mute This Topic: https://groups.io/mt/101716975/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------myVYqqhtcDcDG8NZmn9gVqfP Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Rohit,

Thank you for this patch.

Please see my feedback inline marked [SAMI].

Regards,

Sami Mujawar

On 02/10/2023 06:17 pm, Rohit Mathew wrote:
Add a parser for the MPAM (Memory system resource partitioning and
monitoring) ACPI table. This parser would parse all MPAM related
structures embedded as part of the ACPI table. Necessary validations are
also performed where and when required.

Signed-off-by: Rohit Mathew <Rohit.Mathew@arm.com>
Cc: James Morse <james.Morse@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
---
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |   21 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c       | 1276 ++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   |    3 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |    3 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni |    3 +-
 5 files changed, 1303 insertions(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
index 89930fdc6d..4d2764065d 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
@@ -879,6 +879,27 @@ ParseAcpiMcfg (
   IN UINT8    AcpiTableRevision
   );
 
+/**
+  This function parses the ACPI MPAM table.
+  When trace is enabled this function parses the MPAM table and
+  traces the ACPI table fields.
+
+  This function also performs validation of the ACPI table fields.
+
+  @param [in] Trace              If TRUE, trace the ACPI fields.
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in] AcpiTableRevision  Revision of the ACPI table.
+**/
+VOID
+EFIAPI
+ParseAcpiMpam (
+  IN BOOLEAN  Trace,
+  IN UINT8    *Ptr,
+  IN UINT32   AcpiTableLength,
+  IN UINT8    AcpiTableRevision
+  );
+
 /**
   This function parses the ACPI PCCT table including its sub-structures
   of type 0 through 4.
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c
new file mode 100644
index 0000000000..2d94f9e5eb
--- /dev/null
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamParser.c
@@ -0,0 +1,1276 @@
+/** @file
+  MPAM table parser
+
+  Copyright (c) 2023, ARM Limited. All rights reserved.
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+  @par Specification Reference:
+   - [1] ACPI for Memory System Resource Partitioning and Monitoring 2.0
+     (https://developer.arm.com/documentation/den0065/latest)
+
+  @par Glossary:
+    - MPAM - Memory System Resource Partitioning And Monitoring
+    - MSC  - Memory System Component
+    - PCC  - Platform Communication Channel
+    - RIS  - Resource Instance Selection
+    - SMMU - Arm System Memory Management Unit
+ **/
+
+#include <IndustryStandard/Mpam.h>
+#include <Library/PrintLib.h>
+#include <Library/UefiLib.h>
+#include "AcpiParser.h"
+#include "AcpiView.h"
+#include "AcpiViewConfig.h"
+
+// Local variables
+STATIC CONST UINT8                   *ResourceLocatorType;
+STATIC UINT32                        MpamMscNodeLengthCumulative;
+STATIC UINT32                        MpamMscNodeStart;
+STATIC UINT32                        ResourceDataSize;
[SAMI] I would prefer to remove ResourceDataSiz, see my suggestions further in the code. 
+STATIC UINT32                        HeaderSize;
[SAMI] HeaderSize is only used in ParseAcpiMpam(). Can this be defined as a local variable, please? 
+STATIC CONST UINT16                  *MpamMscNodeLength;
+STATIC CONST UINT32                  *MscInterfaceType;
+STATIC CONST UINT32                  *NumberOfMscResources;
+STATIC CONST UINT32                  *NumberOfFunctionalDependencies;
+STATIC CONST UINT32                  *NumberOfInterconnectDescriptors;
+STATIC CONST UINT64                  *InterconnectTableOffset;
+STATIC ACPI_DESCRIPTION_HEADER_INFO  AcpiHdrInfo;
+
+// Array of locator type names. New types should be added keeping the order
+// preserved as locator type is used to index into the array while parsing.
+STATIC CONST CHAR16  *MpamMscLocatorTitles[] = {
+  L"Processor cache",
+  L"Memory",
+  L"SMMU",
+  L"Memory cache",
+  L"ACPI device",
+  L"Interconnect"
+};
+
+/**
+  When the length of the table is insufficient to be parsed, this function could
+  be used to display an appropriate error message.
+
+  @param [in] ErrorMsg      Error message string that has to be appended to the
+                            main error log. This string could explain the reason
+                            why a insufficient length error was encountered in
+                            the first place.
+**/
+STATIC
+VOID
+EFIAPI
+MpamLengthError (
+  IN CONST CHAR16  *ErrorMsg
+  )
+{
+  IncrementErrorCount ();
+  Print (L"\nERROR : ");
+  Print (ErrorMsg);
<SNIP>
+  Print (
+    L"\nError : Insufficient MPAM MSC Node length. Table length : %u.\n",
+    *(AcpiHdrInfo.Length)
+    );
</SNIP>

[SAMI] The above statement would be printed every time this function is called. Is this correct/expected?

e.g. in ValidateMmioSize() this function is called to print an error message "Interface type not set!" and it would

still print the above message.

I think this function name should be changed to MpamError(), and the above snippet can be removed.

By the time you reach these validation the table length would already be printed. So there is not much value in printing it again.

[/SAMI] 

+}
+
+/**
+  This function validates reserved fields. Any reserved field within the MPAM
+  specification must be 0.
+
+  @param [in] Ptr       Pointer to the start of the field data.
+  @param [in] Context   Pointer to context specific information. For this
+                        particular function, context holds the size of the
+                        reserved field that needs to be validated.
+  @param [in] Length    Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+ValidateReserved (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
[SAMI] Based on my feedback for patch 2/6, you would need to reorder the Length parameter.
+  )
+{
+  UINT64  Reserved;
+
+  Reserved = 0;
+
+  // Only those cases which are handled currently have been implemented.
+  switch (Length) {
+    case 8:
+      Reserved = (((UINT64)*(Ptr + 7)) << 56);
+    // fall through
+    case 7:
+      Reserved |= (((UINT64)*(Ptr + 6)) << 48);
+    // fall through
+    case 6:
+      Reserved |= (((UINT64)*(Ptr + 5)) << 40);
+    // fall through
+    case 5:
+      Reserved |= (((UINT64)*(Ptr + 4)) << 32);
+    // fall through
+    case 4:
+      Reserved |= (*(Ptr + 3) << 24);
+    // fall through
+    case 3:
+      Reserved |= (*(Ptr + 2) << 16);
+    // fall through
+    case 2:
+      Reserved |= (*(Ptr + 1) << 8);
+    // fall through
+    case 1:
+      Reserved |= (*Ptr);
+      break;
+    default:
+      return;
+  }

[SAMI] Do we need the switch case? Can we not do a something like:

while (Length > 0) {

if (Ptr[Length-1] != 0) {

    IncrementErrorCount ();

  Print (L"\nERROR : Reserved field must be 0\n");

    break;

}

Length--;

}

+
+  if (Reserved != 0) {
+    IncrementErrorCount ();
+    Print (L"\nERROR : Reserved field should be 0\n");
[SAMI] I think 'should' be replaced with 'must' in the above print output, right?
+  }
+}
+
+/**
+  This function validates bit-length reserved fields. Any reserved field within
+  the MPAM specification must be 0.
+
+  @param [in] Ptr       Pointer to the start of the field data.
+  @param [in] Context   Pointer to context specific information. For this
+                        particular function, context holds the size of the
+                        reserved field that needs to be validated.
+  @param [in] Length    Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+ValidateReservedBits (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT32  ByteLength;
+
+  ByteLength = (Length + 7) >> 3;
+  ValidateReserved (Ptr, Context, ByteLength);
+}
+
+/**
+  This function validates the MMIO size within the MSC node body for MPAM ACPI
+  table. MPAM ACPI specification states that the MMIO size for an MSC having PCC
+  type interface should be zero.
+
+  @param [in] Ptr        Pointer to the start of the field data.
+  @param [in] Context    Pointer to context specific information. For this
+                         function, context holds the parent/double pointer to a
+                         variable holding the interface type. Make sure to call
+                         the function accordingly.
+  @param [in] Length     Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+ValidateMmioSize (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8   InterfaceType;
+  UINT8   **InterfaceTypeParentPtr;
+  UINT32  MmioSize;
+
+  InterfaceTypeParentPtr = (UINT8 **)Context;

[SAMI] I think you do not need to use Context here. 

Based on how the parser works, it would have already parsed the"Interface type" field of the MSC node by the time you reach here, and therefore the value would be already stored in MscInterfaceType.

This means you can use MscInterfaceType directly in this function.

[/SAMI] 

+
+  if (*InterfaceTypeParentPtr == NULL) {
+    MpamLengthError (L"Interface type not set!");
[SAMI] I think if you use MscInterfaceType directly you will never have this condition. 
+    return;
+  }
+
+  InterfaceType = **InterfaceTypeParentPtr;
+
+  if (InterfaceType == EFI_ACPI_MPAM_INTERFACE_PCC) {
+    MmioSize = *((UINT32 *)Ptr);
+
+    if (MmioSize != 0) {
+      IncrementErrorCount ();
+      Print (
+        L"\nERROR: MMIO size should be 0 for PCC interface type. Size - %u\n",
+        MmioSize
+        );
+    }
+  }
+}
+
+/**
+  This function decodes and validates the link type for MPAM's interconnect
+  descriptor. Valid links are of NUMA and PROC type.
+
+  @param [in] Ptr         Pointer to the start of the field data.
+  @param [in] Context     Pointer to context specific information. For this
+                          function, context is ignored.
+  @param [in] Length      Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeLinkType (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  LinkType;
+
+  LinkType = *Ptr;
+
+  if (LinkType == EFI_ACPI_MPAM_LINK_TYPE_NUMA) {
+    Print (
+      L" (NUMA)"
+      );
+  } else if (LinkType == EFI_ACPI_MPAM_LINK_TYPE_PROC) {
+    Print (
+      L" (PROC)"
+      );
+  } else {
+    IncrementErrorCount ();
+    Print (
+      L"\nERROR: Invalid link type - %u\n",
+      (UINT32)LinkType
+      );
+  }
+}
+
+/**
+  This function decodes the hardware ID field present within MPAM ACPI table.
+  The specification states that the hardware ID has to be set to zero if not
+  being used.
+
+  @param [in] Ptr         Pointer to the start of the field data.
+  @param [in] Context     Pointer to context specific information. For this
+                          function, context is ignored.
+  @param [in] Length      Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeHardwareId (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT64  HardwareId;
+
+  HardwareId = *((UINT64 *)Ptr);
+
+  if (HardwareId != 0) {
+    Print (L" (");
+    Dump8Chars (NULL, Ptr, Length);
+    Print (L")");
+  }
+}
+
+/**
+  This function decodes and validates the interface type for MPAM. Valid
+  interfaces are of MMIO and PCC type.
+
+  @param [in] Ptr         Pointer to the start of the field data.
+  @param [in] Context     Pointer to context specific information. For this
+                          function, context is ignored.
+  @param [in] Length      Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeInterfaceType (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  InterfaceType;
+
+  InterfaceType = *Ptr;
+
+  if (InterfaceType == EFI_ACPI_MPAM_INTERFACE_MMIO) {
+    Print (L" (MMIO)");
+  } else if (InterfaceType == EFI_ACPI_MPAM_INTERFACE_PCC) {
+    Print (L" (PCC)");
+  } else {
+    IncrementErrorCount ();
+    Print (
+      L"\nERROR: Invalid interface type - %u\n",
+      (UINT32)InterfaceType
+      );
+  }
+}
+
+/**
+  This function decodes the interrupt mode flag for MPAM. Interrupt mode could
+  either be "edge triggered" or "level triggered".
+
+  @param [in] Ptr        Pointer to the start of the field data.
+  @param [in] Context    Pointer to context specific information. For this
+                         function, context holds the parent/double pointer to a
+                         variable holding the interrupt gsiv. Make sure to call
+                         the function accordingly.
+  @param [in] Length     Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeInterruptMode (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  InterruptMode;
+
+  InterruptMode = *Ptr;
+
+  if (InterruptMode == EFI_ACPI_MPAM_INTERRUPT_LEVEL_TRIGGERED) {
+    Print (L" (Level triggered)");
+  } else {
+    Print (L" (Edge triggered)");
+  }
+}
+
+/**
+  This function decodes the interrupt type flag for MPAM. Interrupt type could
+  be "wired interrupt". Other values are reserved at this point.
+
+  @param [in] Ptr        Pointer to the start of the field data.
+  @param [in] Context    Pointer to context specific information. For this
+                         function, context holds the parent/double pointer to a
+                         variable holding the interrupt gsiv. Make sure to call
+                         the function accordingly.
+  @param [in] Length     Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeInterruptType (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  InterruptType;
+
+  InterruptType = *Ptr;
+
+  if (InterruptType == EFI_ACPI_MPAM_INTERRUPT_WIRED) {
+    Print (L" (Wired interrupt)");
+  } else {
+    IncrementWarningCount ();
+    Print (L" (Reserved value!)");
+  }
+}
+
+/**
+  This function decodes the interrupt affinity valid flag for MPAM. Interrupt
+  affinity could be either be valid or not.
+
+  @param [in] Ptr        Pointer to the start of the field data.
+  @param [in] Context    Pointer to context specific information. For this
+                         function, context holds the parent/double pointer to a
+                         variable holding the interrupt gsiv. Make sure to call
+                         the function accordingly.
+  @param [in] Length     Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeInterruptAffinityValid (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  InterruptAffinityValid;
+
+  InterruptAffinityValid = *Ptr;
+
+  if (InterruptAffinityValid != EFI_ACPI_MPAM_INTERRUPT_AFFINITY_VALID) {
+    Print (L" (Affinity not valid)");
+  } else {
+    Print (L" (Affinity valid)");
+  }
+}
+
+/**
+  This function decodes the interrupt affinity type flag for MPAM. Interrupt
+  affinity type could either be "Processor affinity" or "Processor container
+  affinity"
+
+  @param [in] Ptr        Pointer to the start of the field data.
+  @param [in] Context    Pointer to context specific information. For this
+                         function, context holds the parent/double pointer to a
+                         variable holding the interrupt gsiv. Make sure to call
+                         the function accordingly.
+  @param [in] Length     Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeInterruptAffinityType (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  InterruptAffinityType;
+
+  InterruptAffinityType = *Ptr;
+
+  if (InterruptAffinityType == EFI_ACPI_MPAM_INTERRUPT_PROCESSOR_AFFINITY) {
+    Print (L" (Processor affinity)");
+  } else {
+    Print (L" (Processor container affinity)");
+  }
+}
+
+/**
+  This function decodes the locator type for a particular MPAM MSC resource.
+
+  @param [in] Ptr        Pointer to the start of the field data.
+  @param [in] Context    Pointer to context specific information. For this
+                         function, context holds the parent/double pointer to a
+                         variable holding the interrupt gsiv. Make sure to call
+                         the function accordingly.
+  @param [in] Length     Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DecodeLocatorType (
+  IN UINT8   *Ptr,
+  IN VOID    *Context,
+  IN UINT32  Length
+  )
+{
+  UINT8  LocatorType;
+
+  LocatorType = *Ptr;
+
+  if (LocatorType <= EFI_ACPI_MPAM_LOCATION_INTERCONNECT) {
+    Print (L" (%s)", MpamMscLocatorTitles[LocatorType]);
+  } else if (LocatorType == EFI_ACPI_MPAM_LOCATION_UNKNOWN) {
+    Print (L" (Unknown)");
+  } else {
+    Print (L" (Reserved)");
+  }
+}
+
+/**
+  ACPI_PARSER array describing MPAM MSC interrupt flags.
+**/
+STATIC CONST ACPI_PARSER  MpamMscInterruptFlagParser[] = {
+  { L"Interrupt Mode", 1,  0, L"%u", NULL,             NULL,
+    DecodeInterruptMode, NULL },
+  { L"Interrupt Type", 2,  1, L"%u", NULL,             NULL,
+    DecodeInterruptType, NULL },
+  { L"Affinity Type",  1,  3, L"%u", NULL,             NULL,
+    DecodeInterruptAffinityType, NULL },
+  { L"Affinity Valid", 1,  4, L"%u", NULL,             NULL,
+    DecodeInterruptAffinityValid, NULL },
+  { L"Reserved",       27, 5, NULL,  DumpReservedBits, NULL,
+    ValidateReservedBits, NULL }
+};
+
+/**
+  This function traces MPAM MSC Interrupt Flags.
+  If no format string is specified the Format must be NULL.
+
+  @param [in] Format  Optional format string for tracing the data.
+  @param [in] Ptr     Pointer to the start of the buffer.
+  @param [in] Length  Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+DumpMpamMscInterruptFlags (
+  IN CONST CHAR16  *Format OPTIONAL,
+  IN UINT8         *Ptr,
+  IN UINT32        Length
+  )
+{
+  Print (L"%u\n", *(UINT32 *)Ptr);
+
+  ParseAcpiBitFields (
+    TRUE,
+    2,
+    NULL,
+    Ptr,
+    4,
+    PARSER_PARAMS (MpamMscInterruptFlagParser)
+    );
+}
+
+/**
+  ACPI_PARSER array describing the MPAM MSC processor cache locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscProcessorCacheLocatorParser[] = {
+  { L"Cache reference", 8, 0, L"%lu", NULL,         NULL, NULL, NULL },
+  { L"Reserved",        4, 8, NULL,   DumpReserved, NULL,
+    ValidateReserved, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC memory locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscMemoryLocatorParser[] = {
+  { L"Proximity domain", 8, 0, L"%lu", NULL,         NULL, NULL, NULL },
+  { L"Reserved",         4, 8, NULL,   DumpReserved, NULL,
+    ValidateReserved, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC SMMU locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscSMMULocatorParser[] = {
+  { L"SMMU interface", 8, 0, L"%lu", NULL,         NULL, NULL, NULL },
+  { L"Reserved",       4, 8, NULL,   DumpReserved, NULL,
+    ValidateReserved, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC memory cache locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscMemoryCacheLocatorParser[] = {
+  { L"Reserved",  7, 0, NULL,  DumpReserved, NULL,
+    ValidateReserved, NULL },
+  { L"Level",     1, 7, L"%u", NULL,         NULL,NULL,  NULL },
+  { L"Reference", 4, 8, L"%u", NULL,         NULL,NULL,  NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC ACPI device locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscAcpiDeviceLocatorParser[] = {
+  { L"ACPI hardware ID", 8, 0, L"0x%lx", NULL, NULL,
+    DecodeHardwareId, NULL },
+  { L"ACPI unique ID",   4, 8, L"%u",    NULL, NULL,NULL,NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC interconnect locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscInterconnectLocatorParser[] = {
+  { L"Interconnect desc tbl offset", 8, 0, L"%lu", NULL,
+    (VOID **)&InterconnectTableOffset, NULL, NULL },
+  { L"Reserved",                     4, 8, NULL,   DumpReserved,
+    NULL, ValidateReserved, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC generic resource locator field.
+**/
+STATIC CONST ACPI_PARSER  MpamMscGenericLocatorParser[] = {
+  { L"Descriptor1", 8, 0, L"%lu", NULL, NULL, NULL, NULL },
+  { L"Descriptor2", 4, 8, L"%u",  NULL, NULL, NULL, NULL }
+};
+
+/**
+  This function parses the locator field within the resource node for ACPI MPAM
+  table. The parsing is based on the locator type field.
+
+  @param [in] Format  Optional format string for tracing the data.
+  @param [in] Ptr     Pointer to the start of the buffer.
+  @param [in] Length  Length of the field.
+**/
+STATIC
+VOID
+EFIAPI
+ParseLocator (
+  IN CONST CHAR16  *Format OPTIONAL,
+  IN UINT8         *Ptr,
+  IN UINT32        Length
+  )
+{
+  Print (L"\n");
+  switch (*ResourceLocatorType) {
+    case EFI_ACPI_MPAM_LOCATION_PROCESSOR_CACHE:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscProcessorCacheLocatorParser)
+        );
+      break;
+    case EFI_ACPI_MPAM_LOCATION_MEMORY:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscMemoryLocatorParser)
+        );
+      break;
+    case EFI_ACPI_MPAM_LOCATION_SMMU:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscSMMULocatorParser)
+        );
+      break;
+    case EFI_ACPI_MPAM_LOCATION_MEMORY_CACHE:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscMemoryCacheLocatorParser)
+        );
+      break;
+    case EFI_ACPI_MPAM_LOCATION_ACPI_DEVICE:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscAcpiDeviceLocatorParser)
+        );
+      break;
+    case EFI_ACPI_MPAM_LOCATION_INTERCONNECT:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscInterconnectLocatorParser)
+        );
+      break;
+    // For both UNKNOWN and RESERVED locator types, the locator is parsed using
+    // the generic locator parser as the spec does not define any format.
+    case EFI_ACPI_MPAM_LOCATION_UNKNOWN:
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscGenericLocatorParser)
+        );
+      break;
+    default:
+      Print (L"\nWARNING : Reserved locator type\n");
+      ParseAcpi (
+        TRUE,
+        2,
+        NULL,
+        Ptr,
+        12,
+        PARSER_PARAMS (MpamMscGenericLocatorParser)
+        );
+      IncrementWarningCount ();
+      break;
+  } // switch
+}
+
+/**
+  ACPI_PARSER array describing the Generic ACPI MPAM table header.
+**/
+STATIC CONST ACPI_PARSER  MpamParser[] = {
+  PARSE_ACPI_HEADER (&AcpiHdrInfo)
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC node object.
+**/
+STATIC CONST ACPI_PARSER  MpamMscNodeParser[] = {
+  { L"Length",                       2, 0,  L"%u",    NULL,
+    (VOID **)&MpamMscNodeLength, NULL, NULL },
+  // Once Interface type is decoded, the address of interface type field is
+  // captured into InterfaceType pointer so that it could be used to check if
+  // MMIO Size field is set as per the specification.
+  { L"Interface type",               1, 2,  L"0x%x",  NULL,
+    (VOID **)&MscInterfaceType, DecodeInterfaceType, NULL },
+  { L"Reserved",                     1, 3,  NULL,     DumpReserved,
+    NULL, ValidateReserved, NULL },
+  { L"Identifier",                   4, 4,  L"%u",    NULL,
+    NULL, NULL, NULL },
+  { L"Base address",                 8, 8,  L"0x%lx", NULL,
+    NULL, NULL, NULL },
+  { L"MMIO Size",                    4, 16, L"0x%x",  NULL,
+    NULL, ValidateMmioSize, (VOID **)&MscInterfaceType },
+  { L"Overflow interrupt",           4, 20, L"%u",    NULL,
+    NULL, NULL, NULL },
+  { L"Overflow interrupt flags",     4, 24, NULL,     DumpMpamMscInterruptFlags,
+    NULL, NULL, NULL },
+  { L"Reserved1",                    4, 28, NULL,     DumpReserved,
+    NULL, ValidateReserved, NULL },
+  { L"Overflow interrupt affinity",  4, 32, L"0x%x",  NULL,
+    NULL, NULL, NULL },
+  { L"Error interrupt",              4, 36, L"%u",    NULL,
+    NULL, NULL, NULL },
+  { L"Error interrupt flags",        4, 40, NULL,     DumpMpamMscInterruptFlags,
+    NULL, NULL, NULL },
+  { L"Reserved2",                    4, 44, NULL,     DumpReserved,
+    NULL, ValidateReserved, NULL },
+  { L"Error interrupt affinity",     4, 48, L"0x%x",  NULL,
+    NULL, NULL, NULL },
+  { L"MAX_NRDY_USEC",                4, 52, L"0x%x",  NULL,
+    NULL, NULL, NULL },
+  { L"Hardware ID of linked device", 8, 56, L"0x%lx", NULL,
+    NULL, DecodeHardwareId, NULL },
+  { L"Instance ID of linked device", 4, 64, L"0x%x",  NULL,
+    NULL, NULL, NULL },
+  { L"Number of resource nodes",     4, 68, L"%u",    NULL,
+    (VOID **)&NumberOfMscResources, NULL, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC resource.
+**/
+STATIC CONST ACPI_PARSER  MpamMscResourceParser[] = {
+  { L"Identifier",                  4,  0,  L"%u",   NULL,
+    NULL, NULL, NULL },
+  { L"RIS index",                   1,  4,  L"%u",   NULL,
+    NULL, NULL, NULL },
+  { L"Reserved1",                   2,  5,  NULL,    DumpReserved,
+    NULL, ValidateReserved, NULL },
+  { L"Locator type",                1,  7,  L"0x%x", NULL,
+    (VOID **)&ResourceLocatorType,
+    DecodeLocatorType, NULL },
+  { L"Locator",                     12, 8,  NULL,    ParseLocator,
+    NULL, NULL, NULL },
+  { L"Number of func dependencies", 4,  20, L"%u",   NULL,
+    (VOID **)&NumberOfFunctionalDependencies, NULL, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the MPAM MSC resource's functional dependencies.
+**/
+STATIC CONST ACPI_PARSER  MpamMscFunctionalDependencyParser[] = {
+  { L"Producer", 4, 0, L"0x%x", NULL,         NULL, NULL, NULL },
+  { L"Reserved", 4, 4, NULL,    DumpReserved,
+    NULL, ValidateReserved, NULL },
+};
+
+/**
+  ACPI_PARSER array describing the interconnect descriptor table associated with
+  the interconnect locator type.
+**/
+STATIC CONST ACPI_PARSER  MpamInterconnectDescriptorTableParser[] = {
+  { L"Signature",                   16, 0,
+    L"%x%x%x%x-%x%x-%x%x-%x%x-%x%x%x%x%x%x", Dump16Chars, NULL, NULL, NULL },
+  { L"Number of Interconnect desc", 4,  16,L"0x%x", NULL,
+    (VOID **)&NumberOfInterconnectDescriptors, NULL, NULL }
+};
+
+/**
+  ACPI_PARSER array describing the interconnect descriptor associated with the
+  interconnect locator type.
+**/
+STATIC CONST ACPI_PARSER  MpamInterconnectDescriptorParser[] = {
+  { L"Source ID",      4, 0, L"%u",   NULL,         NULL, NULL, NULL },
+  { L"Destination ID", 4, 4, L"%u",   NULL,         NULL, NULL, NULL },
+  { L"Link type",      1, 8, L"0x%x", NULL,
+    NULL, DecodeLinkType, NULL },
+  { L"Reserved",       3, 9, NULL,    DumpReserved, NULL,
+    ValidateReserved, NULL }
+};
+
+/**
+  PrintBlockTitle could be used to print the title of blocks that
+  appear more than once in the MPAM ACPI table.
+
+  @param [in] Indent              Number of spaces to add to the global table
+                                  indent. The global table indent is 0 by
+                                  default; however this value is updated on
+                                  entry to the ParseAcpi() by adding the indent
+                                  value provided to ParseAcpi() and restored
+                                  back on exit.  Therefore the total indent in
+                                  the output is dependent on from where this
+                                  function is called.
+  @param [in] Title               Title string to be used for the block.
+  @param [in] Index               Index of the block.
+**/
+STATIC
+VOID
+EFIAPI
+PrintBlockTitle (
+  IN UINT32        Indent,
+  IN CONST CHAR16  *Title,
+  IN CONST UINT32  Index
+  )
+{
+  Print (L"\n");
+  PrintFieldName (Indent, Title);
+  Print (L"%u\n\n", Index);
+}
+
+/**
+  This function parses the interconnect descriptor(s) associated with
+  an interconnect type locator object.
+
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in, out] Offset             Pointer to current offset within Ptr.
+
+Returns:
+
+  Status
+
+  EFI_SUCCESS                    MPAM MSC nodes were parsed properly.
+  EFI_BAD_BUFFER_SIZE            The buffer pointer provided as input is not
+                                 long enough to be parsed correctly.
+**/
+STATIC
+EFI_STATUS
+EFIAPI
+ParseInterconnectDescriptors (
+  IN UINT8   *CONST     Ptr,
+  IN CONST UINT32       AcpiTableLength,
+  IN OUT UINT32 *CONST  Offset
+  )
+{
+  UINT32  InterconnectDescriptorIndex;
+
+  InterconnectDescriptorIndex = 0;
+
+  if (NumberOfInterconnectDescriptors == NULL) {
+    MpamLengthError (L"Number of interconnect descriptors not set!");
+    return EFI_BAD_BUFFER_SIZE;
+  }
+
+  while (InterconnectDescriptorIndex < *NumberOfInterconnectDescriptors) {
+    PrintBlockTitle (
+      6,
+      L"* Interconnect descriptor *",
+      InterconnectDescriptorIndex
+      );
+
+    // Parse interconnect descriptor
+    *Offset += ParseAcpi (
+                 TRUE,
+                 4,
+                 NULL,
+                 Ptr + *Offset,
+                 AcpiTableLength - *Offset,
+                 PARSER_PARAMS (MpamInterconnectDescriptorParser)
+                 );
+
+    InterconnectDescriptorIndex++;
+  }
+
+  return EFI_SUCCESS;
+}
+
+/**
+  This function parses the interconnect descriptor table associated with an
+  interconnect type locator object. It also performs necessary validation to
+  make sure the interconnect descriptor is at a valid location.
+
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in] Offset             Pointer to current offset within Ptr.
+  @param [in] InterconnectOffset Offset to the interconnect descriptor table.
+
+Returns:
+
+  Status
+
+  EFI_SUCCESS                    MPAM MSC nodes were parsed properly.
+  EFI_BAD_BUFFER_SIZE            The buffer pointer provided as input is not
+                                 long enough to be parsed correctly.
+  EFI_INVALID_PARAMETER          The Offset parameter encoded within the Ptr
+                                 buffer is not valid.
+**/
+STATIC
+EFI_STATUS
+EFIAPI
+ParseInterconnectDescriptorTable (
+  IN UINT8   *CONST  Ptr,
+  IN CONST UINT32    AcpiTableLength,
+  IN UINT32          Offset,
+  IN CONST UINT64    InterconnectOffset
+  )
+{
+  EFI_STATUS  Status;
+
+  if (Offset > (MpamMscNodeStart + InterconnectOffset)) {
+    IncrementErrorCount ();
+    Print (L"\nERROR : Parsing Interconnect descriptor table failed!\n");
+    Print (
+      L"ERROR : Offset overlaps with other objects within the MSC. Offset %u.\n",
+      InterconnectOffset
+      );
+
+    return EFI_INVALID_PARAMETER;
+  }
+
+  if (InterconnectOffset > (*MpamMscNodeLength)) {
+    IncrementErrorCount ();
+    Print (L"\nERROR : Parsing Interconnect descriptor table failed!\n");
+    Print (
+      L"ERROR : Offset falls outside MSC's space. Offset %u.\n",
+      InterconnectOffset
+      );
+
+    return EFI_INVALID_PARAMETER;
+  }
+
+  // It is safe to cast InterconnectOffset to UINT32 as IntercconnectOffset can
+  // never exceed the MPAM table length which is at max 2 bytes.
+  Offset = MpamMscNodeStart + (UINT32)InterconnectOffset;
+
+  Print (L"\n");
+  PrintFieldName (6, L"* Interconnect desc table *");
+  Print (L"\n\n");
+
+  // Parse interconnect descriptor table
+  Offset += ParseAcpi (
+              TRUE,
+              4,
+              NULL,
+              Ptr + Offset,
+              AcpiTableLength - Offset,
+              PARSER_PARAMS (MpamInterconnectDescriptorTableParser)
+              );
+
+  Status = ParseInterconnectDescriptors (
+             Ptr,
+             AcpiTableLength,
+             &Offset
+             );
+
+  ResourceDataSize += Offset - (MpamMscNodeStart + (UINT32)InterconnectOffset);
+  return Status;
+}
+
+/**
+  This function parses all the MPAM functional dependency nodes within a
+  single resource node.
+
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in, out] Offset             Pointer to current offset within Ptr.
+
+Returns:
+
+  Status
+
+  EFI_SUCCESS                    MPAM MSC nodes were parsed properly.
+  EFI_BAD_BUFFER_SIZE            The buffer pointer provided as input is not
+                                 long enough to be parsed correctly.
+**/
+STATIC
+EFI_STATUS
+EFIAPI
+ParseMpamMscFunctionalDependencies (
+  IN UINT8   *CONST      Ptr,
+  IN CONST UINT32        AcpiTableLength,
+  IN OUT UINT32  *CONST  Offset
+  )
+{
+  UINT32  FunctionalDependencyIndex;
+
+  FunctionalDependencyIndex = 0;
+
+  if (NumberOfFunctionalDependencies == NULL) {
+    MpamLengthError (L"Number of functional dependencies not set!");
+    return EFI_BAD_BUFFER_SIZE;
+  }
+
+  while (FunctionalDependencyIndex < *NumberOfFunctionalDependencies) {
+    PrintBlockTitle (
+      6,
+      L"* Functional dependency *",
+      FunctionalDependencyIndex
+      );
+
+    // Parse functional dependency
+    *Offset += ParseAcpi (
+                 TRUE,
+                 4,
+                 NULL,
+                 Ptr + *Offset,
+                 AcpiTableLength - *Offset,
+                 PARSER_PARAMS (MpamMscFunctionalDependencyParser)
+                 );
+
+    FunctionalDependencyIndex++;
+  }
+
+  return EFI_SUCCESS;
+}
+
+/**
+  This function parses all the MPAM resource nodes within a single MSC
+  node within the MPAM ACPI table.  It also invokes helper functions to
+  validate and parse locators and functional dependency descriptors.
+
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in, out] Offset             Pointer to current offset within Ptr.
+
+Returns:
+
+  Status
+
+  EFI_SUCCESS                    MPAM MSC nodes were parsed properly.
+  EFI_BAD_BUFFER_SIZE            The buffer pointer provided as input is not
+                                 long enough to be parsed correctly.
+**/
+STATIC
+EFI_STATUS
+EFIAPI
+ParseMpamMscResources (
+  IN UINT8   *CONST      Ptr,
+  IN CONST UINT32        AcpiTableLength,
+  IN OUT UINT32  *CONST  Offset
+  )
+{
+  EFI_STATUS  Status;
+  UINT32      ResourceIndex;
+
+  ResourceIndex = 0;
[SAMI] I think ResourceDataSize should be a local variable in this function and initialised to zero here.
+
+  if (NumberOfMscResources == NULL) {
+    MpamLengthError (L"Number of MSC resource not set!");
+    return EFI_BAD_BUFFER_SIZE;
+  }
+
+  while (ResourceIndex < *NumberOfMscResources) {
+    PrintBlockTitle (
+      4,
+      L"* Resource *",
+      ResourceIndex
+      );
+
+    // Parse MPAM MSC resources within the MSC body.
+    *Offset += ParseAcpi (
+                 TRUE,
+                 2,
+                 NULL,
+                 Ptr + *Offset,
+                 AcpiTableLength - *Offset,
+                 PARSER_PARAMS (MpamMscResourceParser)
+                 );
+
+    Status = ParseMpamMscFunctionalDependencies (Ptr, AcpiTableLength, Offset);
+    if (Status != EFI_SUCCESS) {
+      return Status;
+    }
+
+    // If the InterconnectTableOffset field has been set, proceed to parse the
+    // interconnect descriptor table. Please note that the interconnect
+    // descriptors are placed within the MSC node body in the resource specific
+    // region.  However since its easier to map an interconnect descriptor to
+    // its corresponding resource, proceed to parse it along with its parent
+    // resource. This design choice is made to keep the trace view as intuitive
+    // as possible.
+    //
+    //  +---------------------+
+    //  | MPAM ACPI Header    |
+    //  +---------------------+-------
+    //  |   MSC Node 0 Hdr    |   ^
+    //  | +-----------------+ |   |
+    //  | | Res Node 0      | |   |
+    //  | | +-------------+ | |   |
+    //  | | | Res Node Hdr| | |   |
+    //  | | +-------------+ | |   |
+    //  | | | Res Data    | | |   |
+    //  | | |             | | |   |
+    //  | | | +---------+ | | |   |   +---------------------------+
+    //  | | | | Locator | | | | ..|...| Interconnect locator desc |

[SAMI] Minor. Is it possible to delete 1 dot of the 3 above so that the 'Interconnect locator desc' block can be shifted left by 1 character. 

That would make the entire ascii diagram fit within 80 characters width.

[/SAMI]

+    //  | | | |         | | | |   |   |  Descriptor Table Offset  |--points-to->+
+    //  | | | |         | | | |   |   |  Reserved [4]             |             |
+    //  | | | +---------+ | | |   |   +---------------------------+             |
+    //  | | | |FnDep Cnt| | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | | |FnDep 1  | | | |   |                                             |
+    //  | | | +---------+ | | | Interconnect                                    |
+    //  | | | |FnDep 2  | | | |  descriptor                                     |
+    //  | | | +---------+ | | |  table                                          |
+    //  | | | |FnDep n  | | | |  offset                                         |
+    //  | | | +---------+ | | |  value                                          |
+    //  | | +-------------+ | |   |                                             |
+    //  | +-----------------+ |   |                                             |
+    //  |         ...         |   |                                             |
+    //  | +-----------------+ |   |                                             |
+    //  | | Res Node N      | |   |                                             |
+    //  | | +-------------+ | |   |                                             |
+    //  | | | Res Node Hdr| | |   |                                             |
+    //  | | +-------------+ | |   |                                             |
+    //  | | | Res Data    | | |   |                                             |
+    //  | | |             | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | | | Locator | | | |   |                                             |
+    //  | | | |         | | | |   |                                             |
+    //  | | | |         | | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | | |FnDep Cnt| | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | | |FnDep 1  | | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | | |FnDep 2  | | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | | |FnDep n  | | | |   |                                             |
+    //  | | | +---------+ | | |   |                                             |
+    //  | | +-------------+ | |   |                                             |
+    //  | +-----------------+ |   |                                             |
+    //  \  Resource-specific  /   v                                             |
+    //  /  data region.       \<------------------------------------------------+
+    //  \                     /
+    //  +---------------------+
+    //  | MSC Node 1 Hdr      |
+    //  |     ...             |
+    //  +---------------------+
+    if (  (*ResourceLocatorType == EFI_ACPI_MPAM_LOCATION_INTERCONNECT)
+       && (InterconnectTableOffset != NULL))
+    {
+      Status = ParseInterconnectDescriptorTable (
+                 Ptr,
+                 AcpiTableLength,
+                 *Offset,
+                 *InterconnectTableOffset
[SAMI] ParseInterconnectDescriptorTable() should return the sizeof the interconnect descriptor it has parsed, which should be used to update ResourceDataSize. 
+                 );
+      if (Status != EFI_SUCCESS) {
+        return Status;
+      }
+    }
+
+    ResourceIndex++;
+  }

[SAMI] At the end of this function we would have parsed all the Resource Nodes, including the Resource specific data region. 

Therefore, the Offset should be updated to reflect the data parsed, i.e. Offser += ResourceDataSize can be done here.

[/SAMI] 

+
+  return EFI_SUCCESS;
+}
+
+/**
+  This function parses all the MPAM MSC nodes within the MPAM ACPI table.  It
+  also invokes a helper function to detect and parse resource nodes that maybe
+  present.
+
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in] Offset             Current offset within Ptr.
+
+Returns:
+
+  Status
+
+  EFI_SUCCESS                    MPAM MSC nodes were parsed properly.
+  EFI_BAD_BUFFER_SIZE            The buffer pointer provided as input is not
+                                 long enough to be parsed correctly.
+**/
+STATIC
+EFI_STATUS
+EFIAPI
+ParseMpamMscNodes (
+  IN UINT8   *CONST  Ptr,
+  IN CONST UINT32    AcpiTableLength,
+  IN UINT32          Offset
+  )
+{
+  EFI_STATUS  Status;
+  UINT32      MscIndex;
+
+  MscIndex = 0;
+
+  while (Offset < AcpiTableLength) {
+    MpamMscNodeStart = Offset;
+    ResourceDataSize = 0;
+
+    PrintBlockTitle (2, L"* MSC *", MscIndex);
+    // Parse MPAM MSC node
+    Offset += ParseAcpi (
+                TRUE,
+                0,
+                NULL,
+                Ptr + Offset,
+                AcpiTableLength - Offset,
+                PARSER_PARAMS (MpamMscNodeParser)
+                );
+
+    if (MpamMscNodeLength == NULL) {
+      MpamLengthError (L"MPAM MSC node length not set!");
+      return EFI_BAD_BUFFER_SIZE;
+    }
+
+    if (*MpamMscNodeLength < sizeof (EFI_ACPI_MPAM_MSC_NODE)) {
+      IncrementErrorCount ();
+      Print (L"\nERROR: MSC length should be at least the size of node body! ");
+      Print (L"MSC Length %u\n", *MpamMscNodeLength);
+      return EFI_BAD_BUFFER_SIZE;
+    }
+
+    // Parse MPAM MSC resources within the MSC body
+    Status = ParseMpamMscResources (Ptr, AcpiTableLength, &Offset);
+    if (Status != EFI_SUCCESS) {
+      return Status;
+    }
+
+    Offset                      += ResourceDataSize;

[SAMI] The out parameter Offset in ParseMpamMscResources() reflects number of bytes it has parsed/processed. 

Therefore, ResourceDataSize should be added in ParseMpamMscResources() and the updated offset should be returned.

Also, have you considered the case where ResourceData has padding? Would it be better to use ResourceDataSize only for checking the bounds and instead use the MSC Node length to move the offset forward?

[/SAMI] 

+    MpamMscNodeLengthCumulative += (*MpamMscNodeLength);
+    MscIndex++;
+  }
+
+  return EFI_SUCCESS;
+}
+
+/**
+  This function parses the MPAM ACPI table's generic header. It also invokes a
+  sub routine that would help with parsing rest of the table.
+
+  @param [in] Trace              If TRUE, trace the ACPI fields.
+  @param [in] Ptr                Pointer to the start of the buffer.
+  @param [in] AcpiTableLength    Length of the ACPI table.
+  @param [in] AcpiTableRevision  Revision of the ACPI table.
+**/
+VOID
+EFIAPI
+ParseAcpiMpam (
+  IN BOOLEAN  Trace,
+  IN UINT8    *Ptr,
+  IN UINT32   AcpiTableLength,
+  IN UINT8    AcpiTableRevision
+  )
+{
+  EFI_STATUS  Status;
+
+  if (!Trace) {
+    return;
+  }
+
+  // Parse generic table header
+  HeaderSize = ParseAcpi (
+                 TRUE,
+                 0,
+                 "MPAM",
+                 Ptr,
+                 AcpiTableLength,
+                 PARSER_PARAMS (MpamParser)
+                 );
+
+  Status = ParseMpamMscNodes (Ptr, AcpiTableLength, HeaderSize);
[SAMI] Would it be possible to pass MpamMscNodeLengthCumulative as an out parameter to ParseMpamMscNodes()? That way it could be made a local variable. 
+  if (Status == EFI_SUCCESS) {
+    // Check if the length of all MPAM MSCs with the header, matches with the
+    // ACPI table's length field.
+    if (*(AcpiHdrInfo.Length) != (MpamMscNodeLengthCumulative + HeaderSize)) {
+      IncrementErrorCount ();
+      Print (L"\nERROR: Length mismatch! : ");
+      Print (L"MSC Length total != MPAM table length.");
+      Print (
+        L"Table length : %u MSC total : %u\n",
+        *(AcpiHdrInfo.Length),
+        MpamMscNodeLengthCumulative
+        );
+    }
+  }
+}
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
index bbac125bb9..3887174361 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
@@ -2,7 +2,7 @@
   Main file for 'acpiview' Shell command function.
 
   Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
-  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.<BR>
+  Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 **/
 
@@ -63,6 +63,7 @@ ACPI_TABLE_PARSER  ParserList[] = {
   { EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE,                                              ParseAcpiMadt },
   { EFI_ACPI_6_2_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE,
     ParseAcpiMcfg },
+  { EFI_ACPI_MEMORY_SYSTEM_RESOURCE_PARTITIONING_AND_MONITORING_TABLE_SIGNATURE,                         ParseAcpiMpam },
   { EFI_ACPI_6_4_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE,
     ParseAcpiPcct },
   { EFI_ACPI_6_4_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
index a38965a4bf..56b30552bf 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
@@ -2,7 +2,7 @@
 # Provides Shell 'acpiview' command functions
 #
 # Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
-# Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.<BR>
+# Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -42,6 +42,7 @@
   Parsers/Madt/MadtParser.c
   Parsers/Madt/MadtParser.h
   Parsers/Mcfg/McfgParser.c
+  Parsers/Mpam/MpamParser.c
   Parsers/Pcct/PcctParser.c
   Parsers/Pcct/PcctParser.h
   Parsers/Pptt/PpttParser.c
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
index e4a9dd5b40..4079a8e51e 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
@@ -1,6 +1,6 @@
 // /**
 //
-// Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.<BR>
+// Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.<BR>
 // SPDX-License-Identifier: BSD-2-Clause-Patent
 //
 // Module Name:
@@ -89,6 +89,7 @@
 "       HMAT  - Heterogeneous Memory Attributes Table\r\n"
 "       IORT  - IO Remapping Table\r\n"
 "       MCFG  - Memory Mapped Config Space Base Address Description Table\r\n"
+"       MPAM  - Memory System Resource Partitioning and Monitoring Table\r\n"
 "       PPTT  - Processor Properties Topology Table\r\n"
 "       RSDP  - Root System Description Pointer\r\n"
 "       SLIT  - System Locality Information Table\r\n"
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#112078) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------myVYqqhtcDcDG8NZmn9gVqfP--