Re: [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs

[Laszlo Ersek <lersek@redhat.com>]

On 09/19/18 11:13, Wang, Jian J wrote:
> If no more new comments, I'll do following changes in v2, including review
> comments got so far:
> 
> a. change ToEnableExecuteDisableFeature() to EnableNonExec()
> b. remove the ASSERT and DEBUG in current ToEnableExecuteDisableFeature()
> c. update dec/uni file to clarify the usage of following PCDs
>     PcdNxSetForStack
>         TRUE  - Apply NX to stack memory
>         FALSE - Don't care of protection of stack memory
>     PcdImageProtectionPolicy
>          1 - Apply NX to data section of image from the corresponding origin
>          0 - Don't care of the protection of data section of image from the corresponding origin
>     PcdDxeNxMemoryProtectionPolicy
>          1 - Apply NX to corresponding type of memory
>          0 - Don't care of the protection of corresponding type of memory

Good summary, and I think this is a workable approach as well. Defining
value 0 as "don't care" or "no-op", rather than "unset this feature",
eliminates contradictory configurations.

Thanks
Laszlo