From: "Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>
To: Rebecca Cran <rebecca@bsdio.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
devel@edk2.groups.io
Cc: patches@amperecomputing.com, ardb+tianocore@kernel.org,
Nhi Pham <nhi@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version
Date: Fri, 17 Mar 2023 21:52:20 +0700 [thread overview]
Message-ID: <3632d0c3-c946-b177-3deb-f8d851906d41@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <c8e91eb3-e9c1-0505-9a61-43cd9c66e335@bsdio.com>
Thank you for your feedback; I will submit v2 as soon as possible.
Regards,
Tinh
On 3/15/2023 12:59 AM, Rebecca Cran wrote:
> On 3/14/23 6:48 AM, Leif Lindholm wrote:
>> No objection to that.
>> But can we do it like this?:
>>
>> Change GetBiosVersion to SetBiosVersion and in MiscBiosVendor, only call
>>
>> SetBiosVersion ();
>>
>> and move the selection logic fully into SetBiosVersion?
>>
>> Rebecca, thoughts?
>> Arguably, once an OemMiscLib dependency was added, the Pcd values became
>> less useful in the core code.
>
> That sounds very reasonable.
>
>
next prev parent reply other threads:[~2023-03-17 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 6:43 [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version Tinh Nguyen
2023-03-13 15:03 ` Leif Lindholm
2023-03-13 16:52 ` Tinh Nguyen
2023-03-14 12:48 ` [edk2-devel] " Leif Lindholm
2023-03-14 17:59 ` Rebecca Cran
2023-03-17 14:52 ` Tinh Nguyen [this message]
2023-03-16 8:30 ` Tinh Nguyen
2023-03-16 13:00 ` [edk2-devel] " Rebecca Cran
2023-03-17 14:50 ` Tinh Nguyen
2023-03-17 14:50 ` Tinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3632d0c3-c946-b177-3deb-f8d851906d41@amperemail.onmicrosoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox