From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.138]) by mx.groups.io with SMTP id smtpd.web10.21616.1679064754752344043 for ; Fri, 17 Mar 2023 07:52:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=1oBBVgv+; spf=pass (domain: os.amperecomputing.com, ip: 40.107.93.138, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1uuRgwxkCNgfylBgGBT0MDAVymtZ8zzjebsM/1U9XTRutUizuCcW2rkNj+CDIJnLEaeCza2bH5mMagcVKVBSeRjW1aYAsZb2aiujTvJp8RfKVXt33r077rxTLqyTPGbs7//H9aSId9dT9cAcby+HeJqzwzc1yOsTItoTw6J3iO64UFcqg/DM89+WOXALTKIL3VX9Wo7/f8pK7vYIbS0qMPvRuQzV8jwN9KyG4yIwVpgqZ5ApCmFd6ubJHZSHRwCWsXVb/HdUKxbLOVzU8HvlwEAmvwxkU+WhpHApb3BjZsylcdwLURmCJXo2GJLa+7gYXJ1RfE5T2e7pQfG+5Gshg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P12D+sxse5XFmAGDoRZgPWmhNQed+z0vpuvnN50hXJk=; b=NCkil5M6lnnuxLRAVCiTlE6tGphiRISzuWQzuUJDnnrD8NCR8DZu7gFzBA6jiHq36U019ljdaqCvXXhDb3+h6RVDnzDGHhY4DK8FVnSHSoKP3FDvOZ/NBeg+oBAWWyHdyZ942d3aYI04vbAmUgYDR7ktVBc7AOsKmNKI9xL+5asMUFW9AlgZR8G7IjH4JwAD6odAZTq++W+YfCb/zIOIcLepS5o1bFdaQnEfA9tnV3l82dUXBHzlzn2kq45rK+fAWjM3f/kFgHa6g7SeM0vtQsejNzIBTTMtjqW45voJdB677B/0KHBj9B2Zidw1rzc0SWLzsukNR42+sVlEFFq2QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P12D+sxse5XFmAGDoRZgPWmhNQed+z0vpuvnN50hXJk=; b=1oBBVgv+Ee7YXPeG+RXYwudGWFdZZ3nYzVVcd8Mg9FeQ0GD7skmZqsHRS+2NSnOj6Ae+o+S/easPmt+/e6aBqdScfY4S+5mCZjOyJqywEAWwIIGiUK+LSgAGujftTBZbiAPKV6EpbMQHvWYs9uNnYZEqR9WbyI+WXJ4k9ezF71w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7506.prod.exchangelabs.com (2603:10b6:510:f5::22) by DM6PR01MB4345.prod.exchangelabs.com (2603:10b6:5:7b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.10; Fri, 17 Mar 2023 14:52:31 +0000 Received: from PH0PR01MB7506.prod.exchangelabs.com ([fe80::db61:2d8e:771e:7e33]) by PH0PR01MB7506.prod.exchangelabs.com ([fe80::db61:2d8e:771e:7e33%5]) with mapi id 15.20.6222.008; Fri, 17 Mar 2023 14:52:30 +0000 Message-ID: <3632d0c3-c946-b177-3deb-f8d851906d41@amperemail.onmicrosoft.com> Date: Fri, 17 Mar 2023 21:52:20 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version To: Rebecca Cran , Leif Lindholm , devel@edk2.groups.io CC: patches@amperecomputing.com, ardb+tianocore@kernel.org, Nhi Pham References: <20230313064321.170866-1-tinhnguyen@os.amperecomputing.com> <0e962fce-d8d2-9622-94af-5f32e5a51ca4@amperemail.onmicrosoft.com> From: "Tinh Nguyen" In-Reply-To: X-ClientProxiedBy: SGAP274CA0003.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::15) To PH0PR01MB7506.prod.exchangelabs.com (2603:10b6:510:f5::22) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7506:EE_|DM6PR01MB4345:EE_ X-MS-Office365-Filtering-Correlation-Id: c5a97a29-b148-4b32-5a70-08db26f73b60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RU1Q7RALiiGP92+L+OAYoYH1eziarle4WQ6dvBu49kEJEackqdxohb+R2BGAW0vVHXNtZBlbjsjO+1kO1RphEdHSoP3vqZiOYlReBAk7ah4qrrFnTF/CQ13nJMZeVhXrGRG/SxHjNf1yQwd4VwF59oe3W/IQVQyQNv4rKowDNAx61gpgCYo5DKd1Xmd/ymqHDgbnvU/3ynMSi2PEz8gE4E2L7vgiqMY+BH6v7qG91b67dKpiWL5pHcVPsMgzGz4uOpDrRNUGjnPt/BhaXso/4jbyFnaCRwRaajnZzdjRRH+DMm8sRKBm08Orxo8IxUtlc2XcFoSeRTdqCQ57BjWg5H84CI3tV6HFdUDtO2Dpg6YLkiAzdK2A5ESLDfGPSQGkeie95aWDCugUSWb78AF2puW8f+Ez67oGXVJpkuVrmBCV5iIyrXsobEEo9qGf2dPhaNiYhUBGm5X1OXlQBlaVvCdsYf1lPG27zLqGX8znBrBEpUgTrkfL9a/Za1op6vYW5VIUhQQx64/RApxjNfL+v/E1GpCrHt0sTjLLnVdDPeA3r7zQmQ1gzizeMcUurJ/FPSHT5Bub5jc6FgIuNPI+6kNUJ/kfkjR//aO7K3XL4pR3bXivPIjia6Fj9N404tfLTF9N35rAQn6E5FhCzCGTu3C1OdKET7Omwwwjb6YgusxMGEmY2ZwBJe9V1pYpfJhg7b+knkhYX9EvbmkuPAz4yA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7506.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(376002)(396003)(39850400004)(451199018)(31686004)(316002)(110136005)(6512007)(26005)(6506007)(53546011)(2906002)(478600001)(41300700001)(66556008)(66476007)(8676002)(4326008)(38100700002)(83170400001)(66946007)(6666004)(107886003)(8936002)(5660300002)(2616005)(83380400001)(4744005)(42882007)(186003)(6486002)(31696002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EtSRwlVD6dBPUzgNTDhNSMy1MXe8dtPk7GKHGqH7yUDOUXxHy7qOa6BhA02+?= =?us-ascii?Q?ReiP13rJLJJfTXm4yPmo2YFMUmy2SMuo1dNlyZGv5EBo6XMeopD5ETya4jUs?= =?us-ascii?Q?m8I1TxIeNvU6cVVpCMzpAnSnIFGxekLMPXZkwmMvWeIZkVAQMIRMmPpcuTq3?= =?us-ascii?Q?9R//Hrw4G4RmOgtbO4EPgyxDd++ciRuh5FhqFt52ymmBgSIGaYBE9a+yLySj?= =?us-ascii?Q?6Y6e5+V58HI0DPU+yY/Vz3EXXSw65+dPnBt1NEwS7Bh1RUrylWJek4O7aE/+?= =?us-ascii?Q?A05VQh5VLTqtY9Uu+kezpsv8BmbSlY7bjRKFCX26fA0jH7OFPajfKz+7UHMY?= =?us-ascii?Q?N+u/scjQ1fvHbes13tcywrpCf2Btfhaj+gIthE9g69Ud8JPy8PhvZu7gfN2g?= =?us-ascii?Q?q1fd9g8Sz2eiKkVEwDoYdIH2vppFI+whkgh0IC1c+IBfdmeVwWCojNFgns8+?= =?us-ascii?Q?FNvRq1dXmy7EOS4ArIB43qC4GqUWPzA0xeOAbYzS1JbC7gdO5yl3BXMBAJ1y?= =?us-ascii?Q?Hccxjx+9GS0UcauOSXq4mPl6f6kjOJmp1jQC8zOtZ8Gon+Z1o+FsmRi1AnSz?= =?us-ascii?Q?iGJ9pl/LealmKS4rFlaLKGwl3gZB1dSdCLtLH23BMgGp8Pc3ptdeZ/U50v4I?= =?us-ascii?Q?j3bvnmKQ/ioCT3RGIh4BoEBhpnQO/wsxt/Yt4kI8U1Yf32N27Rhn+c2Z+qFH?= =?us-ascii?Q?jJ2uLREYfBdhx7HLucL4jlcbsw0hs7warBEie0e5FSP2c95ibFQNT/zcfpug?= =?us-ascii?Q?Y8zF+YfA24tEd2KMY1CiA9ueScRAk3nE84bTORD+Ju8wXrfTP23mAfXce9a8?= =?us-ascii?Q?yhdLyVt5o3Op9wwJBoJRmoOFe+zFQTH8RkYJrEZbBuzn3Fntj89S5QtUwDC8?= =?us-ascii?Q?qAVKTtuLku+d/VxvjvXOB3gpH5BRxxB7VZ1TwGxwsQ6bnwVuF8MDAO1NrqVt?= =?us-ascii?Q?7astE/BOuchzavPkOu5FuDwZeAHfj1HQ/3WL2k2MyHFFRmb6x3U78qBKqCez?= =?us-ascii?Q?0IK1dx1nEt0oR052vB50kr+KtdmPL7PyZMm4RY8LappKxVW1x23/Mu1kpWqp?= =?us-ascii?Q?DEwCj5T0mbfPkd++nagmq+WgRAqjiEnLdNXoZdscLJbJ8FN6W/KeykIfgYib?= =?us-ascii?Q?6BAEcMgoGfbG0Rub12XzaqjWa9G6t6KW7Di4wC+Tc13/AJMEKr7PrRqjkT3Q?= =?us-ascii?Q?a+DxvPyG8jGK/soC0JXyriVlS3hFOh2k5UxPfiX+HFTyX9M9S82Lwktx7BXO?= =?us-ascii?Q?DcsXJGUtxwFbUKWbNpVDjdk66JcYqn8bAZMiWkUCV5m6jircc4YuD593EvCs?= =?us-ascii?Q?tZ6P9yXEMo37okKRciB6aOLBmfVQrGHL9r5NHft/+0ur7y2WrlNz0HlIIKuH?= =?us-ascii?Q?8tWnD5f4RaTZrrTx6jTvQBC0rP6TvH9gWcnXNfgRddLlFjhYamtdfrrZj+jV?= =?us-ascii?Q?Mlc9y1OtR8EJ+NeEVR+pNdxmUSye0p1pHaWuiG8mpJpOgRxFr8pBsBBQmyCL?= =?us-ascii?Q?KZaIRp2jf4h20araN+4H15IISTOp95ptwFAIKxsv+mzkWilSkwuhp2v18GSL?= =?us-ascii?Q?Y9zmeXRRFOzvGogWzsyCRCOdUBQ0XDHMAZDCOOJ9sp0CW8y4Czi/mGNrsnr9?= =?us-ascii?Q?BKDz0y6RIh2X9W0Sz2wBY+5pmCOtS/Jv9ywdI1DtFusi?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5a97a29-b148-4b32-5a70-08db26f73b60 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7506.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 14:52:30.4196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m5rC2OzsecZ+GfA+0us9+SWWV4eW1JdwqyO8hMHD5aGpwOF0yMKMIou5ffPn3fjkKqvNkwyoO2f/LMPqsuUPgkBMNXOtaSLauJt/gYdJFZog//mBliX+4P3Xg4yIF1fD X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB4345 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thank you for your feedback; I will submit v2 as soon as possible. Regards, Tinh On 3/15/2023 12:59 AM, Rebecca Cran wrote: > On 3/14/23 6:48 AM, Leif Lindholm wrote: >> No objection to that. >> But can we do it like this?: >> >> Change GetBiosVersion to SetBiosVersion and in MiscBiosVendor, only call >> >> =C2=A0=C2=A0=C2=A0 SetBiosVersion (); >> >> and move the selection logic fully into SetBiosVersion? >> >> Rebecca, thoughts? >> Arguably, once an OemMiscLib dependency was added, the Pcd values became >> less useful in the core code. > > That sounds very reasonable. > >