From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.56520.1669927388932905396
 for <devel@edk2.groups.io>;
 Thu, 01 Dec 2022 12:43:08 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=aG3dHbgp;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 890CF20B83C2;
	Thu,  1 Dec 2022 12:43:06 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 890CF20B83C2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1669927388;
	bh=aAn7tlV0a4KwZbNk25OkrZQfPgDPXmG36CszrQuDTSQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=aG3dHbgp7SY06t8R5JfHrKXwBf1uoGCS6NdUMG3FFMyZxKJ/OuUA6AAfe1yrv0n/l
	 zN1P51oH670U8/TBiRTB/Xs+mQA2NFxvnIuIccap8E7utHOMAcMEzOSktQ1g9aweAj
	 wtwSlB5tRn6uwlisitJuRqUGJ+kODNjr1Ex6qcTI=
Message-ID: <3637a1b6-bd63-73e0-8844-e09fc2b265a8@linux.microsoft.com>
Date: Thu, 1 Dec 2022 15:43:05 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v10 09/17] EmulatorPkg: CI: Use Fedora 35 container (Linux only)
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Gerd Hoffmann <kraxel@redhat.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen
 <jordan.l.justen@intel.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Sean Brogan
 <sean.brogan@microsoft.com>, Sunil V L <sunilvl@ventanamicro.com>,
 Yuwei Chen <yuwei.chen@intel.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Chris Fernald <chfernal@microsoft.com>
References: <20221201202810.109662-1-osteffen@redhat.com>
 <CA+bRGFowrBDhmDphv4fswJn+ZLJd=E94JN=f2U72Tbf9k+h3Ow@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <CA+bRGFowrBDhmDphv4fswJn+ZLJd=E94JN=f2U72Tbf9k+h3Ow@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 12/1/2022 3:28 PM, Oliver Steffen wrote:
> Run all Linux based jobs in a container, using a custom Fedora 35 image
> (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
> here: https://github.com/tianocore/containers
> The version numbers of gcc, iasl, and nasm are pinned to avoid
> unintended upgrades during image rebuild.
> 
> Use Python from the container image, do not download at runtime.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> Acked-by: Ray Ni <ray.ni@intel.com>
> ---
>   EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index a32c57d4aab4..e58bb5b55245 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,10 +15,6 @@ trigger:
>   pr:
>     - master
>     - stable/*
> -
> -variables:
> -  - template: ../../../.azurepipelines/templates/defaults.yml
> -
>   jobs:
>     - job: Platform_CI
>       variables:
> @@ -79,6 +75,8 @@ jobs:
>       pool:
>         vmImage: $(vm_image)
> 
> +    container: 'ghcr.io/tianocore/containers/fedora-35-test:2113a0e'
> +
>       steps:
>       - template: ../../../.azurepipelines/templates/platform-build-run-steps.yml
>         parameters:
> @@ -89,4 +87,4 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> -        usePythonVersion: ${{ variables.default_python_version }}
> +        usePythonVersion: '' # use Python from the container image