From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B83F4201B0430 for ; Wed, 27 Feb 2019 04:38:15 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC79D7F403; Wed, 27 Feb 2019 12:38:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-178.rdu2.redhat.com [10.10.120.178]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D15560464; Wed, 27 Feb 2019 12:38:13 +0000 (UTC) To: "Feng, Bob C" , Leif Lindholm Cc: "edk2-devel@lists.01.org" , "Gao, Liming" References: <20190226010519.17740-1-bob.c.feng@intel.com> <20190227082600.7g6m6a6uwmp4sfuj@bivouac.eciton.net> <08650203BA1BD64D8AD9B6D5D74A85D1600901EC@SHSMSX101.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <36496ec8-0957-3caf-ae6a-41444bedcd93@redhat.com> Date: Wed, 27 Feb 2019 13:38:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D1600901EC@SHSMSX101.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 27 Feb 2019 12:38:15 +0000 (UTC) Subject: Re: [Patch] BaseTools: Add python3-distutils Ubuntu package checking X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 12:38:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/27/19 09:52, Feng, Bob C wrote: > Thanks for comments. I think the print message is not good. It's based on Ubutun OS. It's not right. > > I think the import error need to be caught and then print some messages, otherwise the build tool will break and print the call stack which is not friendly to user. I agree. OS or package name specific references should not be printed, but a user-friendly, concise message about the missing Python feature should be. As soon as I see a Python (or Java, for that matter) stack dump dropped on me, my first instinct is to close the terminal window. Obviously I won't do that most of the time, but it takes effort to start deciphering the stack dump. Give me a usable one-liner error message, and *optionally* a stack dump to dig down. Given that the situation can be remedied by a google search ("what package on my system provides this Python feature") plus a package installation, the stack dump is entirely irrelevant in this case. Thanks Laszlo > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, February 27, 2019 4:26 PM > To: Feng, Bob C > Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking > > On Wed, Feb 27, 2019 at 09:07:49AM +0100, Ard Biesheuvel wrote: >> On Tue, 26 Feb 2019 at 02:05, Feng, Bob C wrote: >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>> >>> Add python3-distutils Ubuntu package checking. >>> >> >> Hi Bob, >> >> This assumes that all Linux systems are Ubuntu based, which is not >> true. The apt tool is specific to Debian/Ubuntu, Fedora/Redhat and >> Suse all use something else. >> >> In general, I don't think we should validate the Python environment to >> this extent, since we cannot fix the problem for the user anyway, only >> flag it, and since python explodes rather loudly in this case, I think >> we should be able to leave it up to developers that are savvy enough >> to build EDK2 to also find the python distutils package for their >> platform. >> >> Note that that doesn't mean we shouldn't document this, and not just >> for Ubuntu. But I think putting it in the script is overkill. > > Yes, I agree > > It is also worth noting that python3-distutils is the current debian/ubuntu package name. So if we *do* print a message... > >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Bob Feng >>> Cc: Liming Gao >>> --- >>> BaseTools/Tests/RunTests.py | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/BaseTools/Tests/RunTests.py >>> b/BaseTools/Tests/RunTests.py index 0dd65632d0..64778db981 100644 >>> --- a/BaseTools/Tests/RunTests.py >>> +++ b/BaseTools/Tests/RunTests.py >>> @@ -17,10 +17,24 @@ >>> # >>> import os >>> import sys >>> import unittest >>> >>> +distutils_exist = True >>> +try: >>> + import distutils.util >>> +except: >>> + distutils_exist = False >>> + >>> +if not distutils_exist: >>> + print(""" >>> +python3-distutil packages is missing. Please install it with the following command: > > ... printing "missing python distutils package" and possibly python version would be more reliable. > > But as Ard points out - this is effectively what python itself will say. > > / > Leif > >>> + >>> +bash$ sudo apt-get install python3-distutil >>> +""") >>> + sys.exit(-1) >>> + >>> import TestTools >>> >>> def GetCTestSuite(): >>> import CToolsTests >>> return CToolsTests.TheTestSuite() >>> -- >>> 2.20.1.windows.1 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >