From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, guomin.jiang@intel.com,
"garrett.kirkendall@amd.com" <garrett.kirkendall@amd.com>
Cc: "Ni, Ray" <ray.ni@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass
Date: Tue, 23 Jun 2020 13:16:09 +0200 [thread overview]
Message-ID: <365357ef-87b5-24ce-4d2b-8c56781b390d@redhat.com> (raw)
In-Reply-To: <DM6PR11MB29552DB81FA8750BC80AAE699D940@DM6PR11MB2955.namprd11.prod.outlook.com>
On 06/23/20 02:52, Guomin Jiang wrote:
> Hi Garrett,
>
> Thanks for report quickly and it work and the 'Mac format issue disappear'.
>
> But another build error occur 'error LNK2005: _InitializeFloatingPointUnits already defined in FspSecCoreT.lib(InitializeFpu.obj)'
> It seem that result by ApicLib who depend UefiCpuLib now.
Yes.
> I want to know why you add this dependency,
It was discussed on the list in advance.
[edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD
function to BaseUefiCpuLib
https://edk2.groups.io/g/devel/message/61079
In addition, we have investigated all the platforms in the open source
edk2 and edk2-platforms trees that could require an update due to the
new dependency:
https://edk2.groups.io/g/devel/message/61525
And this series is in fact addressing them all.
> have any other way to do it, for example, add the dependency to the dsc file.
Please describe how you can reproduce the link error using edk2 and
edk2-platforms content *only* (= using open source components only).
Thanks
Laszlo
next prev parent reply other threads:[~2020-06-23 11:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 13:18 [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE Kirkendall, Garrett
2020-06-22 13:18 ` [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass Kirkendall, Garrett
2020-06-23 0:52 ` [edk2-devel] " Guomin Jiang
2020-06-23 11:16 ` Laszlo Ersek [this message]
2020-06-28 9:11 ` Guomin Jiang
2020-06-28 14:41 ` Dong, Eric
2020-07-07 7:42 ` Ni, Ray
2020-06-22 13:18 ` [PATCH v6 2/4] SourceLevelDebugPkg: SourceLevelDebugPkg.dsc " Kirkendall, Garrett
2020-07-07 3:21 ` Wu, Hao A
2020-06-22 13:18 ` [PATCH v6 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib Kirkendall, Garrett
2020-07-07 2:55 ` Dong, Eric
2020-06-22 13:18 ` [PATCH v6 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD Kirkendall, Garrett
2020-06-22 15:17 ` Laszlo Ersek
2020-07-07 2:54 ` Dong, Eric
2020-06-24 1:04 ` [edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE Kirkendall, Garrett
2020-06-24 8:53 ` Laszlo Ersek
2020-07-07 2:38 ` Dong, Eric
2020-07-07 23:32 ` Laszlo Ersek
2020-07-08 0:21 ` Guomin Jiang
2020-07-06 10:11 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365357ef-87b5-24ce-4d2b-8c56781b390d@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox