From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.4748.1592910981241350321 for ; Tue, 23 Jun 2020 04:16:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XXO1PhYW; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592910980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=apiVe05oOhc1YRB+Lxo717lIH1t/rDYP2+YMMQYxkLw=; b=XXO1PhYWFLp/CKGaX8QLoMTmtJ2qp0kyvHw2D+rqV2o3RRnerYWCzdqA6s6BEubh8nw0q0 U03Vp850z6PKex18CzGYVqaoULbeqMdnTvGF7JIHguS9Qjam8thL0xT/OzFlVEI6GWQVZj sxIk9JQwvb0z3fsdqGJ1qP9sWqujtvs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-mFM3lTo9N7anOzk-0Y39tQ-1; Tue, 23 Jun 2020 07:16:13 -0400 X-MC-Unique: mFM3lTo9N7anOzk-0Y39tQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33D1F8035AE; Tue, 23 Jun 2020 11:16:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-244.ams2.redhat.com [10.36.114.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98B2F7D8F2; Tue, 23 Jun 2020 11:16:10 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass To: devel@edk2.groups.io, guomin.jiang@intel.com, "garrett.kirkendall@amd.com" Cc: "Ni, Ray" , Eric Dong References: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> <20200622131825.1352-2-Garrett.Kirkendall@amd.com> From: "Laszlo Ersek" Message-ID: <365357ef-87b5-24ce-4d2b-8c56781b390d@redhat.com> Date: Tue, 23 Jun 2020 13:16:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 06/23/20 02:52, Guomin Jiang wrote: > Hi Garrett, > > Thanks for report quickly and it work and the 'Mac format issue disappear'. > > But another build error occur 'error LNK2005: _InitializeFloatingPointUnits already defined in FspSecCoreT.lib(InitializeFpu.obj)' > It seem that result by ApicLib who depend UefiCpuLib now. Yes. > I want to know why you add this dependency, It was discussed on the list in advance. [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib https://edk2.groups.io/g/devel/message/61079 In addition, we have investigated all the platforms in the open source edk2 and edk2-platforms trees that could require an update due to the new dependency: https://edk2.groups.io/g/devel/message/61525 And this series is in fact addressing them all. > have any other way to do it, for example, add the dependency to the dsc file. Please describe how you can reproduce the link error using edk2 and edk2-platforms content *only* (= using open source components only). Thanks Laszlo