From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B98A994083A for ; Wed, 7 Feb 2024 00:51:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=urDirEN8e4p7PoyyPdNX/Lpf8Jpiij/AbjV6f+Oob4E=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:From:To:Subject:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707267063; v=1; b=u1+9nhG55STyKLBppdmAUnouAeEPvyo1GTYD/71at2nz6mL3yxEhWvYUrJkCw3dA5p1cAM5x 0HV0l193QhKsmK9ZOwP2yzWxTQf+A8Pu7rXyUdr5Nr0A/N9ga7frcraYmYUyn8VAXiOEZAzjFAL fJhpqHyJDinamel+A+j+gJfs= X-Received: by 127.0.0.2 with SMTP id ULG8YY7687511xVDKYzA0Pkt; Tue, 06 Feb 2024 16:51:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.9813.1707267062632062891 for ; Tue, 06 Feb 2024 16:51:02 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25--v5h2KU0PiWg5uEVtFGSQg-1; Tue, 06 Feb 2024 19:50:57 -0500 X-MC-Unique: -v5h2KU0PiWg5uEVtFGSQg-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B23E685A589; Wed, 7 Feb 2024 00:50:55 +0000 (UTC) X-Received: from [10.39.195.129] (unknown [10.39.195.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DECF0C0FDCB; Wed, 7 Feb 2024 00:50:47 +0000 (UTC) Message-ID: <36593e23-d3e8-b71a-808d-ef94260b5fd0@redhat.com> Date: Wed, 7 Feb 2024 01:50:46 +0100 MIME-Version: 1.0 From: "Laszlo Ersek" To: edk2-devel-groups-io Subject: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Cc: Abdul Lateef Attar , Abner Chang , Andrei Warkentin , Andrew Fish , Ard Biesheuvel , Ashraf Ali S , Bibo Mao , Bob Feng , Catharine West , Chao Li , Chasel Chiu , Duggapu Chinni B , Duke Zhai , Erdem Aktas , Eric Xing , Gerd Hoffmann , Gua Guo , Guo Dong , Igniculus Fu , James Lu , Jiewen Yao , Kelly Steele , Ken Yao , Leif Lindholm , Liming Gao , Michael D Kinney , Michael Roth , Min Xu , Nate DeSimone , Paul Grimes , Rahul Kumar , Ray Ni , Rebecca Cran , Sai Chaganty , Sami Mujawar , Sean Rhodes , Star Zeng , Sunil V L , Susovan Mohapatra , Ted Kuo , Tom Lendacky , USER0FISH , Xianglai li , Yuwei Chen , caiyuqing379 , dahogn , meng-cz X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: epdyaGis4qwx2tLA9lR51vuQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=u1+9nhG5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Bugzillas: - https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 - https://bugzilla.tianocore.org/show_bug.cgi?id=3D991 Personal build: - https://github.com/tianocore/edk2/pull/5354 I'll follow up with two series, in response to this message. One of those sets makes AutoGen declare ProcessLibraryConstructorList() for SEC modules (as Liming suggested), and cleans up the buggy or superfluous manual declarations in edk2. The other set cleans up edk2-platforms similarly. The edk2 set is intended to be bisectable. The edk2-platforms set can't be like that (separate repo anyway). I build-tested everything that I could, but the coverage is not complete in edk2-platforms. Note that the personal build (PR#5354) failed. The reason is that CI uses an out-of-tree BaseTools installation / package (version 0.1.48 at the moment). This just goes on to show why it's a bad idea to develop BaseTools in separation from edk2: even though the edk2 series *is* fully bisectable, it's impossible to get it through CI (because CI ignores the BaseTools update inside the series); and if we get the central BaseTools patch from the edk2 series into "that other" (separate) project *first*, then the series will not be bisectable any longer (because the BaseTools/AutoGen update at the front, without further patches in the series applied, will trigger build errors). Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115193): https://edk2.groups.io/g/devel/message/115193 Mute This Topic: https://groups.io/mt/104210524/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-