From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B92EA7803D7 for ; Mon, 5 Feb 2024 16:41:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/XeUBTKvlGokNPt4yYO3O4nHn8vQJwx2YhPhD0dAVPU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707151294; v=1; b=ihyoqq/RlzR/F9LfCMfkuBLFfyoW2npg+5YBvhtoTHNksp0VtS7gV/4e/83+WX2yf6+DwKKY ApvX8ZCPWHEzV9tflpAgkcl8cXKD3HzuASAzquU4OdLSvXoxoR0oFzUxlwjFf5RvHmmKdCn25aN 4axyIvnsNmPCrfN2Rix6DIuA= X-Received: by 127.0.0.2 with SMTP id nTL6YY7687511x4y2gt2bvL7; Mon, 05 Feb 2024 08:41:34 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.67451.1707151293622160355 for ; Mon, 05 Feb 2024 08:41:33 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-wUU2NKmvNtmej0Eh7FRZkA-1; Mon, 05 Feb 2024 11:41:29 -0500 X-MC-Unique: wUU2NKmvNtmej0Eh7FRZkA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 87448185A783; Mon, 5 Feb 2024 16:41:28 +0000 (UTC) X-Received: from [10.39.192.115] (unknown [10.39.192.115]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F3023C2E; Mon, 5 Feb 2024 16:41:26 +0000 (UTC) Message-ID: <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> Date: Mon, 5 Feb 2024 17:41:25 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again To: devel@edk2.groups.io, joeyli.kernel@gmail.com Cc: Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com, "Lee, Chun-Yi" References: <20240204092914.29813-1-jlee@suse.com> From: "Laszlo Ersek" In-Reply-To: <20240204092914.29813-1-jlee@suse.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HeNHHCkFMJ3ZJudJWvnIaSlBx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="ihyoqq/R"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/4/24 10:29, Lee, Chun-Yi wrote: > In case PcdFirmwareReleaseDateString is not set use a valid date > as fallback. But the default valid date can _NOT_ pass the Microsoft > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > the error message: >=20 > BIOS Release Date string is unexpected length: 8. This string must be in > MM/DD/YYYY format. No other format is allowed and no additional informati= on > may be included. See field description in the SMBIOS specification. >=20 > Base on SMBIOS spec v3.7.0: >=20 > 08h 2.0+ BIOS Release Date BYTE STRING > String number of the BIOS release date. The date > string, if supplied, is in either mm/dd/yy or > mm/dd/yyyy format. If the year portion of the string > is two digits, the year is assumed to be 19yy. > NOTE: The mm/dd/yyyy format is required for SMBIOS > version 2.3 and later. >=20 > So, let's tweek the fallback release date again. >=20 > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release d= ate") [edk2-stable202305~327] > Signed-off-by: "Lee, Chun-Yi" > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/Smbi= osPlatformDxe/SmbiosPlatformDxe.c > index 0ca3776045..e929da6b81 100644 > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -160,7 +160,7 @@ InstallAllStructures ( > DateStr =3D (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > DateLen =3D StrLen (DateStr); > if (DateLen < 3) { > - DateStr =3D L"2/2/2022"; > + DateStr =3D L"02/02/2022"; > DateLen =3D StrLen (DateStr); > } > =20 Are you proposing this as an important (but low risk) bugfix that might qualify for the freeze(s)? If so, please loop in Liming and Mike. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115119): https://edk2.groups.io/g/devel/message/115119 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-