From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8ADC97803D0 for ; Tue, 23 Jan 2024 02:15:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yolgOHS2fEew7WVuC4vcmtMZEhXdTb8/UQ0sLvB/kBc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705976100; v=1; b=mCpcttiVnNnimneCbk4K4gqVhWHBZKItk7aRDsrg6zDUuEl7kSXSTbrPTTR6je0jvauXAq9+ fewtLFsuRdnv9vv3N8W25JkYw3GTacXeX3So6LumwaTSY8g+dKiykXwciWkOCwlE6Chom/Mhla0 Rgd6YW14vt9Dkv+d9mGPaSrc= X-Received: by 127.0.0.2 with SMTP id 8JF9YY7687511xW86yidaFED; Mon, 22 Jan 2024 18:15:00 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.123]) by mx.groups.io with SMTP id smtpd.web10.2091.1705976099383697289 for ; Mon, 22 Jan 2024 18:14:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jrFYaHmC+zHmiILN9vGUrA12fmroLIber9cOBKWBV6MpcIJeaClAIgpsDDSO5ivokBebxxBUx0IIU+RYtxYeWtbW2KzHPG+lkvOnYv8/QWdAxPXUrP1ug8M9mQrvLRf6ZLI2f9U/4zGQ7MsGBcXez3bmocDf/f0pUcpB0sWF2KQ/NFcfx91EYpvTICWfQgcejccL4jDzhARWfrmcwwEoK8OiG+UfZUlDhIj6oXCh5nHWdfwldtoRu1Wnxn+//zIZbKbQR0oadSDXezNdfqwc8+pPEz08iYTPSrU2+zd3js6x4Dzkv6JW+LzLjBFZALrpvvhp4rzvuQWM/tRUTC+V1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CqPIT+pGCuNgseYbuULVf3rmLmvBmEsHUyWVvQw44+Q=; b=gsEvGUtaXccQMY9i6la+GCnIqQtYqTTqfY3p+wQ4DzH8thm54bd4lqUh/bozkTivIBmbrMSfBIoUyVl+VxBM5/TSx7FNvhcsQr6I1eyBqJ6dLVdidMaBnXC7L3uYjXxJG3/EENT8nJzQVoUosxL8oENI6n4VRkePeIkGPXxn/eKgYvfhXOsRocjxMX9HZ+1W2YNtO3O1kN4Ms9Yfm7Z2kvWZEeccvpnsLSb9uBNyj7LqbZB0rzsMAV8sYaambBajtC4fj6Im9SxNjkKSYWgds7b5Cc6NySnrQ7JzFo20zmDbkwpWOR2GhfDwFVPN5DGBsef9WZrzAVWWzyHxPIEIvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by PH7PR01MB7533.prod.exchangelabs.com (2603:10b6:510:1e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Tue, 23 Jan 2024 02:14:54 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 02:14:54 +0000 Message-ID: <368894c0-b161-4e5b-a7a2-7a78c2101a37@os.amperecomputing.com> Date: Mon, 22 Jan 2024 19:14:49 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned To: Oliver Smith-Denny , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Jian J Wang , Liming Gao , Dandan Bi References: <05f6388b-155e-427d-8e34-0ac571e97fb8@os.amperecomputing.com> <24affef7-eb96-4a82-b9d4-b616eb90024d@os.amperecomputing.com> <17AB84FD31479E00.28523@groups.io> <0a589fed-02f1-4598-bbbc-98bad0e8b04f@linux.microsoft.com> <14dac152-dfea-4ad3-bd52-300990bd1be8@os.amperecomputing.com> <09a8622e-be60-46e2-8e96-447dacb8c12f@linux.microsoft.com> <9696df58-283c-447d-b801-c3bb57b3787d@os.amperecomputing.com> From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH0PR03CA0017.namprd03.prod.outlook.com (2603:10b6:610:b0::22) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|PH7PR01MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: f99809d4-1de6-4e38-88a6-08dc1bb916a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: pW/X+2aQ+iwbg1kxMJ2Tz2CclRCVgo1fuAYrnNKxxS8gX6PmiwCSAw2QBJI4cueaOK6vl1AVgZL+YEBz9cI0f9ICmJcwwe9F5ILwjmtuiNLZQUpysM83uYRQ4/0lLCUHWLzja29euzgAvLd0eY5Zx1A2TDoZUKCtcByd6mIb3ckaET3JlUNQknYaEGvRY35VFRo4b028Rtnf/NKOx3ucRgEch5See4e9NyshG/wyweINOIit7kp7yFa9RU4DXgV5yelPynwTYrvm0ehHtEKLfgeCBeGPjbwMNNhEryWJ8qf7TQuCDgXsieahmZxsuOmFmr4BUHV3RL4rzOPA7Q2Xw6Niqf6qX/mP/mXu8q2vg8BpcNf1oS1ucT5g+lQtl/VJE2YQURSXU/RlAXrf1d+JghPnTCF3K8XZyK1X7+k8c783BRdDqn4OPxCAHEQr2Wo1NmWnJZnuwe0SFf59LB2duTLau6HtQndk0kuHSR1hIox4Y0d25efBtjPcpV5fg/AuLuJFtOdrm0WYf7c+uRu/s4r16g7kqrJjqOahWK1B813hbRvSY5kWZLrF7q/PmV4D79KGNNeZ3rs3ovyE73YawLyVT4lcKWQnh4Cn/ZtltF9bXJpjztKVZ86DQogmbdGh X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2dLOURlcnFNOXVKQTFTZXFPMnJ6UkJEVTI3WnRwajFkYmYzRkYyVENobUpO?= =?utf-8?B?dkRja2laR0RlYUR4R0h4T2drTmJiN2tEUm9heWdFczVnQi8wVXdMcm5yKzdN?= =?utf-8?B?c3g0dlovMmYxRUJReEtJT09QT2RQSVhzUjNOaURhMGRoSmo4c3FrZGV6bHgw?= =?utf-8?B?eXZvV3VlaUI0Y0NhK01STGtzNC9oTWM2bjJHZU1WV29aZWdualBzR0VBWEFu?= =?utf-8?B?R0MreWJ0eEhYYW5uZkVlaEdtZ3hyWkVwSi93QXVia1o4N3VUMit2M2JRN2wy?= =?utf-8?B?Y3drMnoyUGQySmNsUzh1MEZ0ejBLRGk0Q1JSR2RGMEEydldPSXV0WStqbGxK?= =?utf-8?B?dHl2YkswNWFkQUNJUlU5TjVLOXhmRU04bEpMQXl4bVVhTExVRHNYaTREV2VE?= =?utf-8?B?Tnl0MVJKMzlLaVkxem9kdUgrMUIxQ0U1aER1VyswWGdoSmNxaFBrUW9SMmJM?= =?utf-8?B?bVptNGphSlZUUzAvejNsOXM0MGpkQjVMekIzeThqUlhhb2hmanphcE1SR2cr?= =?utf-8?B?bkxvSXBFUGlKUmZtSzdpUG91ZDhYN3hOWktpQTRaTVR4cmoxeXFYZTlna3Uv?= =?utf-8?B?Rm80NmpIdWVIL2cvMzVLdEdMbnEzai9BSXRpN3pvZGdDNmhmL1JyNytyTlFy?= =?utf-8?B?Zit5V2hGT1V0d2pmWWMwR3ZiVkI4MG1WalFYUlVHc2JHaDc0eUJvMkNnUlVS?= =?utf-8?B?OW41dkpRa0F6clQvZmJydk9laHpYUmRaaHE0c3pkL1V3VnJHNmNoR1FpRFQw?= =?utf-8?B?TlZjWmxhN2piRDF2RVJXSnRyZkhXYWYzUnNUVk9yZGUyOW1ZWkJWeVhqU2p0?= =?utf-8?B?VnVieDR4WmpMUG5pVEJ0RmxnNFFjVkZLaHdrVFl3Ym5hU0ZhanN5SWdtV0hI?= =?utf-8?B?Y0VXaEJDdXRpdVBaWXdPS2xndmlSYUlPYTRITWpsLzkwcmR2MG9ncE5obTRu?= =?utf-8?B?VDdqeGZvQnh4bGQ2SStEUXpiL1pDVVRUL1p2UnJZZ2NleTI5ZDM0aVJ3VEc3?= =?utf-8?B?eTBibjhtNE5CaFZZS2N5dEVpUThDOWwrdHo3NC9MMjk1WW9hWXlzcVZTSHBx?= =?utf-8?B?Y3BudE5UVjZoTTF3azh0REJlTkhIZ3ZHeHZrZ2lZSmxPeDg2UHE1dUdwWVNS?= =?utf-8?B?WDhNRVZ6OEFtRW1qcEpQV3NjQkRDSWlTQlVQMzZNSE9hbXAveDhpMDg3dWky?= =?utf-8?B?eER1b1dxUC9ibmV5NnpFNk1taFJwQXBjUHFjajIxMGQwUm9qMndndTlqdDNv?= =?utf-8?B?eFdTekl2NkZmYWNyL0RLQU5XMEZKREdwVm1hZ3pEVHpaTytPVXhNQlFPOVUy?= =?utf-8?B?Y1hVOC9JcDY0VFFrOU11Tnd5Q3dtcWQyOTJYN1F1bjA2eXBENlRZQ1ZVU2Vp?= =?utf-8?B?QXBjdDRSeFcrVysvZHhRTHczT2lPYUFVRzBvQzl3amVRd2xXYUhOWGZESE43?= =?utf-8?B?bUJNYnQzYmMzbzlodlZrbTJFT0F6b1NmbGMvbGU0bXI0RzF3bmxucmtWWnRT?= =?utf-8?B?NFhVT0FyQ2FuRzhLZEIybkpQTXQwOEZHbGxLMDRuTEhmTllFQjdIbXF5allV?= =?utf-8?B?VUZSejVDZGlZaHdFc1lpNzVjQjVNbElXM1BRRSt0Z3hoZDM0bDVWcjBlQ3dj?= =?utf-8?B?TmFwL1pqT283RzR3dmhycUdmcE5jbXp5RVYzN2djNGJ3TjBWK0k5bVFSNVNx?= =?utf-8?B?M0ZxOTAvQyt1aXhrM3pvVFM2V2MyM3RyV2pONC9FSkxQTE9KNGpvK0ZnaEUx?= =?utf-8?B?Rmg3Y09pVXI1REVZM2o4TW8rUGdoSnVQVjBqbmJJYVk1dDdlaFlXQkxVTVNp?= =?utf-8?B?Wjlobi9hdWs4ODRXalAzV0t4MHFSSVRWNEFtTDJkUEtQY1lHaDNHRHdEUHVU?= =?utf-8?B?Y0NHRm8ybEswT3Y4bFRQUFQ1eU1UUVlHNVlGUUV1S1BTZjRMcW1kYWRkUkZX?= =?utf-8?B?KzlpdGRJb0d0ZVlzNE1TcW0venU1YjVjQUdOZ2ZsS045ajQyZXpBeDlNQkdU?= =?utf-8?B?c2puSGpjdjZTNi9QUXJRV2ZqdkdzRFZ4QmptTFQ1WjRaQkJIL2hrSjV3YjhT?= =?utf-8?B?MmIxSUFiNU94dEJHN2VHQWtqTjIrNHVVR0EvQ20wRTE4cHk1c2VqSUx6SUhX?= =?utf-8?B?a256aDJBRnVtRGVET01pU3l5UmtNL3lCYjF3alJ4aWsySi9pTlBqUC9YVkhO?= =?utf-8?Q?DvjPALwwwRVgXw9wx1P2uuc=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: f99809d4-1de6-4e38-88a6-08dc1bb916a0 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 02:14:54.3382 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ZYKtCR/Ipv1nqspbuGT9FiPOyUfYjJpcrQZ1zhbPLB2u4OFvwSgWtdFgTiSGYsgJroRzKSKxLoEogRxZo6nui/ISLGCpD/bFJCS+sgAXfhWrjyf3q8hAyyOe+MQoIen X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7533 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xHuiKLZuHzF7cisYodu7rQ8Gx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mCpcttiV; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/22/2024 6:53 PM, Oliver Smith-Denny wrote: > I was able to repro your bug (by just turning on page guards on > ArmVirtQemu, allocating runtime mem and freeing it). I think you > are the first person to free runtime mem on ARM64 with page guards > enabled (and to care when it failed :). >=20 > The heap guard code is not written with ARM64 in mind (nor is much of > the codebase, of course). Specifically in this case the heap guard code > only wishes to preserve 4 KB alignment, it knows nothing of ARM64's > runtime page granularity required. >=20 > Let me take a look at this, I'm working on a solution here, but I want > to test this out further. I'll try to send a patch later this week or > next. Thanks! I wonder if the same problem occurs on LoongArch64, which also=20 defines the runtime page allocation granularity to be 0x10000? MdePkg/Include/X64/ProcessorBind.h 261:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x1000) MdePkg/Include/LoongArch64/ProcessorBind.h 89:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x10000) MdePkg/Include/RiscV64/ProcessorBind.h 120:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x1000) MdePkg/Include/Ia32/ProcessorBind.h 262:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x1000) MdePkg/Include/AArch64/ProcessorBind.h 164:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x10000) MdePkg/Include/Arm/ProcessorBind.h 170:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x1000) MdePkg/Include/Ebc/ProcessorBind.h 125:#define RUNTIME_PAGE_ALLOCATION_GRANULARITY (0x1000) --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114164): https://edk2.groups.io/g/devel/message/114164 Mute This Topic: https://groups.io/mt/103810212/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-