* Build failed in Jenkins: edk2 #2791 [not found] <1257384555.0.1499763660487.JavaMail.jenkins@jenkins.xeni.kraxel.org> @ 2017-07-11 13:55 ` Laszlo Ersek 2017-07-11 14:00 ` Brijesh Singh 0 siblings, 1 reply; 2+ messages in thread From: Laszlo Ersek @ 2017-07-11 13:55 UTC (permalink / raw) To: Brijesh Singh; +Cc: Gerd Hoffmann, edk2-devel-01 Hi Brijesh, Gerd's Jenkins CI caught a number of (most likely invalid) [-Werror=maybe-uninitialized] issues with the new code. Do you have a way to build the tree for IA32 with DEBUG_GCC49, evaluate the errors, and send a series to suppress the warnings whenever they are invalid? (Simply by assigning zero to the affected variables early into the affected functions.) Please note that the coding style requires a specific comment format for such warning suppressions: https://bugzilla.tianocore.org/show_bug.cgi?id=607 Of course, if some of these warnings happen to be correct, then the bugs should be fixed. :) Please find the first such error below. Thanks! Laszlo -------- Forwarded Message -------- Subject: Build failed in Jenkins: edk2 #2791 Date: Tue, 11 Jul 2017 11:00:57 +0200 (CEST) OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c: In function 'InternalQemuFwCfgDmaBytes': OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c:168:5: error: 'NumPages' may be used uninitialized in this function [-Werror=maybe-uninitialized] InternalQemuFwCfgSevDmaFreeBuffer (BounceBuffer, NumPages); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [Build/OvmfIa32/DEBUG_GCC49/IA32/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib/OUTPUT/QemuFwCfgLib.obj] Error 1 GNUmakefile:330: recipe for target 'Build/OvmfIa32/DEBUG_GCC49/IA32/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib/OUTPUT/QemuFwCfgLib.obj' failed ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Build failed in Jenkins: edk2 #2791 2017-07-11 13:55 ` Build failed in Jenkins: edk2 #2791 Laszlo Ersek @ 2017-07-11 14:00 ` Brijesh Singh 0 siblings, 0 replies; 2+ messages in thread From: Brijesh Singh @ 2017-07-11 14:00 UTC (permalink / raw) To: Laszlo Ersek; +Cc: brijesh.singh, Gerd Hoffmann, edk2-devel-01 Hi Laszlo, On 07/11/2017 08:55 AM, Laszlo Ersek wrote: > Hi Brijesh, > > Gerd's Jenkins CI caught a number of (most likely invalid) > [-Werror=maybe-uninitialized] issues with the new code. Do you have a > way to build the tree for IA32 with DEBUG_GCC49, evaluate the errors, > and send a series to suppress the warnings whenever they are invalid? > (Simply by assigning zero to the affected variables early into the > affected functions.) > I have been using GCC5, will try to setup GCC49 environment and provide patches to fix this warning. Thanks for report. > Please note that the coding style requires a specific comment format for > such warning suppressions: > > https://bugzilla.tianocore.org/show_bug.cgi?id=607 > > Of course, if some of these warnings happen to be correct, then the bugs > should be fixed. :) > > Please find the first such error below. > > Thanks! > Laszlo > > -------- Forwarded Message -------- > Subject: Build failed in Jenkins: edk2 #2791 > Date: Tue, 11 Jul 2017 11:00:57 +0200 (CEST) > > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c: In function 'InternalQemuFwCfgDmaBytes': > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c:168:5: error: 'NumPages' may be used uninitialized in this function [-Werror=maybe-uninitialized] > InternalQemuFwCfgSevDmaFreeBuffer (BounceBuffer, NumPages); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make: *** [Build/OvmfIa32/DEBUG_GCC49/IA32/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib/OUTPUT/QemuFwCfgLib.obj] Error 1 > GNUmakefile:330: recipe for target 'Build/OvmfIa32/DEBUG_GCC49/IA32/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib/OUTPUT/QemuFwCfgLib.obj' failed > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-11 13:58 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1257384555.0.1499763660487.JavaMail.jenkins@jenkins.xeni.kraxel.org> 2017-07-11 13:55 ` Build failed in Jenkins: edk2 #2791 Laszlo Ersek 2017-07-11 14:00 ` Brijesh Singh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox