Re: [PATCH v4 07/11] ArmVirtPkg; avoid DxeTpmMeasurementLib in shared .DSC

["Laszlo Ersek" <lersek@redhat.com>]

On 02/27/20 15:40, Ard Biesheuvel wrote:
> DxeTpmMeasurementLib should only be used on platforms that implement
> measured boot, which we will do in a future patch, but only for
> ArmVirtQemu, as the remaining ones are fundamentally incompatible,
> given that they do not implement a PEI phase.
> 
> So use TpmMeasurementLibNull as the default resolution for all
> ArmVirtPkg platforms, regardless of how they are built.
> 
> This mirrors commit 1ec05b81e59f ("OvmfPkg: use DxeTpmMeasurementLib
> if and only if TPM2_ENABLE", 2019-07-04).
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 10037c938eb8..8f9617359607 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -165,15 +165,14 @@ [LibraryClasses.common]
>    # Secure Boot dependencies
>    #
>  !if $(SECURE_BOOT_ENABLE) == TRUE
> -  TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>  
>    # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
>    PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
>  !else
> -  TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>    AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>  !endif
> +  TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>    VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>  
> 

Thank you!

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Laszlo