From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.5652.1582816886727825428 for ; Thu, 27 Feb 2020 07:21:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aBb3WuG0; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582816885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DcbYcxBMtK4AFyZ2w0snKo7I50WeGACvpB4Aqml1eV8=; b=aBb3WuG0DsXzJHvUGn1A5KgiHAue4kgzxyK56e+IT+BrU6wOTNjO5F541k6b88FZU4DdOa 0lf1hWuLi0msdsitF8N/GjbwR6xQnGbviQrRpNy82PRRUaJNDK4xP2RrmjrBVWbqIhZxEQ x/Xv46mVkUNou16NnZBnX6IYTpnnbDU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-6TR4vNRlNVGnTaOkf6Vz6Q-1; Thu, 27 Feb 2020 10:21:21 -0500 X-MC-Unique: 6TR4vNRlNVGnTaOkf6Vz6Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7484F107ACC4; Thu, 27 Feb 2020 15:21:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-46.ams2.redhat.com [10.36.116.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE20877945; Thu, 27 Feb 2020 15:21:13 +0000 (UTC) Subject: Re: [PATCH v4 07/11] ArmVirtPkg; avoid DxeTpmMeasurementLib in shared .DSC To: Ard Biesheuvel , devel@edk2.groups.io Cc: eric.auger@redhat.com, philmd@redhat.com, marcandre.lureau@redhat.com, stefanb@linux.ibm.com, leif@nuviainc.com References: <20200227144056.56988-1-ard.biesheuvel@linaro.org> <20200227144056.56988-8-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: <36a22a56-3866-9163-53d9-964b2736a034@redhat.com> Date: Thu, 27 Feb 2020 16:21:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200227144056.56988-8-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/27/20 15:40, Ard Biesheuvel wrote: > DxeTpmMeasurementLib should only be used on platforms that implement > measured boot, which we will do in a future patch, but only for > ArmVirtQemu, as the remaining ones are fundamentally incompatible, > given that they do not implement a PEI phase. > > So use TpmMeasurementLibNull as the default resolution for all > ArmVirtPkg platforms, regardless of how they are built. > > This mirrors commit 1ec05b81e59f ("OvmfPkg: use DxeTpmMeasurementLib > if and only if TPM2_ENABLE", 2019-07-04). > > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirt.dsc.inc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 10037c938eb8..8f9617359607 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -165,15 +165,14 @@ [LibraryClasses.common] > # Secure Boot dependencies > # > !if $(SECURE_BOOT_ENABLE) == TRUE > - TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > !else > - TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > + TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > Thank you! Reviewed-by: Laszlo Ersek Laszlo