public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran via groups.io" <rebecca=os.amperecomputing.com@groups.io>
To: Sami Mujawar <Sami.Mujawar@arm.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v5 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
Date: Tue, 30 Jan 2024 07:56:58 -0700	[thread overview]
Message-ID: <36a38234-baa7-4ecf-b132-597569d81629@os.amperecomputing.com> (raw)
In-Reply-To: <E0FEEF11-E214-4A80-B93E-6866A3F5F800@arm.com>

On 1/30/2024 7:01 AM, Sami Mujawar wrote:
> Hi Rebecca,
> 
> Please find my feedback inline marked [SAMI].
> 
> I have fixed those changes in the pull request at https://github.com/tianocore/edk2/pull/5322
> Please let me know if you agree with the changes.

Thanks. Please go ahead and merge the changes.

-- 
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114791): https://edk2.groups.io/g/devel/message/114791
Mute This Topic: https://groups.io/mt/104037319/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-01-30 14:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 18:25 [edk2-devel] [PATCH v5 0/3] ArmPkg: GenericWatchdogDxe fixes and improvements Rebecca Cran via groups.io
2024-01-29 18:25 ` [edk2-devel] [PATCH v5 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset Rebecca Cran via groups.io
2024-01-30 14:01   ` Sami Mujawar
2024-01-30 14:49     ` Ard Biesheuvel
2024-01-30 14:56     ` Rebecca Cran via groups.io [this message]
2024-01-30 15:03       ` Sami Mujawar
2024-01-29 18:25 ` [edk2-devel] [PATCH v5 2/3] ArmPkg: Introduce global mTimerPeriod and remove calculation Rebecca Cran via groups.io
2024-01-29 18:25 ` [edk2-devel] [PATCH v5 3/3] ArmPkg: Disable watchdog interaction after exiting boot services Rebecca Cran via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36a38234-baa7-4ecf-b132-597569d81629@os.amperecomputing.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox