From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2F3157803E5 for ; Tue, 30 Jan 2024 14:57:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KNIPrIh95bc9YUuXpGWujPQWGkBSFll7quX5YTdxj58=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706626627; v=1; b=JisxiJlGGTWkDy8Ub/1HFe+m6hZsSYNj5A7mDSrNMJspnGTRmEQ4H3LEL0TKXzhAW9bYD2Vc q/U+N8ZtVIY11nqbfXyBsFQFv3MSlVTypVHwbkpSmbg1cbwzAEtmSAQ0H/ASLNgZ4nIjvf0tYY2 OAEHrTrQHEqEfrCbUYp/ieBM= X-Received: by 127.0.0.2 with SMTP id JlLlYY7687511xPj10M8aBso; Tue, 30 Jan 2024 06:57:07 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.120]) by mx.groups.io with SMTP id smtpd.web10.20432.1706626627303661758 for ; Tue, 30 Jan 2024 06:57:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lz/1pEPps9W6d8PrnuP3yOtZSR3qRto+nARuBEqCgUdaiH8eKZQ+x3xeGU+YOkyNkDrZJ1AopCJffB7j0gfLKG3rJ73Bs+W/NZFLWIEM5eABDkb8DcMyVjs5MB9WmgfOzMt+VIJzKeAKUqQ/JfjTbqj3ogceyUEgbhbW0eJz++tZpPsEYvYsvq3ZQBiuyVPyNpC7mfK/gXMqEb3ilpvgGfkX4AZ2Gg1n8s1OEjAmZEZzCNFeKI6jx8EDm9OrFNPrmQs1oh8AAbMU+/j4iIAwfszDDXEUNV0sRCIQTdtfguiE9hNk4vXGZulImjOSIEUoMPPstVh42DnQ7gppvBJGIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dAe3Z7854Gp1erxJ+yUvg8A5/X5qJkg9BU2WwZKl78I=; b=n1MGRnJlfCuGVriTNbKsc208Z/cDLu+RBluZ+yc2Q9GkJENaSQWUf0gxp6wjtR/Cxno1/uxLOboLUWW54XeAQKMohGJ2+SX7Qi+DHhFfLCXNx27uwdMSy/VW2dqLD54fH2dy+cDaXk68giaaW3CUy8Tbi0ltw8KpVjuq9CHJ1zuCvF0vKHZyuHjNhVve2jx3+dqxc1CQ3RK/+rVNGPyU31wHXXALwclch2VZpAdZDdoyM3UNMlm+Gpftq0S7Kt+OXnTo1vQt+eTILanByo2rGhlPi4qOTI59GPm5sbTtoWPN/u32t2jO5uHFoRp3IjSG2Wrn3wLBTtQyYcU8NjFMSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by DS7PR01MB7638.prod.exchangelabs.com (2603:10b6:8:75::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Tue, 30 Jan 2024 14:57:02 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 14:57:01 +0000 Message-ID: <36a38234-baa7-4ecf-b132-597569d81629@os.amperecomputing.com> Date: Tue, 30 Jan 2024 07:56:58 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v5 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset To: Sami Mujawar , Leif Lindholm , Ard Biesheuvel , "devel@edk2.groups.io" Cc: nd References: <20240129182514.1375466-1-rebecca@os.amperecomputing.com> <20240129182514.1375466-2-rebecca@os.amperecomputing.com> From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH0PR08CA0025.namprd08.prod.outlook.com (2603:10b6:610:33::30) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|DS7PR01MB7638:EE_ X-MS-Office365-Filtering-Correlation-Id: 521ee0f6-6a1c-40c0-ccdf-08dc21a3b73d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: sX1XFPtj/fFYSiPxO0VXsKf/YbAoQYTdGoUBRZ7+yzKLuLDp+YpZBai7zmCPXtcdHHBiWt5yiZLryB/TVmkzoClPeY0MDBGz51LwiCj/xvb4rt3TZvq0FwVz63SA2FUqs4Kgj3Vir+t/02DMnAOKVEOh+J3NsPeNOWAvbbgDLaFmwqSszGQRjzTdissxwJVr+1UlJjJfLPHgU7p5FuLkEyZvDf6ORdwgbkyjlze2BVg4ES0Kz3Z6ht06Oq0rvtugHmr2GXIEoraz8B+xJOZCLCvcJzSq17myOAfvkOG20ID2e7FBzesxlsvrH97boEyilAVWj9Zsanm4GqMonjE/YhcJlhSQlkOyxBLS29I+ynumUnT4+vqAjDJdmrjTs8U8fB2MQXT2pqL9Pn21rQC3FBK1eIUNKYDrwKiy3yeiWOXtgg6b5ME5BVqJlXvZZC747rgynilKxji/8WAFOYaNuPdBkhEtPb6ZhlPJIRm2jN6pThpSv/OBUFelzUvyo3TRZG0MntuBGiu8FbtrbxbaebLgxLKbbIDutCiqtItdij6QxXUkbdcvMsju77aQ/l0A5rbiYtOMi21fNoPPDx4KCUIqQa4mImEG7cceSvFFz1Y= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDFNMTloNHorYjY3T3ZZMlNhUmREeDJlbDB2UGpUMkpINXRLakxLakhjZ05Q?= =?utf-8?B?bDhBUFRwTUtVVFlIZHFpUUdHZG9SeTVzZm13OVozQ0VCL1RwQ3IrZFE1UElN?= =?utf-8?B?TWI1ZkdtYkI2aFBzRHlka1VCWHVCWU5Zc09ZcWtnNWpQckRMWHl1TFZ0ZjNK?= =?utf-8?B?bHkreEhJbzdEeHpEc2YzM0FLWTdpZHE1TkU5R3FDQkxEeTBRemdsN0pIS1VT?= =?utf-8?B?MWdwVkF5QS83UG5TYVg0V3l3aU5ReFdid2cvdks2ZlNEalJ6dTdLUnV0U2ty?= =?utf-8?B?cTNta2xFN1NjRjFvdVh3SUVEV0hQN2FoKzB5OERZb2JoRWQ2RHhxYlQ2MTZI?= =?utf-8?B?YlhjR2pmU1IwbDBmdWc5R3BqajlVRDhXMldsUjUvYVNNT1ZUK2Y1N2MzUWVR?= =?utf-8?B?YjlwOERmRmRiNmJGYnF6WUNxVWVSNmM4dnM1djk3bEtmOG1maGNkTVdibzh3?= =?utf-8?B?UXAyUzBuTzNLNjl6Vmp6WmwvVTFkWHdSdVdlOHJwTWtvbWVZMy95cnVkV3U1?= =?utf-8?B?bEJqWHZ2ZkwvYi9CR2V0K2k0L1dmdGFxWkNsRkkyK0dnVllLWTRrT0tCK1pu?= =?utf-8?B?aTI3MU9VNnVzcE9mWW1oSEk4bkpPOXJHMUhVcEFqTkNTWENRcVNPK05FUnE4?= =?utf-8?B?RzEyTFV2VVJDcHlnR0toV0JTaDRKcWpZbTdZeXlXbGdFTksxelEwbU9LWEdm?= =?utf-8?B?SGhxUklVSFNUMnJKdjZwRlJRTEs5NkROUUZQY2tUa1cyTERsMHhCTkM2eGNs?= =?utf-8?B?TnZ2NXl5MHVEUSsvaDRVR2VTV1dMVVE3WFY4S2xhUUdBOVRPRWpiT1JKaWUw?= =?utf-8?B?VWxaMjJycmNUVkYraE0vbkFmUzE1QjlVVVhuc2c4dk91OXdCbEhEbkpRLzFz?= =?utf-8?B?SmtONG9idjdZNk50VS9QZ0Mxc3Fvajdsayt5KzZyaG1BOWJ0THNDeE9iN0I0?= =?utf-8?B?SjZJNmdTVXhNRGFHY3JIT2NzUkVtblNHaFJJaGI3cGYxRkZzc1JrOHQ0ZGlH?= =?utf-8?B?M2dqNHd0VUJ4LzBzTGU5L1FMb0R3c3F0Ti8zQnVUVkdhREg1MURNQjRyYmlH?= =?utf-8?B?aHpHMy8xTFFtK2RoazNPTWo3dFVLSENMM3dZMHhCNzB2SENSdlZnRTdUVXk2?= =?utf-8?B?MS9oUnRoUjlZZ3lFSnVCQlVRZDlEMnB3YUFYdWNpUGNCNjd6YzVUL0NCM1Vw?= =?utf-8?B?dXhVKzliVUIyRFZyWXdGTlpBdkxqVVFvUVpwY0tnNG5zT3VUaHpFT3k4L0Za?= =?utf-8?B?dGltdkNOdzh2VWIwSU1iVEo4Q1A0NTFTcm5QcytnUVptd0Nwc3BuSzVVRkUz?= =?utf-8?B?VU1sZ0JjdWVSTU56Z0RGWVlYV2VrNTJnSWRGVHh1c3pmdGtBZUhhVE5Hekht?= =?utf-8?B?RFEzb0hRYjlkcUpHWWUvd0NTSEZJNStmWWNEUGd0RWJRMEZWZXJGcVZER2Ja?= =?utf-8?B?UTBCcWNPK2V3SEo0ZUttMFoxNnVXWDRpVDdJT1g3cnVUYVdtSWkzOTIyMFVG?= =?utf-8?B?NVdnT1JkOFV1VjltQ3JLSGJzQWFsUytEUng5T2ZrQzRrUElxOXVtU3ByQjVo?= =?utf-8?B?MTJUOUQwQ2hTTTNtbGFMKzRnODdjL09aNmZzSjNHMHhHYUVtZVJ4RDE5V2xo?= =?utf-8?B?dEIvR3BaeUJDMWJUaFdTZjVUZWpCdlp4VlJ4aFd0MUpqSS9NUnFTNldoaVpW?= =?utf-8?B?VnQwYlRwdlNEZjdqRlh1MkhGcnNkRWFYR05xL3VOSlFKVG1IZjVFa1YxUHE2?= =?utf-8?B?a1U5TEMzYzJxZ3dvbXFjT2xzc0ZqYnc1MUx4cTl6SjRsYTZlSSt3L2dmYnZM?= =?utf-8?B?M1IveVptQmt5OThmY0RKdlFqTGtzdlNzaTNvTmRaYjdMR2ZEcElDbjBWcERH?= =?utf-8?B?R0VmVUE5b09pMG9tdDFDWCs1UzF0RloyazVXN0FkUTZYWjZRNzRBTzd5MWky?= =?utf-8?B?djhYeEV2S1BTWWxDQXZhd1dMdjhsSGIwZERFd005bnMwenRMb1N3Z1VDTzNi?= =?utf-8?B?YWZadENoN3U2YjBtUE1IYmJMRmh4V2lCYXV3QlVIRkRnRnBVSVdOSXo5VkRI?= =?utf-8?B?T0txWGJESXFpbzlxS2hKTE1xS1JyclJXK0dJRkVJYWZndytJS0FhM0VrcHpL?= =?utf-8?B?d3poL3ByMGdZUCtraEpjYmE5RW14QlRUS3pmK2lhT1AycmZtZTVZS2d0U2U4?= =?utf-8?Q?zNDQ5XgpaTLiSsqNh9S3rAk=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 521ee0f6-6a1c-40c0-ccdf-08dc21a3b73d X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 14:57:01.9206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O3Xszq/RNp2501MzC2al0zQ5lCP8ls9WJ8oRSPrjN/hjFRGZeRj462EsmnlnpxixzG0Vkho/RVY2yIsoxvPS8ZiPg8OiZj1U5MD5QGDWXN4Hjtmln/YE3lJClrRhnWAX X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7638 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: L6EHcAIplEeE57M0rhlXQBLSx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JisxiJlG; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/30/2024 7:01 AM, Sami Mujawar wrote: > Hi Rebecca, >=20 > Please find my feedback inline marked [SAMI]. >=20 > I have fixed those changes in the pull request at https://github.com/tian= ocore/edk2/pull/5322 > Please let me know if you agree with the changes. Thanks. Please go ahead and merge the changes. --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114791): https://edk2.groups.io/g/devel/message/114791 Mute This Topic: https://groups.io/mt/104037319/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-