From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.47]) by mx.groups.io with SMTP id smtpd.web10.106591.1673364778544374466 for ; Tue, 10 Jan 2023 07:32:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=hec59mQW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.47, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jPgA5fF/8l/OkHcj/L89iWJhD1/q5wS39E3QQ7Pi/Zkm/B/bKP1mhdcfIvWCi15cjFXRg6emCe1HVfrXgtKWQV1pAbPPXGNZ3PfGw7WkaysKW+ewESZj99mwF9xq/Qf+0IOYjBYshD2SuplCdhujt9d9Nde7bBY5n1TbOesebL+8QC1C3kr93k010XxzEWivt/s+E+l4Qu8itnuAMJ73YsurSPuAoUiNxpu3YWV6/dCoOKRRni24gtU4Suk9bSM+L0NUrBKgA2V2bBq0AeRVcp0xOjP+EP1gW6bjQ5pCj1x26J1zjDlLxP2iKGHvycMSYCeynohdhLnXlxN0Tsxddw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYUdBUm+Q0QexIOIThj3IXE8izEAfJOICRuYhHTndV8=; b=YoTx29L0vVo2l8quyDB9iVdIzC/xYeDYd/r3W5XIK1hpJzA9N/jGpmTVD4I2O1XgfXxzqJ3AZIQpi479KxNp4W765RX4lVqK1BVP9rJC4d8I5WKMFeSfn42caB6neeh1x4r6XVZb+1rgxVjjlyClemGJrNXmCaDb82LuRvgXOV0b1xy2SQB7z2x9EArM2b6EeOhpvKhOuLa7oHqGcT4zO/1O2vKiiITnauiYv9wZO+A6frCms0CXE2WcRgCKfuEzBMtsHh/XfxJLs1w8WVgz7MagKGqOwNzenSmsehf6PXVEZvIGcNa53H4lUsy0cUXhj0l4CFql7HMxlOvvySgOfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYUdBUm+Q0QexIOIThj3IXE8izEAfJOICRuYhHTndV8=; b=hec59mQWXr7TxFtqgdqCoO5Gm02iq0iE75n3NmR2xsnxuBFrwzIv0Jz5ZQ2s9fXiINlXrC+Uo18OXApeSwrWohJalkii/5PQKp6+HXJRw2hYYrcLmWnJZdGtwXbAfFe4gAJV2u2klP0M47/Qi/gyx9UoBWeq/LqWznWtgzjkpIM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by SA0PR12MB4432.namprd12.prod.outlook.com (2603:10b6:806:98::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 15:32:56 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7%4]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 15:32:56 +0000 Message-ID: <36a3be23-8dca-f33b-f38c-30a74e3ad42d@amd.com> Date: Tue, 10 Jan 2023 09:32:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure To: devel@edk2.groups.io, ray.ni@intel.com, "ppolawsk@redhat.com" , "Kinney, Michael D" , "Zimmer, Vincent" , "Kirkendall, Garrett" Cc: "Gao, Liming" , "Liu, Zhiguang" References: <8188524e0c39ae11baf681e3ad375e4c3c284569.1669908382.git.ppolawsk@redhat.com> <8d06266a-3781-5898-6c92-6daea0895eba@redhat.com> <60a88e14-9c07-d2f4-cde1-276827a572a8@redhat.com> From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: CH0PR08CA0030.namprd08.prod.outlook.com (2603:10b6:610:33::35) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|SA0PR12MB4432:EE_ X-MS-Office365-Filtering-Correlation-Id: d3437759-4906-4d4c-0ebb-08daf31ff248 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /c8ic9vCCjIRTFnMLrNrIAEZLBaQ26ynPN77lLAoN/AezUNDs0lVHiEFxZghgFz4OJyjKa7eaSLzGKnRHWnHvoS+zyo1LLRoozHRMyYtlH2wyN7tuP9xalWR6wU3HTIsoOMFz2lxrpvY+7b/ub99aYlrQCtIW5Gx8jygyjXS2pm0eFbe2qm+//wNjx3ph78vGE0knsDCwY+USCegX98YOiyV3+13mC2/nWY/S2DaHQuqc3JkKNYelfDk3mtmkI89BZs9HaB0JRE53bekkQ7BPctI2LuZZTBikZ6MUXYWt6ySBiGrpMcmlrahVcxjjO76t+l+g2Bu0QKUVJj+ko4d59dnJlHejkyhgYdDKl9NnyB/8iZ/IWMzgDSrrwztg2yH01t/T2krS3c6jfERuFaB1i6JsZAu10lTF1JfxpqT3aq7JvPvyA1db9oCsimQgDE7rgmhz3NMSS3nWB0jrb0H2bYEAs2Wj7UgI8knfS0LpS6SpQYJllkCkkTJspwWsVGI0X50a4TcnQy+P5Sn0dSXw/HM9ciVR5E/G77jg90ty7lBug925VprvJuj6mFOZs9Ya8MGoXhckjOTlP93lQV2yxPaMJpERNF2foy6j7dj7Ut1U1gSsNRPufQoLmhS/J6ovtY1D4gLbC0AeGh3BlYQ4povItFh2oiz3Ed2MD+OVuU1Du29J7gwG0RmXfq9tYN3Pjz0YdfLUN2+T8AJ4lkU6pUCTuq74vtxi54sBc4mnIBuLY/KGX1gTls3Xp2JVjIrUzbYJ8X2cK3n0fDnvvuf/k4S08IyPm7FP6StIL2QJbE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199015)(6506007)(38100700002)(53546011)(31686004)(6666004)(2906002)(66899015)(478600001)(6486002)(966005)(2616005)(26005)(6512007)(186003)(5660300002)(316002)(83380400001)(8936002)(36756003)(86362001)(41300700001)(31696002)(8676002)(110136005)(54906003)(4326008)(66946007)(6636002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0VOQUNCTlVoS1ZYUFZyM0lCY2o2TWx0V2NwYjVPazNpRzNtbFZvSUNlRjQw?= =?utf-8?B?blVJbnBOWUtQek42cy9iNms0bTNnQjB1K1IyZ0RMd0lrZ1JjdHYxeEVvOVVH?= =?utf-8?B?NTV5amFFUkpYakN3MDIyVEh2LzRyaHVNc000MlRsZkpyMk1xV01Vb1JrVzFs?= =?utf-8?B?MXZIMFh6VjNRTUs0VlF4enA0b3Q0T05CczFQM3czaHpyZzl4bExmUmlQU1hW?= =?utf-8?B?VC8yNXRjekpzMnNkQUhBQ2NRY2NsdEs2c01qWVZNOStzd2VsZW9xOWc0N3ZD?= =?utf-8?B?Wk0ybGl1YmRZcDJJOXZlUFlnRjB4d2w5QXJ5ZG1LN2FsTlkweEROZmp6b0hv?= =?utf-8?B?bnljbmtLQVdyVTBFd0dHaEtGMGVkN01mNWl3TzNCaUxCM1FVSFlIS08rS2sw?= =?utf-8?B?M3gwUG5pWUU3OG92dmZNQ0dFMEJweDUvMmIxb2tUWGtsbU5OWlE4ZlJDcVBB?= =?utf-8?B?UDRXbnpoN3gvNStvSzNTVVZTY2JEOE0ya08zWVNXMENmUTRnY2ZIMmZxZ3N2?= =?utf-8?B?c0hvSGlwMTQ2UHlrTzRlUE5jbXF4eWp5ZzlUZHFFT3QxOGsyY3FOMmpKT0px?= =?utf-8?B?aEtLV2JtMW1lU201YWNjWGl5UUlsdzRWMVF3a3VpOVJtQ0RLL0RZMml1L3Nr?= =?utf-8?B?dVE3OWRFMFpsS2pKWDBBdE1McldkSVFqQkFIUFV1WDIzYlhUUFJuY0ZxWGpi?= =?utf-8?B?VTNqYWlxcG95QlVDbmRNY25NODRMVTdmQkU0a3dFSHk4d3QrMTl3ZE1IdmN4?= =?utf-8?B?VnhBOVFDdVpwdTl2Vm1XM1IxckJuZ3kvQ2hGVHBtUHg4QW5TemhEMmVOcGNz?= =?utf-8?B?b1plemlscXVYN3ZJcEkxRldjc054dStNQzFLeHMycG1YR3pheHNGbVkwOEdo?= =?utf-8?B?d3h0YkRKUERSVndQR3Y3NGpvZWlwN2hnZHNQUW5oUFp6dVV2YzRKUXN4TVhV?= =?utf-8?B?MXpEQ1EvWlNMT1c1azBMeGIxbVR6MmJ1R2hYa3I3SlVBdzdwOGsvdHhxOEZF?= =?utf-8?B?dStmcmVhWTNvRGlDQWZsYlZJQVJiOFd5MlZUaWRPVnBZb2h6NWZXL0ZwT1hF?= =?utf-8?B?NnJjRzNibW1LemMyeHRHTCtJSVRPQVRTUkVjYjUzU3I0aVQ2eDAxSm5nci9M?= =?utf-8?B?QnM3YXRxSENWekxqKzh6SE5rbmtSbnoycDhXYTl2TXQ3MWkyTmdMeldyaWUv?= =?utf-8?B?SE1ERm9UZ2tSQXFrMk1NL3loYWQ0bEZKbHN5aCs5R2xGNzhOUHI5akc1eGZ5?= =?utf-8?B?TTQ5cnNXWmt1aXdrT2txUjB6RW1BdWRtUTQvWWRSbmsvMm1zY0ppYzR6Zyts?= =?utf-8?B?L0NTc0VZRjU0TTVyeHFyRm95ZkpUbUI1bE9ScUhDMVFFajdWYWUxZ3ZvU3I0?= =?utf-8?B?eHJuMkE2R0lzdGN2SnQ5UlJoTzdvVDNjMnZaV1N2Wk14N3B6RTg1K1kzVzVT?= =?utf-8?B?bkdCZFVva0VFZTY2d0hOVFdFOWxKeFV2RmFaMHkzaWhLVU5HM0VyMVdVaGZK?= =?utf-8?B?aUlUY2JnVmdYVG1aeTlwSlVHaDQvWFVWOVpxMi95WGlLTXVTYU9oTDZYeEd4?= =?utf-8?B?S1YvL0F0R0pjdkRHL1lScDRmMWhSbk93VWZvZ3pNelczYko0ZHFZQkRMaW5J?= =?utf-8?B?YWh6QTZUckNmdldoaHYxbXA3blFTTS8vWndreGk0U0hJQ2NXRzJqV1BITmVM?= =?utf-8?B?d3h0bkFJeVpSRHd4OGh6MXBIYWFFRzhoeHFQOG9KMDFsZEN1MjIvK00wZGd2?= =?utf-8?B?dE0rcW93amlpQlp1RWQvNTdDbVNrd2hBNGJ6S3VBcW5vUTE3dEFqWEtkeUpt?= =?utf-8?B?cU4wSHJPT1B6d0FySFZLUHBjeXZLajFESDhlaFIxdHBpdkNuV3E3bU5UWm9m?= =?utf-8?B?TnBWM3p5YXlFekp5blZCWCtPRUZMQkxnMVp0QjJoa0dVbXYzR0pUSkpCczJT?= =?utf-8?B?NloveDgxUUVZYnV0alRwMTBnN2IyTGdLWUpEc1MrL1VkY1RJT1ZzNDFSRlNm?= =?utf-8?B?UWJsVWdIa0RXYTQyVmVkMGptRTZxcnlHU3lQa2dwVUEvVGxiUnd3K1dLa1NT?= =?utf-8?B?NzlHK3J3SENJbHcrdEMwcGwzMVhPNkxBc1E4eHRLc2pXQ2pNYnJkZEVmTW5r?= =?utf-8?Q?RZbv1Areu/zo9TY9BHjvA7KkL?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3437759-4906-4d4c-0ebb-08daf31ff248 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 15:32:56.1940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qJq7LngbpR+E2DxWLIdplOXsBJv9K8EK8A5c5I8d8xwq541y9Ro61/sEcs8xPul4jwhOhiLFT5XMWhtlZ9fKxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4432 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit + Garret On 1/10/23 03:36, Ni, Ray via groups.io wrote: >>>>> The challenge is that the non-Itanium CPU archs that may depend on the >>>>> current binary layout of these structures. This could be a binary >>>>> PEI CPU module, DXE CPU module, SMM CPU module, MM CPU modules, >>>>> UEFI App/Shell App that use the PPI or HOB. > > The CPU health record is stored in PPI first by SecCore, then saved to HOB by CpuMpPei module. > Then CpuDxe gets the record from HOB. > > If SecCore, CpuMpPei, CpuDxe are built with different structure definition, > the compatibility issue appears. > > The very well know binary separation module today for x86 is Intel's FSP. > I am not sure if today customer might use a pre-built FSP binary which is built from > version #1 of edk2 while the SecCore and CpuDxe in platform binary are built from > a different version of edk2. > I don't know how AMD distributes the binary module. + Tom > > If binary distribution is not adopted yet by industry, I prefer we just update the > structure definition. > >>>>> >>>>> Even if we define a new HOB format, we have to decide when it is >>>>> used to support compatibility. Perhaps always keep the current >>>>> logic if < 1024 CPUs. If number of CPUs >= 1024, then produce >>>>> the new format of CPU information and update all consumers to >>>>> look for new format and use that with higher priority than the >>>>> old format. > > I don't like this approach because it still breaks the case when CPU >=1024 and binary > distribution is used. > >>>>> >>>>> Another option is to keep the current format and allow multiple >>>>> HOBs to be produced if the CPU information does not fit in the >>>>> single HOB size limit of 64KB. Then update all consumers to >>>>> look for 1 or more HOBs to collect all the information. This >>>>> approach removes the CPU number limit as long as there is enough >>>>> temp RAM for the multiple HOBs. > > CpuDxe driver is one of the consumers. > 1. Old CpuMpPei (in FSP binary) + new CpuDxe (In Platform binary) > This doesn't work because CpuMpPei still cannot produce the huge-size HOB. > 2. New CpuMpPei (in FSP binary) + old CpuDxe (In Platform binary) > This doesn't work because old CpuDxe doesn't look for multiple HOBs. > > > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Pawel Polawski >> Sent: Tuesday, January 10, 2023 4:19 PM >> To: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D ; Zimmer, Vincent >> >> Cc: Gao, Liming ; Liu, Zhiguang >> Subject: Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure >> >> Hi everyone, >> >> If there is a chance you have some evaluation about this problem already? >> >> Best regards, >> Pawel >> > > > > > >