From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E7364211B739C for ; Tue, 15 Jan 2019 01:33:53 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DC817CDE4; Tue, 15 Jan 2019 09:33:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-50.rdu2.redhat.com [10.10.120.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E7815D779; Tue, 15 Jan 2019 09:33:50 +0000 (UTC) To: Star Zeng , edk2-devel@lists.01.org Cc: Hao Wu , Ray Ni , Liming Gao , Michael D Kinney , Ard Biesheuvel References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-9-git-send-email-star.zeng@intel.com> From: Laszlo Ersek Message-ID: <36a8201d-afdf-cc61-d824-56373ce35f9f@redhat.com> Date: Tue, 15 Jan 2019 10:33:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1547479196-40248-9-git-send-email-star.zeng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 15 Jan 2019 09:33:52 +0000 (UTC) Subject: Re: [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 09:33:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/14/19 16:19, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > Add emulated variable NV mode support in real variable driver. > Platform can configure PcdEmuVariableNvModeEnable statically > (build time) or dynamically (boot time) to support emulated > variable NV mode. > > Then EmuVariableRuntimeDxe could be removed, the removal of > EmuVariableRuntimeDxe will be done after platforms are migrated > to use the merged variable driver. > > Cc: Jian J Wang > Cc: Hao Wu > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > .../Universal/Variable/RuntimeDxe/Variable.c | 318 +++++++++++++++------ > .../Universal/Variable/RuntimeDxe/Variable.h | 1 + > .../Universal/Variable/RuntimeDxe/VariableDxe.c | 27 +- > .../Variable/RuntimeDxe/VariableRuntimeDxe.inf | 4 +- > .../Universal/Variable/RuntimeDxe/VariableSmm.c | 29 +- > .../Universal/Variable/RuntimeDxe/VariableSmm.inf | 4 +- > 6 files changed, 271 insertions(+), 112 deletions(-) Acked-by: Laszlo Ersek (I think that this work and Ard's standalone MM refactoring will conflict. If that's the case then I guess one of the patch sets should be rebased. I seem to recall that this was already discussed on the list.) Thanks, Laszlo