Re: [edk2-non-osi][PATCH 1/1] Platform/RPi/TrustedFirmware: Update TF-A binaries to v2.3 release

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 4/21/20 2:29 PM, Pete Batard wrote:
> Hi Ard,
> 
> On 2020.04.21 13:20, Ard Biesheuvel wrote:
>> On 4/21/20 1:29 PM, Pete Batard wrote:
>>> With the v2.3 release of TF-A, that integrates automatic PL011 vs 
>>> miniUART
>>> switching, we can remove the dual bl31 binaries we were using for RPi4,
>>> and of course, we also take this opportunity to update the RPi3 binaries
>>> to the latest.
>>>
>>> Note that these binaries were built in an open and verifiable manner
>>> through an AppVeyor build script (https://github.com/pbatard/pitf).
>>>
>>> Signed-off-by: Pete Batard <pete@akeo.ie>
>>> ---
>>>   Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md         |  16 
>>> ++++++++--------
>>>   Platform/RaspberryPi/RPi3/TrustedFirmware/bl1.bin           | Bin 
>>> 18776 -> 18837 bytes
>>>   Platform/RaspberryPi/RPi3/TrustedFirmware/fip.bin           | Bin 
>>> 45792 -> 53972 bytes
>>>   Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md         |  16 
>>> ++++++++++------
>>>   Platform/RaspberryPi/RPi4/TrustedFirmware/bl31.bin          | Bin 0 
>>> -> 41067 bytes
>>>   Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_miniuart.bin | Bin 
>>> 41072 -> 0 bytes
>>>   Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_pl011.bin    | Bin 
>>> 41072 -> 0 bytes
>>>   7 files changed, 18 insertions(+), 14 deletions(-)
>>>
>>
>> I gave these a spin, and my RPi3 isn't booting. I then went back to 
>> your v1.21 release, and it doesn't boot either. Log of my DEBUG build 
>> below - any thoughts?
> 
> You may need an updated start.elf (along with bootcode.bin, which needs 
> to match the release date of start/elf).
> 
> What happens if you pick the files from 
> https://github.com/pftf/RPi3/releases and just replace your RPI_EFI.fd?
> 

I took the entire .zip and dumped it into the /boot partition, which 
already had a bunch of files there.

I just did the same again, but after deleting all files (but without 
reformatting) and now it boots fine. So I am going to assume this is an 
issue in the FAT driver in the Pi firmware.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 17f0712c484b..96ec764b947c


> For the record, I did test the patches I sent in just that manner, 
> applied on top of latest platforms/non-osi, for both Pi3 and Pi4 (with 
> and without PL011 overlay) and didn't see any ASSERT.
>