From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.7826.1587473523442129225 for ; Tue, 21 Apr 2020 05:52:03 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 08F5331B; Tue, 21 Apr 2020 05:52:03 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 138FF3F68F; Tue, 21 Apr 2020 05:52:01 -0700 (PDT) Subject: Re: [edk2-non-osi][PATCH 1/1] Platform/RPi/TrustedFirmware: Update TF-A binaries to v2.3 release To: Pete Batard , devel@edk2.groups.io Cc: leif@nuviainc.com, awarkentin@vmware.com References: <20200421112931.11752-1-pete@akeo.ie> <9bcf3dcc-71a3-49c8-5a88-ea2d5a11432d@arm.com> <538f4820-19a0-f483-37d8-805af415702f@akeo.ie> From: "Ard Biesheuvel" Message-ID: <36b16aec-8f78-9aeb-449c-30c99ee75611@arm.com> Date: Tue, 21 Apr 2020 14:52:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <538f4820-19a0-f483-37d8-805af415702f@akeo.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/21/20 2:29 PM, Pete Batard wrote: > Hi Ard, >=20 > On 2020.04.21 13:20, Ard Biesheuvel wrote: >> On 4/21/20 1:29 PM, Pete Batard wrote: >>> With the v2.3 release of TF-A, that integrates automatic PL011 vs=20 >>> miniUART >>> switching, we can remove the dual bl31 binaries we were using for RPi= 4, >>> and of course, we also take this opportunity to update the RPi3 binar= ies >>> to the latest. >>> >>> Note that these binaries were built in an open and verifiable manner >>> through an AppVeyor build script (https://github.com/pbatard/pitf). >>> >>> Signed-off-by: Pete Batard >>> --- >>> =C2=A0 Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 16=20 >>> ++++++++-------- >>> =C2=A0 Platform/RaspberryPi/RPi3/TrustedFirmware/bl1.bin=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | Bin=20 >>> 18776 -> 18837 bytes >>> =C2=A0 Platform/RaspberryPi/RPi3/TrustedFirmware/fip.bin=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | Bin=20 >>> 45792 -> 53972 bytes >>> =C2=A0 Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 16=20 >>> ++++++++++------ >>> =C2=A0 Platform/RaspberryPi/RPi4/TrustedFirmware/bl31.bin=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | Bin 0=20 >>> -> 41067 bytes >>> =C2=A0 Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_miniuart.bin | = Bin=20 >>> 41072 -> 0 bytes >>> =C2=A0 Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_pl011.bin=C2=A0= =C2=A0=C2=A0 | Bin=20 >>> 41072 -> 0 bytes >>> =C2=A0 7 files changed, 18 insertions(+), 14 deletions(-) >>> >> >> I gave these a spin, and my RPi3 isn't booting. I then went back to=20 >> your v1.21 release, and it doesn't boot either. Log of my DEBUG build=20 >> below - any thoughts? >=20 > You may need an updated start.elf (along with bootcode.bin, which needs= =20 > to match the release date of start/elf). >=20 > What happens if you pick the files from=20 > https://github.com/pftf/RPi3/releases and just replace your RPI_EFI.fd? >=20 I took the entire .zip and dumped it into the /boot partition, which=20 already had a bunch of files there. I just did the same again, but after deleting all files (but without=20 reformatting) and now it boots fine. So I am going to assume this is an=20 issue in the FAT driver in the Pi firmware. Reviewed-by: Ard Biesheuvel Pushed as 17f0712c484b..96ec764b947c > For the record, I did test the patches I sent in just that manner,=20 > applied on top of latest platforms/non-osi, for both Pi3 and Pi4 (with=20 > and without PL011 overlay) and didn't see any ASSERT. >=20