From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 22 May 2019 02:11:15 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CCF04308339A; Wed, 22 May 2019 09:11:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-230.rdu2.redhat.com [10.10.120.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F59828556; Wed, 22 May 2019 09:11:04 +0000 (UTC) Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules To: "Gao, Liming" , "Wu, Hao A" , "devel@edk2.groups.io" Cc: "leif.lindholm@linaro.org" , "Kinney, Michael D" , "afish@apple.com" References: <20190521152152.5868-1-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E44F390@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <36bf48fa-64ef-34b9-ba03-491882524764@redhat.com> Date: Wed, 22 May 2019 11:11:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44F390@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 22 May 2019 09:11:06 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/22/19 03:50, Gao, Liming wrote: > This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. I'm not sure I'm convinced -- if this patch is not applied, what precisely is the functionality that breaks? What are the symptoms? Either way, I'll let the other stewards decide about this. Thanks Laszlo > This change is to remove the duplicated one. > > Thanks > Liming >> -----Original Message----- >> From: Wu, Hao A >> Sent: Wednesday, May 22, 2019 9:44 AM >> To: devel@edk2.groups.io; Gao, Liming >> Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules >> >>> -----Original Message----- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> Liming Gao >>> Sent: Tuesday, May 21, 2019 11:22 PM >>> To: devel@edk2.groups.io >>> Cc: Wu, Hao A >>> Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc >>> to remove Network related modules >>> >>> Network related modules have been included in NetworkPkg.dsc. >>> They can be removed from MdeModulePkg.dsc. >>> >>> Signed-off-by: Liming Gao >>> Cc: Hao A Wu >>> --- >>> MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- >>> 1 file changed, 19 deletions(-) >>> >>> diff --git a/MdeModulePkg/MdeModulePkg.dsc >>> b/MdeModulePkg/MdeModulePkg.dsc >>> index ac7111dea1..995fd805e1 100644 >>> --- a/MdeModulePkg/MdeModulePkg.dsc >>> +++ b/MdeModulePkg/MdeModulePkg.dsc >>> @@ -63,11 +63,6 @@ >>> # >>> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf >>> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf >>> - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf >>> - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf >>> - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf >>> - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf >>> >>> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL >>> ib/DxeSecurityManagementLib.inf >>> >>> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem >>> plate.inf >>> >>> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in >>> f >>> @@ -263,12 +258,8 @@ >>> >>> MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo >>> cationProfileLib.inf >>> >>> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i >>> nf >>> >>> MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided >>> SectionExtractLib.inf >>> - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf >>> - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf >>> - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf >>> MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf >>> MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf >>> - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf >>> >>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco >>> l.inf >>> >>> MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS >>> ectionExtractLib.inf >>> MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf >>> @@ -357,16 +348,6 @@ >>> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf >>> >>> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement >>> Dxe.inf >>> >>> - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf >>> - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf >>> - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf >>> - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf >>> - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf >>> - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf >>> - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf >>> - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf >>> - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf >>> - >> >> Reviewed-by: Hao A Wu >> I will let the stewards to decide whether this can be pushed at this moment. >> >> Best Regards, >> Hao Wu >> >>> >>> MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen >>> tPciCfg2Pei.inf >>> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >>> MdeModulePkg/Universal/PCD/Pei/Pcd.inf >>> -- >>> 2.13.0.windows.1 >>> >>> >>> >