From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.34.1616089880752357336 for ; Thu, 18 Mar 2021 10:51:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=daWXGANA; spf=pass (domain: gmail.com, ip: 209.85.210.173, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f173.google.com with SMTP id y5so4009552pfn.1 for ; Thu, 18 Mar 2021 10:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=o6MOHzmbvQQIA6LekoAQejIx1AhnL6k3djWj+p1xxBk=; b=daWXGANA0ymidq8xcB2B2cew0LAm+C3mUpdDWhh9aUrnd2/H/vS1pYRBObkcfUYy2s DSNUvkA/CVcnmVJ5RVZQ+/BAKIqmGWxMYLDd0GkqJIS+Lucc4vtPKwj6fjG5ZRe8jxgO qrxXggUZVh7UzDm6NPHTZiYhx/e3JZs10+fY+eADnJTDV/533df5LH99fQzieRDBIpAY kPnqXgzer0QtYMAOhUJiiAQ6fchBuAlLHbWIWXgVQqo+aHuw9okAHFoiT0eg/C/LvfZm Y8P5iQFwnHDEQoqjVSboksOLgzU1XWoKa+63UkASSKZl3K/c2jhTlKryqIcfeXlGJ9H4 BtPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o6MOHzmbvQQIA6LekoAQejIx1AhnL6k3djWj+p1xxBk=; b=CYYi7BvItX6+fcJI9kkhhVscgv0Ou62kmRVBXFfGK0PhthyPGUbm1sstT0ZZ9WOZ/g POj+J6m1ByuvnjBP+glWameI281hupnGr6kC/dyP9hNUGg3hrO7I23q4UzFQUeyRkdp1 NxnAHwapZ8XWPfNOVjI7vYsFz8ozFbCADhElTo7GkaMtcjWo5DYgZcc+KFA4Cg/MVrqP s3anSgEL3DBRm/7hNO7V4owCw0E3iNQwywi2Kobyr+EAE+gBP+mcVsoi87sZHvS2jzAy eZ4I2+dYCs3KC/AeIY4Ku4KsO80imM+ICuCY30bCs47lNX+guX2oAgTpdYQ9qw3l3wW+ 6P+A== X-Gm-Message-State: AOAM531wyUUOMFVg/AqfxnYGvk0HZaNmnuxZzRXwpf4iott1/YIh49PK 8gB+QMnB7rKt0+fpMzEL5qI= X-Google-Smtp-Source: ABdhPJz710pbDeTM/HJkBVAhaE5J1nAVzqDZ9M3IvQRWXi3rW76tHX9sc5nsvXQgTTuEDhlbbJRm9g== X-Received: by 2002:a62:e10f:0:b029:1f5:42b6:7113 with SMTP id q15-20020a62e10f0000b02901f542b67113mr5230666pfh.63.1616089876821; Thu, 18 Mar 2021 10:51:16 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id 9sm2741671pgy.79.2021.03.18.10.51.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 10:51:16 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe To: devel@edk2.groups.io, Michael D Kinney , Yi Qian , Zailiang Sun References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5170DFC6296.20382@groups.io> From: "Kun Qin" Message-ID: <36c3115a-ba2a-4bb5-745b-d42dd2046a70@gmail.com> Date: Thu, 18 Mar 2021 10:51:14 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <166CE5170DFC6296.20382@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Michael, Could you please review this change and provide feedback? Zailing would prefer to have your vote before finalizing the change. Any input is appreciated. Regards, Kun On 03/16/2021 11:10, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > > This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc > file to resolve new dependency by VariableSmmRuntimeDxe. The library > interface is consumed by variable module to better support variable > runtime cache feature. > > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael D Kinney > > Signed-off-by: Kun Qin > --- > > Notes: > v2: > - Added Michael K. to cc list [Zailiang] > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 409f31c982d7..33e93b74800c 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -311,6 +311,7 @@ [LibraryClasses.IA32] > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf > EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > [LibraryClasses.IA32.DXE_DRIVER] > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 38bd825c8bdc..f7a876353649 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -313,6 +313,7 @@ [LibraryClasses.X64] > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf > EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > [LibraryClasses.X64.DXE_DRIVER] > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf >