From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Bret Barkelew <Bret.Barkelew@microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Bret Barkelew <debtech@gmail.com>
Cc: Bret Barkelew <bret@corthon.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Dandan Bi <dandan.bi@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Hao A Wu <hao.a.wu@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>, Andrew Fish <afish@apple.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [EXTERNAL] Re: [PATCH v9 00/13] Add the VariablePolicy feature
Date: Thu, 19 Nov 2020 17:35:27 +0100 [thread overview]
Message-ID: <36cc776e-172d-de03-2378-23f4564ed8f0@arm.com> (raw)
In-Reply-To: <MW4PR21MB1955740891F8C7F58D1E54EBEFE00@MW4PR21MB1955.namprd21.prod.outlook.com>
On 11/19/20 5:26 PM, Bret Barkelew wrote:
> I should clarify that it wasn’t an official process. It was just a
> suggestion that reached some consensus.
>
Fair enough. I haven't been as active on the mailing list recently, so I
may have missed some of this.
I was just slightly shocked that every single platform got broken by
this change.
> ------------------------------------------------------------------------
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Bret
> Barkelew via groups.io <bret.barkelew=microsoft.com@groups.io>
> *Sent:* Thursday, November 19, 2020 8:23:45 AM
> *To:* Ard Biesheuvel <ard.biesheuvel@arm.com>; Bret Barkelew
> <debtech@gmail.com>
> *Cc:* Bret Barkelew <bret@corthon.com>; devel@edk2.groups.io
> <devel@edk2.groups.io>; Yao, Jiewen <jiewen.yao@intel.com>; Dandan Bi
> <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
> <hao.a.wu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Jordan
> Justen <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> *Subject:* Re: [edk2-devel] [EXTERNAL] Re: [PATCH v9 00/13] Add the
> VariablePolicy feature
> I followed the process that was agreed upon in this list: I opened bugs
> to every platform maintainer with explicit details of what needed to be
> changed and waited a full month before making any further progress with
> the main patches (adding a month to the completion time).
>
> I’m wrapping things up to take a vacation next week, but if there are
> still problems when I return, I can probably contribute to one or two
> platforms.
>
> - Bret
> ------------------------------------------------------------------------
> *From:* Ard Biesheuvel <ard.biesheuvel@arm.com>
> *Sent:* Thursday, November 19, 2020 8:19:37 AM
> *To:* Bret Barkelew <debtech@gmail.com>
> *Cc:* Bret Barkelew <bret@corthon.com>; devel@edk2.groups.io
> <devel@edk2.groups.io>; Yao, Jiewen <jiewen.yao@intel.com>; Dandan Bi
> <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
> <hao.a.wu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Jordan
> Justen <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> *Subject:* [EXTERNAL] Re: [PATCH v9 00/13] Add the VariablePolicy feature
> On 11/19/20 5:15 PM, Bret Barkelew wrote:
>> Those bugs and recommendations were sent out months ago. Several platforms have staged the changes already.
>>
>> You need to add the library class to your DSC.
>>
>
> I know it has been painful to get these changes in, and I am glad that
> you stuck with it. But that does not make it OK to simply break every
> platform in edk2-platforms/ and not take any responsibility whatsoever
> for fixing it. If it is such a trivial fix, why didn't you fix it yourself?
>
>
next prev parent reply other threads:[~2020-11-19 16:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 6:45 [PATCH v9 00/13] Add the VariablePolicy feature Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 01/13] MdeModulePkg: Define the VariablePolicy protocol interface Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 02/13] MdeModulePkg: Define the VariablePolicyLib Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 03/13] MdeModulePkg: Define the VariablePolicyHelperLib Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 04/13] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 05/13] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 06/13] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 07/13] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 08/13] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 09/13] MdeModulePkg: Connect VariablePolicy business logic to VariableServices Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 10/13] MdeModulePkg: Allow VariablePolicy state to delete protected variables Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 11/13] SecurityPkg: Allow VariablePolicy state to delete authenticated variables Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 12/13] MdeModulePkg: Change TCG MOR variables to use VariablePolicy Bret Barkelew
2020-11-09 6:45 ` [PATCH v9 13/13] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver Bret Barkelew
2020-11-11 18:43 ` [PATCH v9 00/13] Add the VariablePolicy feature Bret Barkelew
2020-11-11 22:34 ` [edk2-devel] " Laszlo Ersek
2020-11-12 14:24 ` 回复: " gaoliming
2020-11-12 16:45 ` Bret Barkelew
2020-11-13 1:20 ` Bret Barkelew
2020-11-13 2:05 ` 回复: " gaoliming
2020-11-13 19:59 ` Laszlo Ersek
[not found] ` <1646EF0A6B8F843A.414@groups.io>
2020-11-17 1:00 ` gaoliming
2020-11-19 12:46 ` Ard Biesheuvel
2020-11-19 16:15 ` Bret Barkelew
2020-11-19 16:19 ` Ard Biesheuvel
2020-11-19 16:23 ` [EXTERNAL] " Bret Barkelew
[not found] ` <1648F558ACA0C0F8.8629@groups.io>
2020-11-19 16:26 ` [edk2-devel] " Bret Barkelew
2020-11-19 16:35 ` Ard Biesheuvel [this message]
2020-11-20 10:34 ` Laszlo Ersek
2020-11-19 20:02 ` [edk2-devel] " Andrei Warkentin
2020-11-19 20:16 ` Michael Kubacki
2020-11-19 20:41 ` Bret Barkelew
2020-11-20 10:53 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36cc776e-172d-de03-2378-23f4564ed8f0@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox