From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.13006.1575908791515642936 for ; Mon, 09 Dec 2019 08:26:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JLDXGv07; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575908790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=66nrW2saWwqf/DgwdkDb/AMnlilxPGv0qu65dLHccNI=; b=JLDXGv070+A08yZU+AU5dRZQ6iNjuV61omY+6RIU2MBpow9ELXG0fUwego4TSp56NfhpXr cxLBf9dryj0V/yPD0t9aiv2DFxq3lQDx/P03xdjOYjsRRcJLYXodFFqlydhYeAxRC7T9HB +BStjm0F2aT1m/1y7EdxEGp4peob3wQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-REr3l_u4MN-IS6P-1uVvhg-1; Mon, 09 Dec 2019 11:26:29 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E80C100A163; Mon, 9 Dec 2019 16:26:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6B8A1001901; Mon, 9 Dec 2019 16:26:24 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 085/105] .mailmap: Add an entry for Songpeng Li To: devel@edk2.groups.io, aaron.li@intel.com, Philippe Mathieu-Daude References: <20191206112638.23175-1-philmd@redhat.com> <20191206112638.23175-86-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: <36fdff35-1571-3711-58dc-54afc3a491e2@redhat.com> Date: Mon, 9 Dec 2019 17:26:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: REr3l_u4MN-IS6P-1uVvhg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Aaron, On 12/09/19 02:51, Li, Aaron wrote: > Reviewed-by: Songpeng Li > > Also, my name is changed to Aaron Li > You can also add this name to the list, thanks. which one is the "authoritative" first name that you would like to use in edk2 context? For example, if you sent a patch tomorrow, would it come from - Aaron Li or - Songpeng Li ? The idea of the mailmap file is that we establish a "canonical" and "live" {name, email-address} pair for each contributor, and map everything else that has stood for the same contributor in the past to the canonical pair. (We have to be careful with cross-domain mappings, such as cross-employer mappings -- which is why every contributor is asked to R-b such changes, from their current (hence canonical) address.) In fact your present email contains R-b from "Songpeng" in the body, but the "From:" header on your email says "Aaron". So I would suggest that Phil capture "Aaron" as your canonical name, and map "Songpeng" to it. Then we'd ask you to R-b that patch from your "Aaron" address. Does that make sense? Thanks, Laszlo >> -----Original Message----- >> From: Philippe Mathieu-Daude >> Sent: Friday, December 6, 2019 7:26 PM >> To: devel@edk2.groups.io >> Cc: Philippe Mathieu-Daude ; Li, Aaron >> >> Subject: [PATCH v2 085/105] .mailmap: Add an entry for Songpeng Li >> >> We use .mailmap to display contributors email addresses in an >> uniform format. >> >> Add an entry for Songpeng Li to have his name and email address >> displayed properly in the git history. >> >> Cc: Songpeng Li >> Signed-off-by: Philippe Mathieu-Daude >> --- >> [Due to MTA restricting the recipient list to 100, I can not Cc all the >> named developers in the cover. Therefore I'm adapting the explaination >> from the cover in each patch] >> >> This patch won't get merged if Songpeng Li doesn't give his >> approval, by replying to this patch with: >> Reviewed-by: Songpeng Li >> >> If you think this patch is inappropriate, you don't need to justify, >> reply with: >> NAcked-by: Songpeng Li >> or simply: >> NACK >> >> If your Firstname Lastname order is incorrect, tell me and I will fix it. >> >> You can also ignore this mail, but I might resend it and keep bothering >> you. >> >> Regards, >> >> Phil. >> --- >> .mailmap | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/.mailmap b/.mailmap >> index faafd9614e42..20610fcf221d 100644 >> --- a/.mailmap >> +++ b/.mailmap >> @@ -165,3 +165,4 @@ Siyuan Fu >> Siyuan Fu > (x86)/Git/o=Intel/ou=Exchange Administrative Group >> (FYDIBOHF23SPDLT)/cn=Recipients/cn=sfu5> >> Siyuan Fu > 765794883524> >> Siyuan Fu >> +Songpeng Li >> -- >> 2.21.0 > > > >