From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id C024B210E3DDD
 for <edk2-devel@lists.01.org>; Thu,  9 Aug 2018 07:12:37 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 0A9D37B2B1;
 Thu,  9 Aug 2018 14:12:37 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-52.rdu2.redhat.com
 [10.10.121.52])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 58BE9112D171;
 Thu,  9 Aug 2018 14:12:36 +0000 (UTC)
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>, Star Zeng <star.zeng@intel.com>
References: <20180808084712.34696-1-shenglei.zhang@intel.com>
 <20180808084712.34696-22-shenglei.zhang@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <370ef43e-7b68-822e-8d69-6f04d1c403a5@redhat.com>
Date: Thu, 9 Aug 2018 16:12:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180808084712.34696-22-shenglei.zhang@intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.1]); Thu, 09 Aug 2018 14:12:37 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]);
 Thu, 09 Aug 2018 14:12:37 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2018 14:12:38 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/08/18 10:47, shenglei wrote:
> The function UnicodeFiFoGetKeyCount that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
>  .../Universal/Console/TerminalDxe/Terminal.h  | 12 ---------
>  .../Console/TerminalDxe/TerminalConIn.c       | 25 -------------------
>  2 files changed, 37 deletions(-)

With the typo in the commit message ("calld") fixed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>