From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.203299.1673976479309468619
 for <devel@edk2.groups.io>;
 Tue, 17 Jan 2023 09:27:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=WSWglwro;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id CD81020DFE9E;
	Tue, 17 Jan 2023 09:27:56 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CD81020DFE9E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1673976478;
	bh=ElDzW2PUWCypKk7TvwgEFlZMp0xbFOFe1mHqLCLm1vs=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=WSWglwroB2kYkuXCbjJdhvSPBhK6oHk8ubZTTErBAuNQUx+9RBw7Eud5WCp2qkv00
	 ItBxbzydpUftOqEKVprU6FX2oV5SeLF4wiK5TMMfipJS2Vp6E4qCa5GHDcivo392fp
	 ltv526ZiY+WlMpIXLsq1GLWn/GaZqlaAE/OIVd0w=
Message-ID: <372deac5-bcdd-62f8-d7ab-c1ca441b8f55@linux.microsoft.com>
Date: Tue, 17 Jan 2023 12:27:55 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v11 08/17] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)
To: Oliver Steffen <osteffen@redhat.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Bob Feng <bob.c.feng@intel.com>,
 Dandan Bi <dandan.bi@intel.com>, Gerd Hoffmann <kraxel@redhat.com>,
 Jian J Wang <jian.j.wang@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Sean Brogan
 <sean.brogan@microsoft.com>, Yuwei Chen <yuwei.chen@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, chris.fernald@outlook.com
References: <20230116174044.3346383-1-osteffen@redhat.com>
 <20230116174044.3346383-9-osteffen@redhat.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230116174044.3346383-9-osteffen@redhat.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 1/16/2023 12:40 PM, Oliver Steffen wrote:
> Run the Linux jobs of the ArmVirtPkg platform CI inside a container,
> in the same way the general CI does now. Make use of the default image
> specified in the defaults.yml template.
> 
> Do not run apt-get in CI jobs to install qemu and gcc dependencies.
> Assume the container image provides these.
> 
> Use Python from the container image, do not download at runtime.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 5a0e589ed4a7..c0a2e0f20d4f 100644
> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -78,6 +78,8 @@ jobs:
>       pool:
>         vmImage: $(vm_image)
>   
> +    container: ${{ variables.default_linux_image }}
> +
>       steps:
>       - template: ../../../.azurepipelines/templates/platform-build-run-steps.yml
>         parameters:
> @@ -88,8 +90,4 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> -        usePythonVersion: ${{ variables.default_python_version }}
> -        extra_install_step:
> -        - bash: sudo apt-get install qemu
> -          displayName: Install qemu
> -          condition: and(gt(variables.pkg_count, 0), succeeded())
> +        usePythonVersion: '' # use Python from the container image