From: "Alexander Graf" <graf@amazon.com>
To: <devel@edk2.groups.io>, <lersek@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
Hendrik Borghorst <hborghor@amazon.de>
Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Allow to force runtime allocations at separate range
Date: Fri, 19 Feb 2021 18:31:29 +0100 [thread overview]
Message-ID: <375f989a-5c6f-0986-99d3-8a232751f82e@amazon.com> (raw)
In-Reply-To: <51844c5a-aedf-9a0a-10e5-7a06b2073a8c@redhat.com>
Hey Laszlo,
On 19.02.21 17:47, Laszlo Ersek wrote:
>
> Hello Alex,
>
> On 02/19/21 15:10, Alexander Graf wrote:
>> Hi Mike,
>>
>> Thanks a lot for the pointer! In my case, the defaults for the
>> preallocated memory regions was just not big enough to prevent
>> hibernation breakage. I increased them now as intended and everything
>> works like a charm.
>
> The most recent related OVMF commits are, for reference (merged on 2020-May-08):
>
> 1 2c06e76bba06 OvmfPkg/PlatformPei: don't track BS Code/Data in default MemTypeInfo HOB
> 2 356b96b3a2dc OvmfPkg/PlatformPei: rewrite MemTypeInfo HOB production logic
> 3 8db87f98357b OvmfPkg/PlatformPei: extract memory type info defaults to PCDs
> 4 7b6327ff03bb OvmfPkg/PlatformPei: increase memory type info defaults
>
> The commit messages hopefully explain how OVMF utilizes the pattern described by Mike, and what PCDs to tweak if you need larger bins.
>
> If you think your PCD updates are upstreamable, please feel free to submit those as a patch!
In a nutshell, I was missing 7b6327ff03bb. So unfortunately nothing
upstreamable this time around - you beat me to it and I was just
suffering from running UDK2018 ;)
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2021-02-19 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 20:09 [PATCH 0/2] Improve hibernation safety Alexander Graf
2021-02-18 20:09 ` [PATCH 1/2] MdeModulePkg/Core/Dxe: Allow to force runtime allocations at separate range Alexander Graf
2021-02-18 22:28 ` [edk2-devel] " Michael D Kinney
2021-02-19 14:10 ` Alexander Graf
2021-02-19 16:47 ` Laszlo Ersek
2021-02-19 17:31 ` Alexander Graf [this message]
2021-02-18 20:09 ` [PATCH 2/2] OvmfPkg: Make hibernation critical allocations at own ranges Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=375f989a-5c6f-0986-99d3-8a232751f82e@amazon.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox