From: "Jeremy Linton" <jeremy.linton@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com,
pierre.gondois@arm.com, Matteo.Carlini@arm.com,
Akanksha.Jain2@arm.com, Ben.Adderson@arm.com,
thomas.abraham@arm.com, nd@arm.com
Subject: Re: [PATCH edk2-platforms v2 06/11] Platform/RaspberryPi: Update for IORT revision macro renaming
Date: Thu, 7 Jul 2022 08:48:48 -0500 [thread overview]
Message-ID: <37627341-6986-8709-9b32-f48fb4584248@arm.com> (raw)
In-Reply-To: <20220706103952.36268-7-sami.mujawar@arm.com>
Hi,
On 7/6/22 05:39, Sami Mujawar wrote:
> The IORT Specification E.d updates the IORT table revision to 5. To
> reflect this change the IORT header file has been updated to rename
> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
> EFI_ACPI_IO_REMAPPING_TABLE_REV0.
>
> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> macro in the IORT table for RaspberryPi platform to
> EFI_ACPI_IO_REMAPPING_TABLE_REV0.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc
> index 810307ae376f7d24790775f499daa09e3137fe6c..3ca5471081f2b43e624b35fc7b9bda856b15daa9 100644
> --- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
> +++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
> @@ -28,7 +28,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
> {
> ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
> RPI4_IO_REMAPPING_STRUCTURE,
> - EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
> + EFI_ACPI_IO_REMAPPING_TABLE_REV0),
> 3, // NumNodes
> sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset
> 0 // Reserved
So, this looks fine to me.
Thanks,
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
next prev parent reply other threads:[~2022-07-07 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 10:39 [PATCH edk2-platforms v2 00/11] Fix build breaks and update IORT revision macro Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 01/11] Platform/ARM: FVP: Update for IORT revision macro renaming Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 02/11] Platform/ARM: Morello: " Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 03/11] Platform/ARM: SGI: " Sami Mujawar
2022-07-06 14:18 ` Thomas Abraham
2022-07-06 15:15 ` Sami Mujawar
2022-07-06 15:38 ` Thomas Abraham
2022-07-06 10:39 ` [PATCH edk2-platforms v2 04/11] Silicon/AMD/Styx: " Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 05/11] Silicon/Socionext/SynQuacer: " Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 06/11] Platform/RaspberryPi: " Sami Mujawar
2022-07-07 13:48 ` Jeremy Linton [this message]
2022-07-06 10:39 ` [PATCH edk2-platforms v2 07/11] Platform/ARM: N1SDP: " Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 08/11] Silicon/Ampere: Add VariableFlashInfoLib Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 09/11] Platform/Ampere: JadePkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 10/11] Silicon/Phytium: Add VariableFlashInfoLib Sami Mujawar
2022-07-06 10:39 ` [PATCH edk2-platforms v2 11/11] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37627341-6986-8709-9b32-f48fb4584248@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox