From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.25631.1574351489971413415 for ; Thu, 21 Nov 2019 07:51:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DoCj5n7Z; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574351489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v1whXweK8oucCvLRpZarO3AjkWbs+ybP2Xv5Smz+Vzk=; b=DoCj5n7Z/Y50k/XSFUga0QQPIn+q9eRbLB27i3crqoDFmcWMtPYoH2HjvhyvkQwvxdS5TZ nvCPSDKn0OKH/R+ZGYCG8CiiUHMCDekL21ggrtEwbnSXF2HwQFlGMnvNkafHa/BNXEQ0iH tyeNi1Guj54S6Q6s95YdNOs61g+e8As= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-W7Q3eZO5Pq2n9yAZuEro1g-1; Thu, 21 Nov 2019 10:51:27 -0500 Received: by mail-wm1-f70.google.com with SMTP id m68so1999729wme.7 for ; Thu, 21 Nov 2019 07:51:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KolSzRKhANCDrsbgp1DtZyJNZNlDl1y0wWIxCkOOk48=; b=j+9VbPHJL+a+5/Y1TUFllcTMFOwc/jxJbwuFNwgWLq5X2+ohmw9o5GOaSw3rVla5e8 G7UC5lTH9Yrsa7K4yL3AZvTiCVPdp2zo+kZ7RdmSVOQgcjFtMTXaVGhBzqMHnf+X1Nrg qiXMZB9y0bz7DOQUIzgDCbnfj3g1xk6J9WOa+0qDQACFKO2uLw13NdJJBK4I12Ro66bk NQEQbKih7iBZg9PGJ9fxl4SuSs96R/2pmd/kTUGSSZAEeJ1x6x8XWfOTEHKbXilGr8a/ +0/YkSQP0nkM4QLJ8eGUh17fxP8EYknB42FkeAJ5tNuHMvYaRY0GJh2qcy2C1Dbu36AG E6oA== X-Gm-Message-State: APjAAAUjWKLHfNywVB5jAlM+0M6y2IeMG0Ti25V1XR5fatsApmPjPqBL IxcnHHKFI6POCQ+7qkpb2J/FSJUu73dFazmedkAGs1J9jk5spBeNGITGm1+AzWogLIBU9BC9dRz s3M2No5nq86VSnw== X-Received: by 2002:adf:f007:: with SMTP id j7mr1595302wro.41.1574351486320; Thu, 21 Nov 2019 07:51:26 -0800 (PST) X-Google-Smtp-Source: APXvYqz06v2OmW8neopG99OSR4cl44Fid+7H3IYn7/K3BTohFfWOCj9qfjQX2CjzvzEfGFUJ6MZAOA== X-Received: by 2002:adf:f007:: with SMTP id j7mr1595278wro.41.1574351486109; Thu, 21 Nov 2019 07:51:26 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id x205sm88488wmb.5.2019.11.21.07.51.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:51:25 -0800 (PST) Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h" To: devel@edk2.groups.io, lersek@redhat.com Cc: Jian J Wang , Leif Lindholm , Shenglei Zhang , Xiaoyu Lu References: <20191121093833.13840-1-lersek@redhat.com> <20191121093833.13840-4-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <3766b29c-1c26-188e-68bf-a898973f6dba@redhat.com> Date: Thu, 21 Nov 2019 16:51:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121093833.13840-4-lersek@redhat.com> X-MC-Unique: W7Q3eZO5Pq2n9yAZuEro1g-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 11/21/19 10:38 AM, Laszlo Ersek via Groups.Io wrote: > Commit 8906f076de35 ("CryptoPkg/OpensslLib: Add missing header files in > INF file", 2019-08-16) incorrectly placed "ms/uplink.h" in the > auto-generated part of [Sources], in "OpensslLib.inf". >=20 > ("ms/uplink.h" was added in the right spot in "OpensslLibCrypto.inf".) >=20 > Subsequently, when commit 9f4fbd56d430 ("CryptoPkg/OpensslLib: Update > process_files.pl to generate .h files", 2019-10-30) re-generated that par= t > of "OpensslLib.inf", the "ms/uplink.h" file reference was lost. This > triggers a warning from the "build" utility now. >=20 > Name the header file in the right spot in [Sources]. >=20 > This change makes "OpensslLib.inf" consistent with "OpensslLibCrypto.inf"= . >=20 > Cc: Jian J Wang > Cc: Leif Lindholm > Cc: Shenglei Zhang > Cc: Xiaoyu Lu > Fixes: 8906f076de35b222a7d62bcf6ed1a4a2498a5791 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > Targeting edk2-stable201911. >=20 > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Libr= ary/OpensslLib/OpensslLib.inf > index 58202f83118d..3fa52f554320 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -23,6 +23,7 @@ [Defines] > =20 > [Sources] > $(OPENSSL_PATH)/e_os.h > + $(OPENSSL_PATH)/ms/uplink.h > # Autogenerated files list starts here > $(OPENSSL_PATH)/crypto/aes/aes_cbc.c > $(OPENSSL_PATH)/crypto/aes/aes_cfb.c >=20 Reviewed-by: Philippe Mathieu-Daude