From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.41934.1599487121500049654 for ; Mon, 07 Sep 2020 06:58:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d3NYZakT; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599487120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xZq9UblwdXGIqv0C/ebHIx5gNbTuvxhvaJIhjuAcIQ4=; b=d3NYZakTpMqtsLUJLiwAlpUzDM6Rf0Zxevhko34BM1aTK2Pw4yzxE22qPlXjkegISH1bTo c6L72Sl2mkZDum2o9Y0cZ7hx37FPpI+VIZFv+KsSyAN0x6NLGsV4q8zsgDBJdQkr4DHepx 84OuyEukgWD22sfwzVYfNyANyWIo9a4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-ToWOeCDNMzSxZGOKJ0XCHw-1; Mon, 07 Sep 2020 09:58:32 -0400 X-MC-Unique: ToWOeCDNMzSxZGOKJ0XCHw-1 Received: by mail-ed1-f70.google.com with SMTP id c25so4925037edx.11 for ; Mon, 07 Sep 2020 06:58:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xZq9UblwdXGIqv0C/ebHIx5gNbTuvxhvaJIhjuAcIQ4=; b=krXfkY+5cixWgIb4BPCz6EeNt6ks1wLHEwx8Knxv1cP1II+x0J/0J2b9Sizisk/Edu 8hCWpYI6eWdE/0MZ713ZXEFjdLsPpcHEXa0qFgSLr0dZkob9p9myImJ0hZ6XKPfqnmtM laBQVhLKH4oYl3xOhRc2w2iTMHwt2N7bJaa6Yj9AgILWY4wM6KnkgBCd1OcDEaXJo7l3 l9ZupXEjNTHDcNiwsNK2dBB7Ybm6TP8HX+j7cLsRFDZyoDemtRure3ke+V5/5kb1445m 28dINk64HC52q5pvjvK0zk0jxlakKaasgJ4OxbG5Cz2uD4iABJoJurztVp95jn/q4Wgq VUyQ== X-Gm-Message-State: AOAM533LP45SFG2Y2MViiPv1pKpF8CPEEiFu3SDDPmrmnc6Oowjl0dt1 QlKYcEXhc2rq+g500/aPAb08TvW4wt+suPMdxYmCP+NyzgByC9iCTEM3Aj5xwgcuKGeDvXXOZwK y3ztGqjoxW4HaoA== X-Received: by 2002:aa7:d417:: with SMTP id z23mr21227724edq.62.1599487111481; Mon, 07 Sep 2020 06:58:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm5+e3RnbHATmQDJjOq2UNi5vgr6sa0dpnCK6g9SY/IYVPd3JSFaRAsaN0a9Cxwv/wAOlR6Q== X-Received: by 2002:aa7:d417:: with SMTP id z23mr21227695edq.62.1599487111215; Mon, 07 Sep 2020 06:58:31 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id v6sm15393980edj.59.2020.09.07.06.58.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Sep 2020 06:58:30 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition To: devel@edk2.groups.io, paul.grimes@amd.com, Laszlo Ersek Cc: Michael D Kinney , Liming Gao , Zhiguang Liu References: <20200827204051.777-1-Paul.Grimes@amd.com> <20200827204051.777-2-Paul.Grimes@amd.com> <552971bb-aa6d-ab1b-9df8-895415ec176e@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <37755166-1c9e-0d30-f4b1-6100cca6be7e@redhat.com> Date: Mon, 7 Sep 2020 15:58:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.004 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US On 9/2/20 5:12 PM, Paul wrote: > [AMD Public Use] > > Hi Lazlo, > > Thanks for the feedback. Noted, I'll spell it out in the future. 'Last initial' was habit from a team I used to work with. > > Thanks, > Paul > > > -----Original Message----- > From: Laszlo Ersek > Sent: Wednesday, September 2, 2020 1:58 AM > To: devel@edk2.groups.io; Grimes, Paul > Cc: Michael D Kinney ; Liming Gao ; Zhiguang Liu > Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition > > [CAUTION: External Email] > > Hi Paul, > > meta: > > On 08/27/20 22:40, Paul wrote: >> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, but >> should be 0x02 per the ACPI Specification. >> >> REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F >> bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2937&data=02%7C01%7Cp >> aul.grimes%40amd.com%7C51cbad882a354dd9f33108d84f1e5a56%7C3dd8961fe488 >> 4e608e11a82d994e183d%7C0%7C0%7C637346339077687090&sdata=WT8dJXxJhK >> LhXU4qGObyYo3KN91WBs3%2FTesgkYdzssA%3D&reserved=0 >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Signed-off-by: Paul G >> --- >> MdePkg/Include/IndustryStandard/Acpi10.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > please consider setting the "user.name" git config knob to your full name. We now have: > > commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0 > Author: Paul > Date: Fri Aug 28 04:40:51 2020 +0800 > > MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition > > and I like to be friendly :) but I think the Author field should state, in general, the full name, not just the first name. > > > Similary, the Signed-off-by tag at the end of the commit message should carry the full name too. Please see section "Developer Certificate of Origin" in "ReadMe.rst": > > """ > Signed-off-by: Developer Name developer@example.org > > where ``Developer Name`` is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing. > """ > > It's quite obvious from the email address that "Paul G" stands for Paul Grimes, but still spell it out. I just notice this and was going to make a comment :) We can not fix the S-o-b tag, but Paul can fix his author name by adding his entry in the .mailmap file: -- >8 -- diff --git a/.mailmap b/.mailmap index ba246ff6cd80..f3a4a5718e67 100644 --- a/.mailmap +++ b/.mailmap @@ -52,6 +52,7 @@ Michael Kubacki Michael Kubacki Ming Tan Nikolai Saoukh +Paul Grimes Philippe Mathieu-Daudé Ray Ni Ray Ni --- Thanks, Phil. > > > (These requests are for the future, of course; the present patch has been merged.) > > Thanks! > Laszlo > > >