From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.220.1673026799456504778 for ; Fri, 06 Jan 2023 09:39:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HDzisIWQ; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 306HZDOV005612; Fri, 6 Jan 2023 17:39:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=g8/ILjA9Q6S2TQmn01ApqfLKORpugt8vAJ+8/hCGTyQ=; b=HDzisIWQXrd1NDKAVJjTTttJEZQ1N0iFXL21VFVf9qF4DUnq9HBm9Hp7bxPTooQkCNvE 2ZuPmvlSSSo2YOUj9JutrqwTD6OLIouWxWN9mgHWFoZW4xcVj/k7AukM4/Te/5gMZGQ5 T0AV0QuWhxyx8uTjpaD6jAHNOTE07cwuvDUI6XzSU5Tvd+4hD9ANhbfEwf+f5D9GV67R +KcCWSYu3+0Jj9/8MKpXNjklbYRwwK97uSpG+ejDIpaxWSpv/L7j5lDhRb1yCNVl0ZDH 6esA23YeBMeihr/yED6tX7lrkXxTltp6E1I3qiKlD17eQb0FDfIVvxPoqYq5JAhFS6H1 Xg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mxktt0nv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Jan 2023 17:39:58 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 306Hdvtl031744 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Jan 2023 17:39:57 GMT Received: from [10.110.97.101] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 6 Jan 2023 09:39:56 -0800 Message-ID: <37793d04-b527-3cba-5fbd-4ec778b8d041@quicinc.com> Date: Fri, 6 Jan 2023 10:39:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support To: Ard Biesheuvel , CC: References: <20230105170155.1444144-1-ardb@kernel.org> From: quic_rcran@quicinc.com In-Reply-To: <20230105170155.1444144-1-ardb@kernel.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 8NvjfO2txQcxnWFi9g_lL53kTXCJNCL_ X-Proofpoint-ORIG-GUID: 8NvjfO2txQcxnWFi9g_lL53kTXCJNCL_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_12,2023-01-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060135 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran -- Rebecca Cran On 1/5/23 10:01, Ard Biesheuvel wrote: > Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test > app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested > on Raspberry Pi 4. Note that the test app is not added to the image - it > can be taken from the build directory and executed from the UEFI shell. > > Signed-off-by: Ard Biesheuvel > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ > Platform/RaspberryPi/RPi4/RPi4.fdf | 1 + > Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c | 8 ++++---- > 3 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index 8ba0ca61851e..4b2b6d1e4b97 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -795,3 +795,6 @@ [Components.common] > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > !endif > + > + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf > + MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf > index 0c782d2f3553..816927761513 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.fdf > +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf > @@ -198,6 +198,7 @@ [FV.FvMain] > INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + INF ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf > > # > # Multiple Console IO support > diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c > index f032f3c79238..0b0943431889 100644 > --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c > +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c > @@ -51,10 +51,10 @@ ArmPlatformInitializeSystemMemory ( > } > > STATIC ARM_CORE_INFO mRpi3InfoTable[] = { > - { 0x0, 0x0, }, // Cluster 0, Core 0 > - { 0x0, 0x1, }, // Cluster 0, Core 1 > - { 0x0, 0x2, }, // Cluster 0, Core 2 > - { 0x0, 0x3, }, // Cluster 0, Core 3 > + { 0x0, }, // Cluster 0, Core 0 > + { 0x1, }, // Cluster 0, Core 1 > + { 0x2, }, // Cluster 0, Core 2 > + { 0x3, }, // Cluster 0, Core 3 > }; > > STATIC