public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>,
	Yeo Reum Yun <YeoReum.Yun@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception
Date: Thu, 14 Sep 2023 08:42:10 +0000	[thread overview]
Message-ID: <3786B652-EEDA-498A-B880-58379AE9408B@arm.com> (raw)
In-Reply-To: <20230913170617.429-6-mikuback@linux.microsoft.com>

Hi Michael,

I would prefer to have the debug macro checks enabled in DynamicTablesPkg to catch any issues. 

Please do not disable this feature for this package.

Regards,

Sami Mujawar

On 13/09/2023, 18:08, "mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>" <mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>> wrote:


From: Michael Kubacki <michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com>>


Adds a CI YAML entry to acknowledge a case where custom strings
contain print specifiers for a single debug macro.


Cc: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com <mailto:Alexei.Fedorov@arm.com>>
Cc: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com>>
---
DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8 ++++++++
1 file changed, 8 insertions(+)


diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
index 5addf8626841..1d41d44bbf33 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
+++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
@@ -130,5 +130,13 @@
# should be ignore
"AdditionalIncludePaths": [] # Additional paths to spell check
# (wildcards supported)
+ },
+
+ "DebugMacroCheck": {
+ "StringSubstitutions": {
+ # DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
+ # Reason: Debug format strings are dynamically set.
+ "Parser[Index].Format": "%d"
+ }
}
}
-- 
2.42.0.windows.2







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108642): https://edk2.groups.io/g/devel/message/108642
Mute This Topic: https://groups.io/mt/101341656/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-09-14  8:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 17:06 [edk2-devel] [PATCH v2 0/7] Add DebugMacroCheck Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix DEBUG macro args Michael Kubacki
2023-09-14  2:50   ` Chang, Abner via groups.io
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 2/7] pip-requirements.txt: Add regex Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 3/7] SecurityPkg.ci.yaml: Add debug macro exception Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: " Michael Kubacki
2023-09-13 17:10   ` Ard Biesheuvel
2023-09-18 22:35     ` Michael Kubacki
2023-09-19  0:05       ` Michael D Kinney
2023-09-19 14:46       ` Ard Biesheuvel
2023-09-19 14:52         ` Leif Lindholm
2023-09-19 15:10           ` Michael D Kinney
2023-09-19 15:12           ` Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: " Michael Kubacki
2023-09-14  8:42   ` Sami Mujawar [this message]
     [not found]   ` <1784B757CEFF413A.31544@groups.io>
2023-09-14  9:22     ` Sami Mujawar
2023-09-18 19:27       ` Michael Kubacki
2023-09-18 22:36       ` Michael Kubacki
2023-09-19  0:26         ` Michael D Kinney
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 6/7] OvmfPkg/PlatformCI: Disable DebugMacroCheck Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 7/7] BaseTools/Plugin: Add DebugMacroCheck Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3786B652-EEDA-498A-B880-58379AE9408B@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox