From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.6227.1615889050695141883 for ; Tue, 16 Mar 2021 03:04:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GLlN1Bbf; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615889049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rG3RxCndQkU2B+wi0eO3SvXem954Dwt9rSYsa4c7z3w=; b=GLlN1BbffslkKlmx9EQukNsIus0XO+AOgoW3A6zIWYLb6h7LZK60N8/mXbtAvNsYKAlQze +peTFaToyDgRmR1aIpLCZCIsM3q9Knx0KCWozkOF8F6boIHpHRM1S99rkrNUuUAC1TBcJ2 V/iO/oO9e1xjw8BOgr5N7JSbLEbeOCk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-57rkHP_fPw2alF8oi3ZO7A-1; Tue, 16 Mar 2021 06:04:07 -0400 X-MC-Unique: 57rkHP_fPw2alF8oi3ZO7A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6195A8B5D7A; Tue, 16 Mar 2021 10:03:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-138.ams2.redhat.com [10.36.114.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69C861B49F; Tue, 16 Mar 2021 10:03:49 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v9 05/10] OvmfPkg: define CPU_HOT_EJECT_DATA To: devel@edk2.groups.io, ankur.a.arora@oracle.com Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com, Jordan Justen , Ard Biesheuvel , Aaron Young References: <20210312062656.2477515-1-ankur.a.arora@oracle.com> <20210312062656.2477515-6-ankur.a.arora@oracle.com> From: "Laszlo Ersek" Message-ID: <3787c65c-b148-4d7a-9271-2754a31bdc05@redhat.com> Date: Tue, 16 Mar 2021 11:03:48 +0100 MIME-Version: 1.0 In-Reply-To: <20210312062656.2477515-6-ankur.a.arora@oracle.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/12/21 07:26, Ankur Arora wrote: > Define CPU_HOT_EJECT_DATA and add PCD PcdCpuHotEjectDataAddress, which > will be used to share CPU ejection state between OvmfPkg/CpuHotPlugSmm > and PiSmmCpuDxeSmm. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Boris Ostrovsky > Cc: Aaron Young > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 > Signed-off-by: Ankur Arora > --- > > Notes: > Addresses the following comments from v8: > > (1) Get rid of the unnecessary commit specifier from the subject. > (2) s/MaxNumberOfCpus/PcdCpuMaxLogicalProcessorNumber/ > (3) Shifted the comments to be above each structure field. > > OvmfPkg/OvmfPkg.dec | 4 +++ > OvmfPkg/Include/Pcd/CpuHotEjectData.h | 60 +++++++++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > create mode 100644 OvmfPkg/Include/Pcd/CpuHotEjectData.h Reviewed-by: Laszlo Ersek Thanks, Laszlo > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 4348bb45c64a..9629707020ba 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -352,6 +352,10 @@ [PcdsDynamic, PcdsDynamicEx] > # This PCD is only accessed if PcdSmmSmramRequire is TRUE (see below). > gUefiOvmfPkgTokenSpaceGuid.PcdQ35SmramAtDefaultSmbase|FALSE|BOOLEAN|0x34 > > + ## This PCD adds a communication channel between OVMF's SmmCpuFeaturesLib > + # instance in PiSmmCpuDxeSmm, and CpuHotplugSmm. > + gUefiOvmfPkgTokenSpaceGuid.PcdCpuHotEjectDataAddress|0|UINT64|0x46 > + > [PcdsFeatureFlag] > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE|BOOLEAN|0x1c > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|FALSE|BOOLEAN|0x1d > diff --git a/OvmfPkg/Include/Pcd/CpuHotEjectData.h b/OvmfPkg/Include/Pcd/CpuHotEjectData.h > new file mode 100644 > index 000000000000..06714375526c > --- /dev/null > +++ b/OvmfPkg/Include/Pcd/CpuHotEjectData.h > @@ -0,0 +1,60 @@ > +/** @file > + Definition for the CPU_HOT_EJECT_DATA structure, which shares > + CPU hot-eject state between OVMF's SmmCpuFeaturesLib instance in > + PiSmmCpuDxeSmm, and CpuHotplugSmm. > + > + CPU_HOT_EJECT_DATA is allocated in SMRAM, and pointed-to by > + PcdCpuHotEjectDataAddress. > + > + PcdCpuHotEjectDataAddress is valid when SMM_REQUIRE is TRUE > + and PcdCpuMaxLogicalProcessorNumber > 1. > + > + Copyright (C) 2021, Oracle Corporation. > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef CPU_HOT_EJECT_DATA_H_ > +#define CPU_HOT_EJECT_DATA_H_ > + > +/** > + CPU Hot-eject handler, called from SmmCpuFeaturesRendezvousExit() > + on each CPU at exit from SMM. > + > + @param[in] ProcessorNum ProcessorNum denotes the CPU exiting SMM, > + and will be used as an index into > + CPU_HOT_EJECT_DATA->QemuSelectorMap. It is > + identical to the processor handle in > + EFI_SMM_CPU_SERVICE_PROTOCOL. > +**/ > +typedef > +VOID > +(EFIAPI *CPU_HOT_EJECT_HANDLER) ( > + IN UINTN ProcessorNum > + ); > + > +// > +// CPU_EJECT_QEMU_SELECTOR_INVALID marks CPUs not being ejected in > +// CPU_HOT_EJECT_DATA->QemuSelectorMap. > +// > +// QEMU CPU Selector is UINT32, so we choose an invalid value larger > +// than that type. > +// > +#define CPU_EJECT_QEMU_SELECTOR_INVALID (MAX_UINT64) > + > +typedef struct { > + // > + // Maps ProcessorNum -> QemuSelector for pending hot-ejects > + // > + volatile UINT64 *QemuSelectorMap; > + // > + // Handler to do the CPU ejection > + // > + volatile CPU_HOT_EJECT_HANDLER Handler; > + // > + // Entries in the QemuSelectorMap > + // > + UINT32 ArrayLength; > +} CPU_HOT_EJECT_DATA; > + > +#endif // CPU_HOT_EJECT_DATA_H_ >