From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mx.groups.io with SMTP id smtpd.web08.58919.1629311503293505831 for ; Wed, 18 Aug 2021 11:31:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=vnHGMbK+; spf=pass (domain: nuviainc.com, ip: 209.85.216.44, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f44.google.com with SMTP id oa17so3218450pjb.1 for ; Wed, 18 Aug 2021 11:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=G/U0jxbqQAyy7w06PUkASiVGlW8mJYROPTewK8Wfye8=; b=vnHGMbK+QQVBPRiKPGUSibknLBGbZxWoNrw6ReAubaHgjhxb72A2bXg691SeMYiAMS FwTpq0CFaMpCzUiaKJgq6aEXmQEQxtbXxCNLzF8R/k2EiZNMumnAb/2eewb54vLahSlr TMREExKW38fIKlaADjfOMIwKiwfVDo4iPu0a4xgn1xNq4lwH+MiZkIJeb9kwylnvAge2 mVOSBhZwnZ97lmMSZjDftmm+bTKYU9oP4feYR0Up16kkaDYnVcmn1pkJcHtmIect/Jl3 XcFqq56VATzlTzmQ8A5/FxsMVMimDVOQJMf6UHtT1hO/oZNBirxQMEdXDT4FQF8VHSZV y7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=G/U0jxbqQAyy7w06PUkASiVGlW8mJYROPTewK8Wfye8=; b=XaZI4tLI9jK5lq6gcLqZqsUcsNpbQr7dvukcjcm0X8lxYnamPd5xhc4YNeRrj+YrqF cVVEm3uShy+ey+mjubTzc29p7KxTKLrhGt0IFtTELOcn3ikOtMdtmrv3cdGLbf4H2ikp 4NZK6jr5Hhi8pUmfvqayN5k3Pn8p05uxHQqXDKRtXHLPaj46QxjJctHJXbSbbSdfAFzX BFn3sg6AB2nnf/4ZnWn/qBqzKHUmTD1V1db3tXMg9lpNBBtY2vUMV/btSE64Bk1xgHoH /jPwSzqGJyu7r09GGf2qRJrkgdB5VNLmV/YDZqC8qOJSDt7019wj3NsunDLL3mtR1SoR IQhA== X-Gm-Message-State: AOAM531JBx1r0AdqDzoXhu0FFwlEUXh+5r90LsRhMPvQwFu/FoekWj0B NA9OJRbedVg93o7lXrFMqxAGQ3SGgqny795IdRmf1c2/zX9GSyS7NFAudODD2KS0wa4fV6VTH5A 51f+G4rwJh/JrouKdVffTfBdX4zbD0UlvBvuS2b0OCBdAMrZPEma107eQEwfs5R87VM17E6hQ X-Google-Smtp-Source: ABdhPJwxqNIO3tyLOG7i0tudPx9L176RdTZ30+LQrDIlbbtayIsHYIohRgqSFQNaVLlvt+F7sY+Jyw== X-Received: by 2002:a17:902:d48e:b0:12d:7aa5:de2e with SMTP id c14-20020a170902d48e00b0012d7aa5de2emr8317826plg.34.1629311502185; Wed, 18 Aug 2021 11:31:42 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id i8sm493299pfo.117.2021.08.18.11.31.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 11:31:41 -0700 (PDT) Subject: Re: [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build To: Michael D Kinney , devel@edk2.groups.io References: <20210818054206.1223-1-michael.d.kinney@intel.com> <20210818054206.1223-4-michael.d.kinney@intel.com> From: "Rebecca Cran" Message-ID: <378d8020-eea0-2f49-3879-8768120392d7@nuviainc.com> Date: Wed, 18 Aug 2021 12:31:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210818054206.1223-4-michael.d.kinney@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Maybe add a comment saying why it's disabled, in case fixing it takes some time? -- Rebecca Cran On 8/17/21 11:42 PM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 > > SocketDxe generates build failures with VS2017 and VS2019 due to > use of weak references and /WHOLEARCHIVE. Disable SocketDxe until > weak references can be removed. > > Cc: Rebecca Cran > Signed-off-by: Michael D Kinney > --- > StdLib/StdLib.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc > index d0a0c8a..4c72b4f 100644 > --- a/StdLib/StdLib.inc > +++ b/StdLib/StdLib.inc > @@ -99,7 +99,7 @@ > ########## > # Socket Layer > ########## > - StdLib/SocketDxe/SocketDxe.inf > +# StdLib/SocketDxe/SocketDxe.inf > > > ##############################################################################