From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.groups.io with SMTP id smtpd.web11.3534.1585100919052116901 for ; Tue, 24 Mar 2020 18:48:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QKA3wm5U; spf=pass (domain: redhat.com, ip: 63.128.21.74, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585100918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dfbJostwQ0AS39HSy2wxnUKWdpGuet2zUoxa70BE43Y=; b=QKA3wm5UwGDwNLH7RmOOaXesL2w2GSHNavqWk9fk7qY8bjRJI3GHigexIIS3dZ1ZyBFEgn Br+xIZ5JPsDZPaDZ0jCbjKsJgwUnM2x0FpuWCgB9Bo4ayVL04EoQuzflkaX0a4PNhy9MQY wBlE4Wmob6r8o2gBzz7/Qw4fXZhqKrw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-k-y8Lj-LNg22psC8Z2ykKQ-1; Tue, 24 Mar 2020 21:48:36 -0400 X-MC-Unique: k-y8Lj-LNg22psC8Z2ykKQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CF688014D2; Wed, 25 Mar 2020 01:48:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-139.ams2.redhat.com [10.36.115.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF98010246ED; Wed, 25 Mar 2020 01:48:33 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit To: Liran Alon , devel@edk2.groups.io Cc: nikita.leshchenko@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200316150113.104630-1-liran.alon@oracle.com> <20200316150113.104630-10-liran.alon@oracle.com> <97fa0b88-b64e-7c1d-5210-7f56aa16df34@redhat.com> <6d12f888-6614-244a-8204-895100b6d6f6@oracle.com> From: "Laszlo Ersek" Message-ID: <378e02ab-582a-01db-132e-3a7b5d56844a@redhat.com> Date: Wed, 25 Mar 2020 02:48:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6d12f888-6614-244a-8204-895100b6d6f6@oracle.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/24/20 16:35, Liran Alon wrote: > > On 24/03/2020 17:14, Laszlo Ersek wrote: >> On 03/16/20 16:01, Liran Alon wrote: >> I'm going to stop reviewing this iteration now; please rework the rest >> of the series for v2 with this resource management pattern. >> >> Thanks! >> Laszlo > > Thanks for the very detailed review! > > I have read all your comments and understood them. I am working on > creating a v2 patch-series with all these fixed. > As the Init/UnInit logic is the only place in which this resource > management pattern is done, and as patch-series is split > to small well-defined quite independent patches, can I request that you > will complete review of all v1 patches? > > I will understand if you are too busy for this, but it will allow me to > take into account all your aggregated comments on v1 > to hopefully create a perfect v2 patch-series. As I've tried taking into > account all the comments you gave on Nikita's series. I ended up doing a superficial run over the rest of the series, before arriving at this email of yours. Unfortunately, in the most "meaty" patches, there are many style issues, and they kept throwing me off. It's difficult to ping-pong between style remarks and semantics. Basically, in those patches, I'm asking for style fixes now, so I have a chance at a more substantial review with v2. Thanks Laszlo