public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Shi, Steven" <steven.shi@intel.com>,
	edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: "practical" memory allocation limit?
Date: Mon, 28 Aug 2017 16:39:58 +0200	[thread overview]
Message-ID: <37998be6-89f9-23a7-b1f5-a4527651d708@redhat.com> (raw)
In-Reply-To: <06C8AB66E78EE34A949939824ABE2B313B57604E@shsmsx102.ccr.corp.intel.com>

On 08/28/17 16:25, Shi, Steven wrote:
> Hi Laszlo,
> 
> I happen to have a question about how to correctly get the system memory size on Qemu.
> 
> In the QemuInitializeRam() of OvmfPkg\PlatformPei\MemDetect.c, I add debug info as below to trace the GetSystemMemorySizeBelow4gb() and GetSystemMemorySizeAbove4gb() output. But the output results seems not right if my input memory size > 4GB. See my commands and trace outputs in below.
> 
> 
> 
> MemDetect.c  Line 602:
> 
>   //
> 
>   // Determine total memory size available
> 
>   //
> 
>   LowerMemorySize = GetSystemMemorySizeBelow4gb ();
> 
>   UpperMemorySize = GetSystemMemorySizeAbove4gb ();
> 
>   DEBUG ((EFI_D_INFO, "LowerMemorySize= 0x%x\n", LowerMemorySize));
> 
>   DEBUG ((EFI_D_INFO, "UpperMemorySize= 0x%x\n", UpperMemorySize));
> 
> 
> 
> My test commands and trace outputs:
> 
> $ /opt/qemu/bin/qemu-system-x86_64 -m 5120 -enable-kvm -hda /home/jshi19/workspace/simics5-project/images/luv-v2.1_diskboot_gpt_x86_64_.img -machine pc-q35-2.9 -bios OVMF.fd -serial file:serial.log
> 
> LowerMemorySize= 0x80000000 //2GB, but should not it be 4GB?
> 
> UpperMemorySize= 0xC0000000 //3GB, but should not it be 1GB?

No, this is correct; the values returned are system memory *amounts*.
(On the QEMU command line, the "-m" switch says how much system memory
you have, not the highest address in system memory.)

In the 4GB address space, you don't have *just* system memory, you have
a whole bunch of MMIO too. (Most of that is used for 32-bit MMIO PCI BAR
allocation, some is used for the pflash chip range, LAPICs, etc.) On Q35
you also have 256MB assigned to the MMCONFIG / ECAM area (which provides
direct MMIO access to PCI config space for PCI 256 buses).

The physical memory map also depends on the board model; on i440fx, the
32-bit system memory can go up to 3GB, while on Q35, it only goes up to 2GB.

So, if you pass 5GB to a Q35 machine, 2GB of that are placed in the
address space at [0, 2G), and the other 3GB are placed in the address
space at [4G, 7G).

> $ /opt/qemu/bin/qemu-system-x86_64 -m 6144 -enable-kvm -hda /home/jshi19/workspace/simics5-project/images/luv-v2.1_diskboot_gpt_x86_64_.img -machine pc-q35-2.9 -bios OVMF.fd -serial file:serial.log
> 
> LowerMemorySize= 0x80000000 //2GB, but should not it be 4GB?
> 
> UpperMemorySize= 0x0                 // 0GB, but should not it be 2GB?

With 6G DRAM, 2G go low, and 4G go high.

(Your output is misleading because you used the %x format specifier in
your debug message -- %Lx would be correct, for printing a UINT64 value.)

Laszlo


  reply	other threads:[~2017-08-28 14:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28  8:43 "practical" memory allocation limit? Laszlo Ersek
2017-08-28 14:25 ` Shi, Steven
2017-08-28 14:39   ` Laszlo Ersek [this message]
2017-08-28 15:31     ` Shi, Steven
2017-08-28 16:23       ` Andrew Fish
2017-08-28 17:36         ` Laszlo Ersek
2017-08-28 23:53         ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37998be6-89f9-23a7-b1f5-a4527651d708@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox