Re: [PATCH 0/2] sync some function definitions with their declarations

["Carsey, Jaben" <jaben.carsey@intel.com>]

Reviewed-by Jaben Carsey <Jaben.carsey@intel.com>

> On Feb 6, 2018, at 2:01 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> 
> Repo:   https://github.com/lersek/edk2.git
> Branch: sync_defs_to_decls
> 
> The patches say it all, just a side remark up here:
> 
> These errors would have been caught long ago if we had enabled the
> "-Wmissing-prototypes" gcc option.
> 
> (Unfortunately, we can't enable that option even now, because it --
> laudably -- forces the programmer to give internal linkage ("STATIC") to
> their helper / local functions, and -- as we've learned -- some versions
> of the the Visual Studio debugger choke on STATIC functions. Thus, core
> modules basically never make their internal functions STATIC.)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>  ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with
>    decl.
>  OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with
>    declaration
> 
> OvmfPkg/PlatformPei/AmdSev.c                           |  3 ++-
> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 15 +++++++++------
> 2 files changed, 11 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.1.3.gb7cf6e02401b
>