From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D708A21F0DA4B for ; Tue, 6 Feb 2018 14:50:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 14:56:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,470,1511856000"; d="scan'208";a="199182758" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 06 Feb 2018 14:56:26 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 14:56:26 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by FMSMSX109.amr.corp.intel.com ([169.254.15.91]) with mapi id 14.03.0319.002; Tue, 6 Feb 2018 14:56:25 -0800 From: "Carsey, Jaben" To: Laszlo Ersek CC: edk2-devel-01 , Ard Biesheuvel , Brijesh Singh , "Justen, Jordan L" , "Ni, Ruiyu" Thread-Topic: [PATCH 0/2] sync some function definitions with their declarations Thread-Index: AQHTn5YR9TSkDupeWkG2wbY4a7cJMaOX/EE6 Date: Tue, 6 Feb 2018 22:56:25 +0000 Message-ID: <37E39B00-5DED-4D46-869C-CD6FFCC5F7BF@intel.com> References: <20180206220115.29193-1-lersek@redhat.com> In-Reply-To: <20180206220115.29193-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Subject: Re: [PATCH 0/2] sync some function definitions with their declarations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 22:50:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by Jaben Carsey > On Feb 6, 2018, at 2:01 PM, Laszlo Ersek wrote: >=20 > Repo: https://github.com/lersek/edk2.git > Branch: sync_defs_to_decls >=20 > The patches say it all, just a side remark up here: >=20 > These errors would have been caught long ago if we had enabled the > "-Wmissing-prototypes" gcc option. >=20 > (Unfortunately, we can't enable that option even now, because it -- > laudably -- forces the programmer to give internal linkage ("STATIC") to > their helper / local functions, and -- as we've learned -- some versions > of the the Visual Studio debugger choke on STATIC functions. Thus, core > modules basically never make their internal functions STATIC.) >=20 > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Jaben Carsey > Cc: Jordan Justen > Cc: Ruiyu Ni >=20 > Thanks > Laszlo >=20 > Laszlo Ersek (2): > ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with > decl. > OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with > declaration >=20 > OvmfPkg/PlatformPei/AmdSev.c | 3 ++- > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 15 +++++++++----= -- > 2 files changed, 11 insertions(+), 7 deletions(-) >=20 > --=20 > 2.14.1.3.gb7cf6e02401b >=20